BlockSetTest::testProvidePermissions() - Code Metrics - sheadawson/silverstripe-blocks - Measure and Improve Code Quality continuously with Scrutinizer

BlockSetTest::testProvidePermissions() A
last analyzed 2018-05-16 22:27 UTC

↳ Parent: BlockSetTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	0

<?php

namespace SheaDawson\Blocks\Test;

use SheaDawson\Blocks\Model\BlockSet;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\FieldList;
use SilverStripe\Security\Member;

class BlockSetTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'fixtures.yml';

    /**
     *
     */
    public function testGetCMSFields()
    {
        $object = $this->objFromFixture(BlockSet::class, 'default');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf(FieldList::class, $fields);
    }

    /**
     *
     */
    public function testCanView()

    {
        $object = $this->objFromFixture(BlockSet::class, 'default');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanEdit()

    {
        $object = $this->objFromFixture(BlockSet::class, 'default');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canEdit($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canEdit($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanDelete()

    {
        $object = $this->objFromFixture(BlockSet::class, 'default');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canDelete($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canDelete($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testCanCreate()

    {
        $object = $this->objFromFixture(BlockSet::class, 'default');
        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     *
     */
    public function testProvidePermissions()
    {
        $object = singleton(BlockSet::class);
        $expected = [
            'BLOCKSET_EDIT' => [
                'name' => _t('BlockSet.EditBlockSet','Edit a Block Set'),
                'category' => _t('Block.PermissionCategory', 'Blocks'),
            ],
            'BLOCKSET_DELETE' => [
                'name' => _t('BlockSet.DeleteBlockSet','Delete a Block Set'),
                'category' => _t('Block.PermissionCategory', 'Blocks'),
            ],
            'BLOCKSET_CREATE' => [
                'name' => _t('BlockSet.CreateBlockSet','Create a Block Set'),
                'category' => _t('Block.PermissionCategory', 'Blocks'),
            ],
        ];

        $this->assertEquals($expected, $object->providePermissions());
    }
}

1		<?php
2
3		namespace SheaDawson\Blocks\Test;
4
5		use SheaDawson\Blocks\Model\BlockSet;
6		use SilverStripe\Dev\SapphireTest;
7		use SilverStripe\Forms\FieldList;
8		use SilverStripe\Security\Member;
9
10		class BlockSetTest extends SapphireTest
11		{
12		/**
13		* @var string
14		*/
15		protected static $fixture_file = 'fixtures.yml';
16
17		/**
18		*
19		*/
20		public function testGetCMSFields()
21		{
22		$object = $this->objFromFixture(BlockSet::class, 'default');
23		$fields = $object->getCMSFields();
24		$this->assertInstanceOf(FieldList::class, $fields);
25		}
26
27		/**
28		*
29		*/
30	View Code Duplication	public function testCanView()
		0 ignored issues – show Duplication introduced 2017-08-01 14:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$object = $this->objFromFixture(BlockSet::class, 'default');
33		$admin = $this->objFromFixture(Member::class, 'admin');
34		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `33` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35		$member = $this->objFromFixture(Member::class, 'default');
36		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `35` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37		}
38
39		/**
40		*
41		*/
42	View Code Duplication	public function testCanEdit()
		0 ignored issues – show Duplication introduced 2017-08-01 14:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$object = $this->objFromFixture(BlockSet::class, 'default');
45		$admin = $this->objFromFixture(Member::class, 'admin');
46		$this->assertTrue($object->canEdit($admin));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `45` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
47		$member = $this->objFromFixture(Member::class, 'default');
48		$this->assertFalse($object->canEdit($member));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `47` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
49		}
50
51		/**
52		*
53		*/
54	View Code Duplication	public function testCanDelete()
		0 ignored issues – show Duplication introduced 2017-08-01 14:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$object = $this->objFromFixture(BlockSet::class, 'default');
57		$admin = $this->objFromFixture(Member::class, 'admin');
58		$this->assertTrue($object->canDelete($admin));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `57` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
59		$member = $this->objFromFixture(Member::class, 'default');
60		$this->assertFalse($object->canDelete($member));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `59` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
61		}
62
63		/**
64		*
65		*/
66	View Code Duplication	public function testCanCreate()
		0 ignored issues – show Duplication introduced 2017-08-01 14:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		$object = $this->objFromFixture(BlockSet::class, 'default');
69		$admin = $this->objFromFixture(Member::class, 'admin');
70		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `69` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
71		$member = $this->objFromFixture(Member::class, 'default');
72		$this->assertFalse($object->canCreate($member));
		0 ignored issues – show Bug introduced 2017-07-07 02:57 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `71` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
73		}
74
75		/**
76		*
77		*/
78		public function testProvidePermissions()
79		{
80		$object = singleton(BlockSet::class);
81		$expected = [
82		'BLOCKSET_EDIT' => [
83		'name' => _t('BlockSet.EditBlockSet','Edit a Block Set'),
84		'category' => _t('Block.PermissionCategory', 'Blocks'),
85		],
86		'BLOCKSET_DELETE' => [
87		'name' => _t('BlockSet.DeleteBlockSet','Delete a Block Set'),
88		'category' => _t('Block.PermissionCategory', 'Blocks'),
89		],
90		'BLOCKSET_CREATE' => [
91		'name' => _t('BlockSet.CreateBlockSet','Create a Block Set'),
92		'category' => _t('Block.PermissionCategory', 'Blocks'),
93		],
94		];
95
96		$this->assertEquals($expected, $object->providePermissions());
97		}
98		}

sheadawson / silverstripe-blocks

GitHub Access Token became invalid

BlockSetTest::testProvidePermissions() A last analyzed 2018-05-16 22:27 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BlockSetTest::testProvidePermissions() A
last analyzed 2018-05-16 22:27 UTC