Paynet::CancelTransaction() - Code Metrics - Inspection of "Update Paynet.php" - shaxzodbek-uzb/pay-uz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f52c10...986715 )

by Shaxzodbek

created 2020-05-16 07:47 UTC

Paynet::CancelTransaction() A

↳ Parent: Paynet

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	9.52
c	0
b	0
f	0
cc	3
nc	2
nop	0

<?php
namespace Goodoneuz\PayUz\Http\Classes\Paynet;

use Goodoneuz\PayUz\Models\Transaction;
use Goodoneuz\PayUz\Models\PaymentSystem;
use Goodoneuz\PayUz\Services\PaymentService;
use Goodoneuz\PayUz\Http\Classes\DataFormat;
use Goodoneuz\PayUz\Http\Classes\BaseGateway;
use Goodoneuz\PayUz\Models\PaymentSystemParam;
use Goodoneuz\PayUz\Http\Classes\PaymentException;
use Goodoneuz\PayUz\Services\PaymentSystemService;

class Paynet extends BaseGateway
{
    public $config;
    public $request;
    public $response;
    public $merchant;
    public function __construct()
    {
        $this->config   = PaymentSystemService::getPaymentSystemParamsCollect(PaymentSystem::PAYNET);
        $this->response  = new Response();
        $this->request  = new Request($this->response);
        $this->response->setRequest($this->request);
        $this->merchant = new Merchant($this->config, $this->request, $this->response);
    }
    public function run(){
        $this->merchant->Authorize();
        switch ($this->request->params['method']) {
            case Request::METHOD_CheckTransaction:
                $body = Response::makeResponse($this->CheckTransaction());
                break;
            case Request::METHOD_PerformTransaction:
                $body = Response::makeResponse($this->PerformTransaction());
                break;
            case Request::METHOD_CancelTransaction:
                $body = Response::makeResponse($this->CancelTransaction());
                break;
            case Request::METHOD_GetStatement:
                $body = $this->GetStatement();
                break;
            case Request::METHOD_GetInformation:
                $body = Response::makeResponse($this->GetInformation());
                break;
            default:
                $this->response->response($this->request, 'Method not found.', PaynetException::ERROR_METHOD_NOT_FOUND);
        }
        $this->response->response($this->request, $body, Response::SUCCESS);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }


    private function CheckTransaction()
    {
        $transaction = $this->getTransactionBySystemTransactionId();
        $transactionState = ($transaction->state == Transaction::STATE_CANCELLED) ? 2 : 1;

        return "<ns2:CheckTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
            "<errorMsg>Success</errorMsg>".
            "<status>0</status>".
            "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
            "<providerTrnId>".$this->request->params['transactionId']."</providerTrnId>".
            "<transactionState>" . $transactionState . "</transactionState>".
            "<transactionStateErrorStatus>0</transactionStateErrorStatus>".
            "<transactionStateErrorMsg>Success</transactionStateErrorMsg>".
            "</ns2:CheckTransactionResult>";
            
    }


    private function PerformTransaction()
    {
        if ($this->getTransactionBySystemTransactionId())
            return "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
                "<errorMsg>transaction found</errorMsg>".
                "<status>201</status>".
                "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                "<providerTrnId>" . $this->request->params['transactionId'] . "</providerTrnId>".
                "</ns2:PerformTransactionResult>";
        
        $model = PaymentService::convertKeyToModel($this->request->params['key']);
        
        // TODO: check if user not found return status 302;
        
        if (is_null($model)) {
            return  "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
                "<errorMsg>Model not found</errorMsg>".
                "<status>302</status>".
                "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                "<providerTrnId>0</providerTrnId>".
                "</ns2:PerformTransactionResult>";
        }
        // TODO: check if user be yuridik litso can not return status 501;

        $create_time = DataFormat::timestamp(true);
        
        $detail = json_encode(array(
            'create_time'           => $create_time,
            'perform_time'          => null,
            'cancel_time'           => null,
            'system_time_datetime'  => DataFormat::timestamp2datetime($this->request->params['transactionTime'])
        ));
        $transaction = Transaction::create([

            'payment_system'        => PaymentSystem::PAYNET,
            'system_transaction_id' => $this->request->params['transactionId'],
            'amount'                => 1 * $this->request->params['amount'],
            'currency_code'         => Transaction::CURRENCY_CODE_UZS,
            'state'                 => Transaction::STATE_CREATED,
            'updated_time'          => 1*$create_time,
            'comment'               => (isset($this->request->params['error_note'])?$this->request->params['error_note']:''),
            'detail'                => $detail,
            'transactionable_type'  => get_class($model),
            'transactionable_id'    => $model->id
        ]);

        PaymentService::payListener(null,$transaction,'after-pay');

        return  "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
            "<errorMsg>Success</errorMsg>".
            "<status>0</status>".
            "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
            "<providerTrnId>" . $this->request->params['transactionId'] . "</providerTrnId>".
            "</ns2:PerformTransactionResult>";
    }

    private function CancelTransaction(){

        $transaction = $this->getTransactionBySystemTransactionId();

        if ($transaction == null || $transaction->state == Transaction::STATE_CANCELLED)
        {
            return  "<ns2:CancelTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
                "<errorMsg>bekor qilingan</errorMsg>".
                "<status>202</status>".
                "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                "<transactionState>2</transactionState>".
                "</ns2:CancelTransactionResult>";
        }

        $transaction->state = Transaction::STATE_CANCELLED;
        $transaction->update();
        PaymentService::payListener(null,$transaction,'cancel-pay');

        return  "<ns2:CancelTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
            "<errorMsg>Success</errorMsg>".
            "<status>0</status>".
            "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
            "<transactionState>2</transactionState>".
            "</ns2:CancelTransactionResult>";
    }


    private function GetStatement()
    {
        
        $transactions = Transaction::where('payment_system', PaymentSystem::PAYNET)
            ->where('state','<>',Transaction::STATE_CANCELLED)
            ->where('created_at','<=',DataFormat::toDateTime($this->request->params['dateTo']))
            ->where('created_at','>=',DataFormat::toDateTime($this->request->params['dateFrom']))
            ->get();
        $statements = '';

        foreach ($transactions as $transaction){
            $statements = $statements .
                "<statements>".
                "<amount>" . $transaction->amount . "</amount>".
                "<providerTrnId>" . $transaction->id . "</providerTrnId>".
                "<transactionId>" . $transaction->system_transaction_id . "</transactionId>".
                "<transactionTime>".DataFormat::toDateTimeWithTimeZone($transaction->created_at)."</transactionTime>".
                "</statements>";
        }

        return  "<SOAP-ENV:Envelope xmlns:SOAP-ENV=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:ns1=\"http://uws.provider.com/\">".
                    "<SOAP-ENV:Body>".
                        "<ns1:GetStatementResult>".
                            "<errorMsg>Success</errorMsg>".
                            "<status>0</status>".
                            "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                            $statements .
                        "</ns1:GetStatementResult>".
                    "</SOAP-ENV:Body>".
                "</SOAP-ENV:Envelope>";
    }

    private function GetInformation(){
        $model = PaymentService::convertKeyToModel($this->request->params['key']);
        
        if ($model) {
            return  "<ns2:GetInformationResult xmlns:ns2=\"http://uws.provider.com/\">".
                "<errorMsg>Success</errorMsg>".
                "<status>0</status>".
                "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                "<parameters>".
                "<paramKey>userInfo</paramKey>".
                "<paramValue>".$model->name."</paramValue>".
                "</parameters>".
                "</ns2:GetInformationResult>";
        }else{
            return  "<ns2:GetInformationResult xmlns:ns2=\"http://uws.provider.com/\">".
                "<errorMsg>Not Found</errorMsg>".
                "<status>302</status>".
                "<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
                "</ns2:GetInformationResult>";
        }
    }
    

    private function getTransactionBySystemTransactionId()
    {
        return Transaction::where('system_transaction_id', $this->request->params['transactionId'])->first();
    }
}


GitHub Access Token became invalid

Push — master ( f52c10...986715 )

Paynet::CancelTransaction() A

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2			namespace Goodoneuz\PayUz\Http\Classes\Paynet;
3
4			use Goodoneuz\PayUz\Models\Transaction;
5			use Goodoneuz\PayUz\Models\PaymentSystem;
6			use Goodoneuz\PayUz\Services\PaymentService;
7			use Goodoneuz\PayUz\Http\Classes\DataFormat;
8			use Goodoneuz\PayUz\Http\Classes\BaseGateway;
9			use Goodoneuz\PayUz\Models\PaymentSystemParam;
10			use Goodoneuz\PayUz\Http\Classes\PaymentException;
11			use Goodoneuz\PayUz\Services\PaymentSystemService;
12
13			class Paynet extends BaseGateway
14			{
15			public $config;
16			public $request;
17			public $response;
18			public $merchant;
19			public function __construct()
20			{
21			$this->config = PaymentSystemService::getPaymentSystemParamsCollect(PaymentSystem::PAYNET);
22			$this->response = new Response();
23			$this->request = new Request($this->response);
24			$this->response->setRequest($this->request);
25			$this->merchant = new Merchant($this->config, $this->request, $this->response);
26			}
27			public function run(){
28			$this->merchant->Authorize();
29			switch ($this->request->params['method']) {
30			case Request::METHOD_CheckTransaction:
31			$body = Response::makeResponse($this->CheckTransaction());
32			break;
33			case Request::METHOD_PerformTransaction:
34			$body = Response::makeResponse($this->PerformTransaction());
35			break;
36			case Request::METHOD_CancelTransaction:
37			$body = Response::makeResponse($this->CancelTransaction());
38			break;
39			case Request::METHOD_GetStatement:
40			$body = $this->GetStatement();
41			break;
42			case Request::METHOD_GetInformation:
43			$body = Response::makeResponse($this->GetInformation());
44			break;
45			default:
46			$this->response->response($this->request, 'Method not found.', PaynetException::ERROR_METHOD_NOT_FOUND);
47			}
48			$this->response->response($this->request, $body, Response::SUCCESS);
			0 ignored issues – show Bug introduced 2020-05-16 07:48 UTC by Report Bug Copy Issue Report The variable `$body` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
49			}
50
51
52			private function CheckTransaction()
53			{
54			$transaction = $this->getTransactionBySystemTransactionId();
55			$transactionState = ($transaction->state == Transaction::STATE_CANCELLED) ? 2 : 1;
56
57			return "<ns2:CheckTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
58			"<errorMsg>Success</errorMsg>".
59			"<status>0</status>".
60			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
61			"<providerTrnId>".$this->request->params['transactionId']."</providerTrnId>".
62			"<transactionState>" . $transactionState . "</transactionState>".
63			"<transactionStateErrorStatus>0</transactionStateErrorStatus>".
64			"<transactionStateErrorMsg>Success</transactionStateErrorMsg>".
65			"</ns2:CheckTransactionResult>";
66
67			}
68
69
70			private function PerformTransaction()
71			{
72			if ($this->getTransactionBySystemTransactionId())
73			return "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
74			"<errorMsg>transaction found</errorMsg>".
75			"<status>201</status>".
76			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
77			"<providerTrnId>" . $this->request->params['transactionId'] . "</providerTrnId>".
78			"</ns2:PerformTransactionResult>";
79
80			$model = PaymentService::convertKeyToModel($this->request->params['key']);
81
82			// TODO: check if user not found return status 302;
83
84			if (is_null($model)) {
85			return "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
86			"<errorMsg>Model not found</errorMsg>".
87			"<status>302</status>".
88			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
89			"<providerTrnId>0</providerTrnId>".
90			"</ns2:PerformTransactionResult>";
91			}
92			// TODO: check if user be yuridik litso can not return status 501;
93
94			$create_time = DataFormat::timestamp(true);
95
96			$detail = json_encode(array(
97			'create_time' => $create_time,
98			'perform_time' => null,
99			'cancel_time' => null,
100			'system_time_datetime' => DataFormat::timestamp2datetime($this->request->params['transactionTime'])
101			));
102			$transaction = Transaction::create([
			0 ignored issues – show Bug introduced 2020-05-16 07:48 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Goodoneuz\PayUz\Models\Transaction`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
103			'payment_system' => PaymentSystem::PAYNET,
104			'system_transaction_id' => $this->request->params['transactionId'],
105			'amount' => 1 * $this->request->params['amount'],
106			'currency_code' => Transaction::CURRENCY_CODE_UZS,
107			'state' => Transaction::STATE_CREATED,
108			'updated_time' => 1*$create_time,
109			'comment' => (isset($this->request->params['error_note'])?$this->request->params['error_note']:''),
110			'detail' => $detail,
111			'transactionable_type' => get_class($model),
112			'transactionable_id' => $model->id
113			]);
114
115			PaymentService::payListener(null,$transaction,'after-pay');
116
117			return "<ns2:PerformTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
118			"<errorMsg>Success</errorMsg>".
119			"<status>0</status>".
120			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
121			"<providerTrnId>" . $this->request->params['transactionId'] . "</providerTrnId>".
122			"</ns2:PerformTransactionResult>";
123			}
124
125			private function CancelTransaction(){
126
127			$transaction = $this->getTransactionBySystemTransactionId();
128
129			if ($transaction == null \|\| $transaction->state == Transaction::STATE_CANCELLED)
130			{
131			return "<ns2:CancelTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
132			"<errorMsg>bekor qilingan</errorMsg>".
133			"<status>202</status>".
134			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
135			"<transactionState>2</transactionState>".
136			"</ns2:CancelTransactionResult>";
137			}
138
139			$transaction->state = Transaction::STATE_CANCELLED;
140			$transaction->update();
141			PaymentService::payListener(null,$transaction,'cancel-pay');
142
143			return "<ns2:CancelTransactionResult xmlns:ns2=\"http://uws.provider.com/\">".
144			"<errorMsg>Success</errorMsg>".
145			"<status>0</status>".
146			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
147			"<transactionState>2</transactionState>".
148			"</ns2:CancelTransactionResult>";
149			}
150
151
152			private function GetStatement()
153			{
154
155			$transactions = Transaction::where('payment_system', PaymentSystem::PAYNET)
156			->where('state','<>',Transaction::STATE_CANCELLED)
157			->where('created_at','<=',DataFormat::toDateTime($this->request->params['dateTo']))
158			->where('created_at','>=',DataFormat::toDateTime($this->request->params['dateFrom']))
159			->get();
160			$statements = '';
161
162			foreach ($transactions as $transaction){
163			$statements = $statements .
164			"<statements>".
165			"<amount>" . $transaction->amount . "</amount>".
166			"<providerTrnId>" . $transaction->id . "</providerTrnId>".
167			"<transactionId>" . $transaction->system_transaction_id . "</transactionId>".
168			"<transactionTime>".DataFormat::toDateTimeWithTimeZone($transaction->created_at)."</transactionTime>".
169			"</statements>";
170			}
171
172			return "<SOAP-ENV:Envelope xmlns:SOAP-ENV=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:ns1=\"http://uws.provider.com/\">".
173			"<SOAP-ENV:Body>".
174			"<ns1:GetStatementResult>".
175			"<errorMsg>Success</errorMsg>".
176			"<status>0</status>".
177			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
178			$statements .
179			"</ns1:GetStatementResult>".
180			"</SOAP-ENV:Body>".
181			"</SOAP-ENV:Envelope>";
182			}
183
184			private function GetInformation(){
185			$model = PaymentService::convertKeyToModel($this->request->params['key']);
186
187			if ($model) {
188			return "<ns2:GetInformationResult xmlns:ns2=\"http://uws.provider.com/\">".
189			"<errorMsg>Success</errorMsg>".
190			"<status>0</status>".
191			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
192			"<parameters>".
193			"<paramKey>userInfo</paramKey>".
194			"<paramValue>".$model->name."</paramValue>".
195			"</parameters>".
196			"</ns2:GetInformationResult>";
197			}else{
198			return "<ns2:GetInformationResult xmlns:ns2=\"http://uws.provider.com/\">".
199			"<errorMsg>Not Found</errorMsg>".
200			"<status>302</status>".
201			"<timeStamp>".DataFormat::toDateTimeWithTimeZone(now())."</timeStamp>".
202			"</ns2:GetInformationResult>";
203			}
204			}
205
206
207			private function getTransactionBySystemTransactionId()
208			{
209			return Transaction::where('system_transaction_id', $this->request->params['transactionId'])->first();
210			}
211			}
212

shaxzodbek-uzb / pay-uz

GitHub Access Token became invalid

Push — master ( f52c10...986715 )

Paynet::CancelTransaction() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like