| Conditions | 13 |
| Paths | 22 |
| Total Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | public function setResult($status = null, $params = null) |
||
| 31 | { |
||
| 32 | $this->result['error'] = $status; |
||
| 33 | switch ($status) { |
||
| 34 | case self::SUCCESS: |
||
| 35 | $this->result['error_note'] = 'Success'; |
||
| 36 | break; |
||
| 37 | case self::ERROR_SIGN_CHECK: |
||
| 38 | $this->result['error_note'] = 'Ошибка проверки подписи'; |
||
| 39 | break; |
||
| 40 | case self::ERROR_INVALID_AMOUNT: |
||
| 41 | $this->result['error_note'] = 'Неверная сумма оплаты'; |
||
| 42 | break; |
||
| 43 | case self::ERROR_ACTION_NOT_FOUND: |
||
| 44 | $this->result['error_note'] = 'Запрашиваемое действие не найдено'; |
||
| 45 | break; |
||
| 46 | case self::ERROR_ALREADY_PAID: |
||
| 47 | $this->result['error_note'] = 'Транзакция ранее была подтверждена (при попытке подтвердить или отменить ранее подтвержденную транзакцию)'; |
||
| 48 | break; |
||
| 49 | case self::ERROR_ORDER_NOT_FOUND: |
||
| 50 | $this->result['error_note'] = 'Не найдет пользователь/заказ (проверка параметра merchant_trans_id)'; |
||
| 51 | break; |
||
| 52 | case self::ERROR_TRANSACTION_NOT_FOUND: |
||
| 53 | $this->result['error_note'] = 'Не найдена транзакция (проверка параметра merchant_prepare_id)'; |
||
| 54 | break; |
||
| 55 | case self::ERROR_UPDATE_ORDER: |
||
| 56 | $this->result['error_note'] = 'Ошибка при изменении данных пользователя (изменение баланса счета и т.п.)'; |
||
| 57 | break; |
||
| 58 | case self::ERROR_REQUEST_FROM: |
||
| 59 | $this->result['error_note'] = 'Ошибка в запросе от CLICK (переданы не все параметры и т.п.)'; |
||
| 60 | break; |
||
| 61 | case self::ERROR_TRANSACTION_CANCELLED: |
||
| 62 | $this->result['error_note'] = 'Транзакция ранее была отменена (При попытке подтвердить или отменить ранее отмененную транзакцию)'; |
||
| 63 | break; |
||
| 64 | default: |
||
| 65 | $this->result['error_note'] = 'ERROR_VENDOR_NOT_FOUND'; |
||
| 66 | break; |
||
| 67 | } |
||
| 68 | if (is_array($params)){ |
||
| 69 | foreach ($params as $key => $param ){ |
||
| 70 | $this->result[$key] = $param; |
||
| 71 | } |
||
| 72 | } |
||
| 73 | throw new PaymentException($this); |
||
| 74 | } |
||
| 75 | |||
| 89 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.