Entry - Code Metrics - Inspection of "Easy there..." - shared-logs/api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6fae9a...ddbc6b )

by Seth

created 2018-02-13 02:01 UTC

Entry A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	3

<?php
/** Entry */

namespace Battis\SharedLogs\Objects;

use Battis\SharedLogs\AbstractObject;

/**
 * A log entry
 *
 * Log entries are timestamped notes authored by users and referring to a specific device.
 *
 * @author Seth Battis <[email protected]>
 */
class Entry extends AbstractObject
{
    /** Suppress log sub-object */
    const SUPPRESS_LOG = false;

    /** Suppress user sub-object */
    const SUPPRESS_USER = false;

    /** Canonical field name for references to entry objects in the database */
    const ID = 'entry_id';

    /**
     * Construct an Entry object from a database record
     *
     * @param array $databaseRecord Associative array of fields
     * @param Log|false $log (Optional) Log sub-object (or `Entry::SUPPRESS_LOG`)
     * @param User|false $user (Optional) User sub-object (or `Entry::SUPPRESS_USER`)
     *
     * @throws \Battis\SharedLogs\Exceptions\ObjectException
     */
    public function __construct($databaseRecord, $log = self::SUPPRESS_LOG, $user = self::SUPPRESS_USER)
    {
        parent::__construct($databaseRecord);

        if ($log instanceof Log) {
            $this->log = $log;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        if ($user instanceof User) {
            $this->user = $user;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
    }
}


1		<?php
2		/** Entry */
3
4		namespace Battis\SharedLogs\Objects;
5
6		use Battis\SharedLogs\AbstractObject;
7
8		/**
9		* A log entry
10		*
11		* Log entries are timestamped notes authored by users and referring to a specific device.
12		*
13		* @author Seth Battis <[email protected]>
14		*/
15		class Entry extends AbstractObject
16		{
17		/** Suppress log sub-object */
18		const SUPPRESS_LOG = false;
19
20		/** Suppress user sub-object */
21		const SUPPRESS_USER = false;
22
23		/** Canonical field name for references to entry objects in the database */
24		const ID = 'entry_id';
25
26		/**
27		* Construct an Entry object from a database record
28		*
29		* @param array $databaseRecord Associative array of fields
30		* @param Log\|false $log (Optional) Log sub-object (or `Entry::SUPPRESS_LOG`)
31		* @param User\|false $user (Optional) User sub-object (or `Entry::SUPPRESS_USER`)
32		*
33		* @throws \Battis\SharedLogs\Exceptions\ObjectException
34		*/
35	6	public function __construct($databaseRecord, $log = self::SUPPRESS_LOG, $user = self::SUPPRESS_USER)
36		{
37	6	parent::__construct($databaseRecord);
38
39	5	if ($log instanceof Log) {
40	3	$this->log = $log;
		0 ignored issues – show Bug introduced 2018-02-06 20:03 UTC by Report Bug Copy Issue Report The property `log` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41		}
42	5	if ($user instanceof User) {
43	3	$this->user = $user;
		0 ignored issues – show Bug introduced 2018-02-06 20:03 UTC by Report Bug Copy Issue Report The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44		}
45	5	}
46		}
47

shared-logs / api

Push — master ( 6fae9a...ddbc6b )

Entry A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like