Shapin\Datagen\ReferenceManager

Complexity

Total Complexity

12

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	add()	0	15	4
A	findAndReplace()	0	12	4
A	isReference()	0	4	1
A	resolveReference()	0	13	2

<?php

declare(strict_types=1);

namespace Shapin\Datagen;

use Shapin\Datagen\Exception\DuplicateReferenceException;
use Shapin\Datagen\Exception\UnknownReferenceException;
use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
use Symfony\Component\PropertyAccess\PropertyAccess;

class ReferenceManager
{
    private $references;

    public function __construct()
    {
        $this->references = new \ArrayObject([], \ArrayObject::ARRAY_AS_PROPS);
    }

    public function add(string $fixture, string $name, array $data): void
    {
        if (!array_key_exists($fixture, $this->references)) {
            $this->references[$fixture] = new \ArrayObject([], \ArrayObject::ARRAY_AS_PROPS);
        }
        if (array_key_exists($name, $this->references[$fixture])) {
            throw new DuplicateReferenceException($fixture, $name);
        }

        if (!is_object($data)) {
            $data = new \ArrayObject($data, \ArrayObject::ARRAY_AS_PROPS);
        }

        $this->references[$fixture][$name] = $data;
    }

    public function findAndReplace(array $data): array
    {
        $keys = array_keys($data);
        for ($i = 0; $i < count($data); ++$i) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $value = $data[$keys[$i]];
            if (is_string($value) && $this->isReference($value)) {
                $data[$keys[$i]] = $this->resolveReference($value);
            }
        }

        return $data;
    }

    private function isReference(string $value): bool
    {
        return 'REF:' === substr($value, 0, 4);
    }

    private function resolveReference(string $value)
    {
        $propertyAccessor = PropertyAccess::createPropertyAccessor();
        $parts = explode(':', $value);

        $ref = $parts[1];

        try {
            return $propertyAccessor->getValue($this->references, $ref);
        } catch (NoSuchPropertyException $e) {
            throw new UnknownReferenceException("Unable to resolve Reference \"$value\".", 0, $e);
        }
    }
}