Mdanter\Ecc\Serializer\Signature\Der\Parser::parse()

Complexity

Conditions	6
Paths	5

Size

Total Lines	25
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function parse(string $binary): SignatureInterface
    {
        $offsetIndex = 0;
        $asnObject = ASNObject::fromBinary($binary, $offsetIndex);

        if ($offsetIndex != strlen($binary)) {
            throw new SignatureDecodeException('Invalid data.');
        }

        // Set inherits from Sequence, so use getType!
        if ($asnObject->getType() !== Identifier::SEQUENCE) {
            throw new SignatureDecodeException('Invalid tag for sequence.');
        }

        if ($asnObject->getNumberofChildren() !== 2) {

The method getNumberofChildren() does not exist on FG\ASN1\ASNObject. It seems like you code against a sub-type of FG\ASN1\ASNObject such as FG\ASN1\Construct.

            throw new SignatureDecodeException('Invalid data.');
        }

        if (!($asnObject[0] instanceof Integer && $asnObject[1] instanceof Integer)) {
            throw new SignatureDecodeException('Invalid data.');
        }

        return new Signature(
            gmp_init($asnObject[0]->getContent(), 10),

It seems like gmp_init($asnObject[0]->getContent(), 10) can also be of type resource; however, parameter $r of Mdanter\Ecc\Crypto\Signature\Signature::__construct() does only seem to accept GMP, maybe add an additional type check?

            gmp_init($asnObject[1]->getContent(), 10)

It seems like gmp_init($asnObject[1]->getContent(), 10) can also be of type resource; however, parameter $s of Mdanter\Ecc\Crypto\Signature\Signature::__construct() does only seem to accept GMP, maybe add an additional type check?

        );