RandomNumberGenerator::generate() - Code Metrics - shanecurran/phpecc - Measure and Improve Code Quality continuously with Scrutinizer

RandomNumberGenerator::generate() A
last analyzed 2023-03-08 20:52 UTC

↳ Parent: RandomNumberGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	1
eloc	7
c	2
b	1
f	0
nc	1
nop	1
dl	0
loc	12
rs	10

<?php
declare(strict_types=1);

namespace Mdanter\Ecc\Random;

use Mdanter\Ecc\Math\GmpMathInterface;
use Mdanter\Ecc\Util\NumberSize;

class RandomNumberGenerator implements RandomNumberGeneratorInterface
{
    /**
     * @var GmpMathInterface
     */
    private $adapter;

    /**
     * RandomNumberGenerator constructor.
     * @param GmpMathInterface $adapter
     */
    public function __construct(GmpMathInterface $adapter)
    {
        $this->adapter = $adapter;
    }

    /**
     * @param \GMP $max
     * @return \GMP
     */
    public function generate(\GMP $max): \GMP
    {
        $numBits = NumberSize::bnNumBits($this->adapter, $max);
        $numBytes = (int) ceil($numBits / 8);
        // Generate an integer of size >= $numBits
        $bytes = random_bytes($numBytes);
        $value = $this->adapter->stringToInt($bytes);

        $mask = gmp_sub(gmp_pow(2, $numBits), 1);
        $integer = gmp_and($value, $mask);

        return $integer;

    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Mdanter\Ecc\Random;
5
6			use Mdanter\Ecc\Math\GmpMathInterface;
7			use Mdanter\Ecc\Util\NumberSize;
8
9			class RandomNumberGenerator implements RandomNumberGeneratorInterface
10			{
11			/**
12			* @var GmpMathInterface
13			*/
14			private $adapter;
15
16			/**
17			* RandomNumberGenerator constructor.
18			* @param GmpMathInterface $adapter
19			*/
20			public function __construct(GmpMathInterface $adapter)
21			{
22			$this->adapter = $adapter;
23			}
24
25			/**
26			* @param \GMP $max
27			* @return \GMP
28			*/
29			public function generate(\GMP $max): \GMP
30			{
31			$numBits = NumberSize::bnNumBits($this->adapter, $max);
32			$numBytes = (int) ceil($numBits / 8);
33			// Generate an integer of size >= $numBits
34			$bytes = random_bytes($numBytes);
35			$value = $this->adapter->stringToInt($bytes);
36
37			$mask = gmp_sub(gmp_pow(2, $numBits), 1);
38			$integer = gmp_and($value, $mask);
39
40			return $integer;
			0 ignored issues – show Bug Best Practice introduced 2023-03-08 20:02 UTC by Report Bug Copy Issue Report The expression `return $integer` could return the type `resource` which is incompatible with the type-hinted return `GMP`. Consider adding an additional type-check to rule them out. Loading history...
41			}
42			}
43

shanecurran / phpecc

RandomNumberGenerator::generate() A last analyzed 2023-03-08 20:52 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RandomNumberGenerator::generate() A
last analyzed 2023-03-08 20:52 UTC