ReRoute\Route\RouteGroup

Complexity

Total Complexity

7

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	addRoute()	0	5	1
A	getRoutes()	0	3	1
B	doMatch()	0	18	5

<?php


  namespace ReRoute\Route;


  use ReRoute\RequestContext;
  use ReRoute\RouteMatch;

  /**
   * @package ReRoute\AbstractRoute
   */
  class RouteGroup extends AbstractRoute {

    /**
     * @var AbstractRoute[]
     */
    protected $routes = [];


    /**
     * @param AbstractRoute $route
     * @return $this
     */
    public function addRoute(AbstractRoute $route) {
      $this->routes[] = $route;
      $route->setParentRoute($this);
      return $this;
    }


    /**
     * @return AbstractRoute[]
     */
    public function getRoutes() {
      return $this->routes;
    }


    /**
     * @inheritdoc
     */
    public function doMatch(RequestContext $requestContext) {
      if (empty($this->getRoutes())) {
        throw new \Exception('Routes list can\'t be empty!');
      }
      
      if (false == $this->isMatched($requestContext)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        return false;
      }

      foreach ($this->getRoutes() as $route) {
        $routeMatch = $route->doMatch($requestContext);
        if ($routeMatch instanceof RouteMatch) {
          $routeMatch = $this->storeParametersToRouteMatch($routeMatch);
          return $routeMatch;
        }
      }
      return false;
    }

  }