ReRoute\Route\FinalRoute

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

94.44%

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	getResult()	0	3	1
A	doMatch()	0	8	2
A	build()	0	4	1

<?php


  namespace ReRoute\Route;

  use ReRoute\RouteMatch;
  use ReRoute\Template\UrlTemplate;
  use ReRoute\Url;
  use ReRoute\UrlBuilder;


  /**
   * @package ReRoute\AbstractRoute
   */
  class FinalRoute extends AbstractRoute {

    /**
     * @var
     */
    protected $result;


    /**
     * @param string $routeResult
     * @param null|UrlTemplate $urlTemplate
     */
    public function __construct($routeResult, UrlTemplate $urlTemplate = null) {
      if (!is_string($routeResult)) {
        throw new \InvalidArgumentException('Invalid result type. Expect string. Given "' . gettype($routeResult) . '"');
      }

      $this->result = $routeResult;
      parent::__construct($urlTemplate);
    }


    /**
     * @return mixed
     */
    public function getResult() {
      return $this->result;
    }


    /**
     * @param \ReRoute\RequestContext $requestContext
     *
     * @return RouteMatch|bool
     */
    public function doMatch(\ReRoute\RequestContext $requestContext) {
      if (false == $this->isMatched($requestContext)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        return false;
      }
      $routeMatch = new RouteMatch($this->getResult());
      $this->storeParametersToRouteMatch($routeMatch);
      return $routeMatch;
    }


    /**
     * @inheritdoc
     */
    public function build(Url $url, UrlBuilder $urlBuilder) {
      parent::build($url, $urlBuilder);
      $this->buildModifiers($url, $urlBuilder);
    }
  }