sfneal / tracking

src/Models/TrackTraffic.php

<?php

namespace Sfneal\Tracking\Models;

use Database\Factories\TrackTrafficFactory;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Sfneal\Helpers\Laravel\AppInfo;
use Sfneal\Tracking\Builders\TrackTrafficBuilder;
use Sfneal\Tracking\Models\Base\Tracking;

class TrackTraffic extends Tracking
{
    use HasFactory;

    protected $table = 'track_traffic';
    protected $primaryKey = 'track_traffic_id';

    protected $fillable = [
        'track_traffic_id',
        'user_id',
        'session_id',
        'app_version',
        'app_environment',
        'request_host',
        'request_uri',
        'request_method',
        'request_payload',
        'request_browser',
        'request_ip',
        'request_referrer',
        'request_token',
        'response_code',
        'response_time',
        'response_content',
        'agent_platform',
        'agent_device',
        'agent_browser',
        'time_stamp',
    ];

    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'user_id' => 'int',
        'request_payload' => 'array',
        'response_code' => 'int',
        'response_time' => 'float',
    ];

    /**
     * Create a new factory instance for the model.
     *
     * @return TrackTrafficFactory
     */
    protected static function newFactory(): TrackTrafficFactory
    {
        return new TrackTrafficFactory();
    }

    /**
     * Query Builder.
     *
     * @param $query
     * @return TrackTrafficBuilder
     */
    public function newEloquentBuilder($query)
    {
        return new TrackTrafficBuilder($query);
    }

    /**
     * @return TrackTrafficBuilder|Builder
     */
    public static function query(): TrackTrafficBuilder
    {
        return parent::query();
    }

    /**
     * Tracked activity that is associated with this traffic record.
     *
     * @return BelongsTo
     */
    public function activity()
    {
        return $this->belongsTo(TrackActivity::class, 'request_token', 'request_token');
    }

    /**
     * Set the `app_environment` attribute.
     *
     * @param  null  $value

Are you sure the doc-type for parameter $value is correct as it would always require null to be passed?

     */
    public function setAppEnvironmentAttribute($value = null)
    {
        $this->attributes['app_environment'] = $value ?? AppInfo::env();
    }

    /**
     * Set the 'request_method' attribute.
     *
     * @param  string|null  $value
     */
    public function setRequestMethodAttribute(string $value = null)
    {
        $this->attributes['request_method'] = strtoupper($value);

It seems like $value can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

    }
}