Sfneal\PostOffice\MailCenter\SendMail

Complexity

Total Complexity

5

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	4	2
A	send()	0	15	2
A	__construct()	0	5	1

<?php

namespace Sfneal\PostOffice\MailCenter;

use Illuminate\Mail\Mailable;
use Illuminate\Support\Facades\Mail;
use Sfneal\Queueables\AbstractJob;


class SendMail extends AbstractJob
{
    /**
     * @var string Queue to use
     */
    public $queue = 'mail';

    /**
     * @var string Queue connection to use
     */
    public $connection = 'database';

    /**
     * @var string Email address of recipient
     */
    public $to;

    /**
     * @var string Email address of users to CC
     */
    public $cc;

    /**
     * @var Mailable The mailable to send to the recipient
     */
    public $mailable;

    /**
     * Create a new job instance.
     *
     * @param string $to
     * @param Mailable $mailable
     * @param array|null $cc
     */
    public function __construct(string $to, Mailable $mailable, array $cc = null)
    {
        $this->to = $to;
        $this->mailable = $mailable;
        $this->cc = $cc;

It seems like $cc can also be of type array. However, the property $cc is declared as type string. Maybe add an additional type check?

    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        if (!$this->send()) {
            $this->fail();
        }
    }

    /**
     * Send a Mailable to an email recipient with optional CC recipients
     *
     * @return bool
     */
    private function send()
    {
        // Initialize
        $mail = Mail::to($this->to);

        // CC users if provided
        if (isset($this->cc)) {
            $mail->cc($this->cc);
        }

        // Send mail
        $mail->send($this->mailable);

        // Confirm Email was sent
        return empty(Mail::failures());
    }
}