HoneyPot::requestHasTraps() - Code Metrics - Inspection of "New config keys & unit tests" - sfneal/honeypot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#17)

by Stephen

created 2021-05-10 17:40 UTC

HoneyPot::requestHasTraps() A

↳ Parent: HoneyPot

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
c	0
b	0
f	0
dl	0
loc	14
rs	10
cc	4
nc	4
nop	1

<?php

namespace Sfneal\Honeypot\Middleware;

use Closure;
use Illuminate\Http\Request;
use Spatie\Honeypot\ProtectAgainstSpam;
use Symfony\Component\HttpFoundation\Response;

class HoneyPot extends ProtectAgainstSpam
{
    /**
     * Check if 'first' & 'last' name inputs are the same.
     *
     * @param Request $request
     * @param Closure $next
     *
     * @return Response
     */
    public function handle(Request $request, Closure $next): Response
    {
        // Check if first & last name inputs are the same (typical of spam)
        if ($this->requestHasTraps($request)) {
            return $this->respondToSpam($request, $next);
        }

        // Pass request to parent `ProtectAgainstSpam` handler
        return parent::handle($request, $next);
    }

    /**
     * Determine if a Request contains Honeypot traps.
     *
     * @param Request $request
     * @return bool
     */
    private function requestHasTraps(Request $request): bool
    {
        // Execute check if 'duplicate names' trap is enabled
        if (config('honeypot.traps.duplicate_names.enabled')) {
            $first = config('honeypot.traps.duplicate_names.name_first_input');
            $last = config('honeypot.traps.duplicate_names.name_last_input');

            // Determine if the 'first' & 'last' name inputs are the same
            return ($request->has($first) && $request->has($last))
                && $request->input($first) == $request->input($last);
        }

        // Return false if traps are not enabled
        return false;
    }
}


1			<?php
2
3			namespace Sfneal\Honeypot\Middleware;
4
5			use Closure;
6			use Illuminate\Http\Request;
7			use Spatie\Honeypot\ProtectAgainstSpam;
8			use Symfony\Component\HttpFoundation\Response;
9
10			class HoneyPot extends ProtectAgainstSpam
11			{
12			/**
13			* Check if 'first' & 'last' name inputs are the same.
14			*
15			* @param Request $request
16			* @param Closure $next
17			*
18			* @return Response
19			*/
20			public function handle(Request $request, Closure $next): Response
21			{
22			// Check if first & last name inputs are the same (typical of spam)
23			if ($this->requestHasTraps($request)) {
24			return $this->respondToSpam($request, $next);
25			}
26
27			// Pass request to parent `ProtectAgainstSpam` handler
28			return parent::handle($request, $next);
29			}
30
31			/**
32			* Determine if a Request contains Honeypot traps.
33			*
34			* @param Request $request
35			* @return bool
36			*/
37			private function requestHasTraps(Request $request): bool
38			{
39			// Execute check if 'duplicate names' trap is enabled
40			if (config('honeypot.traps.duplicate_names.enabled')) {
41			$first = config('honeypot.traps.duplicate_names.name_first_input');
42			$last = config('honeypot.traps.duplicate_names.name_last_input');
43
44			// Determine if the 'first' & 'last' name inputs are the same
45			return ($request->has($first) && $request->has($last))
46			&& $request->input($first) == $request->input($last);
47			}
48
49			// Return false if traps are not enabled
50			return false;
51			}
52			}
53

sfneal / honeypot

Pull Request — master (#17)

HoneyPot::requestHasTraps() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like