Sfneal\Queries\Traits\HasRelationships

Complexity

Total Complexity

3

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	withRelationships()	0	5	1
A	builder()	0	9	2

<?php

namespace Sfneal\Queries\Traits;

// todo: add tests with relationship
use Illuminate\Database\Eloquent\Builder;

trait HasRelationships
{
    /**
     * @var array
     */
    protected $relationships = [];

    /**
     * Scope Plan search results to only plans that are 'public'.
     *
     * @param array $relationships
     * @return $this
     */
    public function withRelationships(array $relationships = []): self
    {
        $this->relationships = $relationships;

        return $this;
    }

    /**
     * Retrieve a Query builder.
     *
     * @return Builder
     */
    abstract protected function newBuilder(): Builder;

    /**
     * Retrieve a Query builder.
     *
     * @return Builder
     */
    protected function builder(): Builder
    {
        $builder = $this->newBuilder();

        if ($this->relationships) {

The expression $this->relationships of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $builder->with($this->relationships);
        }

        return $builder;
    }
}