Sfneal\Helpers\Arrays\ChunkSizer::execute()

Complexity

Conditions	8
Paths	6

Size

Total Lines	38
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function execute(int $array_size, $min = 0, $max = null, $divisor = 2): int
    {
        // If the size of the array is a perfect square, return the square root
        if (gmp_perfect_square($array_size) == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return sqrt($array_size);
        }

        // If min and max are the same return that value
        elseif ($min == $max) {
            return $min;
        }

        $max = (isset($max) ? $max : $array_size);
        $sizes = [];
        while ($divisor < $max) {
            $sizes[$divisor] = [
                // Number of chunks
                'rows'=> floor($array_size / $divisor),

                // Items in each chunk
                'cols' => $divisor,

                // Left over items in last chunk
                'remainder' => $array_size % $divisor,
            ];
            $divisor++;
        }

        // Filter sizes by column values
        return min(array_filter(
            array_column($sizes, 'cols', 'cols'),
            function ($size) use ($min, $max, $sizes) {
                return
                    // Check that the remainder is no more than half of the number of columns
                    ($sizes[$size]['remainder'] == 0 || $sizes[$size]['remainder'] >= $size / 2) &&

                    // Check that the number of columns is greater than or equal than min and less than or equal than max
                    $min <= $size && $size <= $max;
            }