Conditions | 11 |
Total Lines | 51 |
Code Lines | 27 |
Lines | 51 |
Ratio | 100 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like PillowImage.utils.img_adjust() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import os |
||
7 | View Code Duplication | def img_adjust(image, opacity=1.0, rotate=None, fit=0, tempdir=None, bw=False): |
|
|
|||
8 | """ |
||
9 | Reduce the opacity of a PNG image or add rotation. |
||
10 | |||
11 | Inspiration: http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/362879 |
||
12 | |||
13 | :param image: PNG image file |
||
14 | :param opacity: float representing opacity percentage |
||
15 | :param rotate: Degrees to rotate |
||
16 | :param fit: If true, expands the size of the image to fit the whole canvas |
||
17 | :param tempdir: Temporary directory |
||
18 | :param bw: Set image to black and white |
||
19 | :return: Path to modified PNG |
||
20 | """ |
||
21 | # Validate parameters |
||
22 | if opacity: |
||
23 | try: |
||
24 | assert 0 <= opacity <= 1 |
||
25 | except AssertionError: |
||
26 | return image |
||
27 | assert os.path.isfile(image), 'Image is not a file' |
||
28 | |||
29 | # Open image in RGBA mode if not already in RGBA |
||
30 | with Image.open(image) as im: |
||
31 | if im.mode != 'RGBA': |
||
32 | im = im.convert('RGBA') |
||
33 | else: |
||
34 | im = im.copy() |
||
35 | |||
36 | if rotate: |
||
37 | # Rotate the image |
||
38 | if rotate == 90: |
||
39 | im = im.transpose(Image.ROTATE_90) |
||
40 | elif rotate == 180: |
||
41 | im = im.transpose(Image.ROTATE_180) |
||
42 | elif rotate == 270: |
||
43 | im = im.transpose(Image.ROTATE_270) |
||
44 | else: |
||
45 | im = im.rotate(rotate, expand=fit) |
||
46 | |||
47 | # Adjust opacity |
||
48 | alpha = im.split()[3] |
||
49 | alpha = ImageEnhance.Brightness(alpha).enhance(opacity) |
||
50 | im.putalpha(alpha) |
||
51 | if bw: |
||
52 | im.convert('L') |
||
53 | |||
54 | # Save modified image file |
||
55 | with NamedTemporaryFile(suffix='.png', dir=tempdir, delete=False) as dst: |
||
56 | im.save(dst) |
||
57 | return dst.name |
||
58 |