sfelix-martins / json-exception-handler

src/ModelNotFoundHandler.php

<?php

namespace SMartins\JsonHandler;

use Illuminate\Database\Eloquent\ModelNotFoundException;

The type Illuminate\Database\Eloquent\ModelNotFoundException was not found. Maybe you did not declare it correctly or list all dependencies?

trait ModelNotFoundHandler
{
    /**
     * Set the response if Exception is ModelNotFound.
     *
     * @param  ModelNotFoundException $exception
     */
    public function modelNotFoundException(ModelNotFoundException $exception)
    {
        $entity = $this->extractEntityName($exception->getModel());

        $ids = implode($exception->getIds(), ',');

The assignment to $ids is dead and can be removed.

',' of type string is incompatible with the type array expected by parameter $pieces of implode().

        $error = [[
            'status'    => 404,
            'code'      => $this->getCode('model_not_found'),

It seems like getCode() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'source'    => ['pointer' => 'data/id'],
            'title'     => $exception->getMessage(),
            'detail'    => __('exception::exceptions.model_not_found.title', ['model' => $entity]),

The function __ was not found. Maybe you did not declare it correctly or list all dependencies?

        ]];

        $this->jsonApiResponse->setStatus(404);

The property jsonApiResponse does not exist on SMartins\JsonHandler\ModelNotFoundHandler. Did you maybe forget to declare it?

        $this->jsonApiResponse->setErrors($error);
    }

    /**
     * Get entitie name based on model path to mount the message.
     *
     * @param  string $model
     * @return string
     */
    public function extractEntityName($model)
    {
        $classNames = (array) explode('\\', $model);

        $entityName = end($classNames);

        if ($this->entityHasTranslation($entityName)) {
            return __('exception::exceptions.models.'.$entityName);

The function __ was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        return $entityName;
    }

    /**
     * Check if entity returned on ModelNotFoundException has translation on
     * exceptions file
     * @param  string $entityName The model name to check if has translation
     * @return bool               Has translation or not
     */
    public function entityHasTranslation(string $entityName): bool
    {
        $hasKey = in_array($entityName, $this->translationModelKeys());

        if ($hasKey) {
            return ! empty($hasKey);
        }

        return false;
    }

    /**
     * Get the models keys on exceptions lang file
     * @return array An array with keys to translate
     */
    private function translationModelKeys(): array
    {
        return array_keys(__('exception::exceptions.models'));

The function __ was not found. Maybe you did not declare it correctly or list all dependencies?

    }
}