RedisConnectorTest::testConnect() - Code Metrics - Inspection of "Merge pull request #7 from sfcod/redis" - sfcod/jobqueue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 959f68...c6517b )

by Alexey

created 2021-05-23 13:36 UTC

RedisConnectorTest::testConnect() A

↳ Parent: RedisConnectorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace SfCod\QueueBundle\Tests\Connector;

use PHPUnit\Framework\TestCase;
use SfCod\QueueBundle\Base\JobResolverInterface;
use SfCod\QueueBundle\Connector\RedisConnector;
use SfCod\QueueBundle\Queue\RedisQueue;
use SfCod\QueueBundle\Service\RedisDriver;

/**
 * Class RedisConnectorTest
 *
 * @author Virchenko Maksim <[email protected]>
 *
 * @package SfCod\QueueBundle\Tests\Connector
 */
class RedisConnectorTest extends TestCase
{
    /**
     * Test connect
     */
    public function testConnect()
    {
        $jobResolver = $this->createMock(JobResolverInterface::class);
        $mongoDriver = $this->createMock(RedisDriver::class);

        $connector = new RedisConnector($jobResolver, $mongoDriver);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $config = [
            'collection' => uniqid('collection_'),
            'queue' => uniqid('queue_'),
            'expire' => rand(1, 1000),
            'limit' => rand(1, 10),
        ];

        $queue = $connector->connect($config);

        self::assertInstanceOf(RedisQueue::class, $queue);
    }
}


1			<?php
2
3			namespace SfCod\QueueBundle\Tests\Connector;
4
5			use PHPUnit\Framework\TestCase;
6			use SfCod\QueueBundle\Base\JobResolverInterface;
7			use SfCod\QueueBundle\Connector\RedisConnector;
8			use SfCod\QueueBundle\Queue\RedisQueue;
9			use SfCod\QueueBundle\Service\RedisDriver;
10
11			/**
12			* Class RedisConnectorTest
13			*
14			* @author Virchenko Maksim <[email protected]>
15			*
16			* @package SfCod\QueueBundle\Tests\Connector
17			*/
18			class RedisConnectorTest extends TestCase
19			{
20			/**
21			* Test connect
22			*/
23			public function testConnect()
24			{
25			$jobResolver = $this->createMock(JobResolverInterface::class);
26			$mongoDriver = $this->createMock(RedisDriver::class);
27
28			$connector = new RedisConnector($jobResolver, $mongoDriver);
			0 ignored issues – show Documentation introduced 2020-11-06 14:28 UTC by Report Bug Copy Issue Report `$jobResolver` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<SfCod\QueueBundle...e\JobResolverInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-11-06 14:28 UTC by Report Bug Copy Issue Report `$mongoDriver` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<SfCod\QueueBundle\Service\RedisDriver>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29
30			$config = [
31			'collection' => uniqid('collection_'),
32			'queue' => uniqid('queue_'),
33			'expire' => rand(1, 1000),
34			'limit' => rand(1, 10),
35			];
36
37			$queue = $connector->connect($config);
38
39			self::assertInstanceOf(RedisQueue::class, $queue);
40			}
41			}
42

sfcod / jobqueue

Push — master ( 959f68...c6517b )

RedisConnectorTest::testConnect() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like