MongoJobContract - Code Metrics - Inspection of "remove illuminate dependency, apply php 7 syntax,..." - sfcod/jobqueue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

unknown

created 2018-05-18 16:32 UTC

MongoJobContract A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

Metric	Value
wmc	9
lcom	2
cbo	3
dl	0
loc	113
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	delete()	8	2
A	attempts()	4	1
A	reserved()	4	1
A	reservedAt()	4	1
A	getJobId()	4	1
A	getRawBody()	4	1
A	resolve()	4	1

<?php

namespace SfCod\QueueBundle\Job;

use SfCod\QueueBundle\Base\JobInterface;
use SfCod\QueueBundle\Base\JobResolverInterface;
use SfCod\QueueBundle\Queue\QueueInterface;
use stdClass;

/**
 * MongoJob for laravel queue
 *
 * @author Alexey Orlov <[email protected]>
 * @author Virchenko Maksim <[email protected]>
 */
class MongoJobContract extends JobContract implements JobContractInterface
{
    /**
     * Job resolver
     *
     * @var JobResolverInterface
     */
    protected $resolver;

    /**
     * The database queue instance.
     *
     * @var QueueInterface
     */
    protected $database;

    /**
     * The database job payload.
     *
     * @var StdClass
     */
    protected $job;

    /**
     * Create a new job instance.
     *
     * @param JobResolverInterface $resolver
     * @param QueueInterface $database
     * @param StdClass|MongoDB\Model\BSONDocument $job
     * @param string $queue
     */
    public function __construct(JobResolverInterface $resolver, QueueInterface $database, $job, string $queue)
    {
        $this->resolver = $resolver;
        $this->database = $database;
        $this->job = $job;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->queue = $queue;
    }

    /**
     * Delete the job from the queue.
     */
    public function delete()
    {
        parent::delete();

        if ($this->database->deleteReserved($this->queue, (string)$this->getJobId())) {
            $this->deleted = true;
        }
    }

    /**
     * Get the number of times the job has been attempted.
     *
     * @return int
     */
    public function attempts(): int
    {
        return (int)$this->job->attempts;
    }

    /**
     * Check if job reserved
     *
     * @return bool
     */
    public function reserved(): bool
    {
        return (bool)$this->job->reserved;
    }

    /**
     * Get reserved at time
     *
     * @return int
     */
    public function reservedAt(): int
    {
        return (int)$this->job->reserved_at;
    }

    /**
     * Get the job identifier.
     *
     * @return string
     */
    public function getJobId(): string
    {
        return (string)$this->job->_id;
    }

    /**
     * Get the raw body string for the job.
     *
     * @return string
     */
    public function getRawBody(): string
    {
        return $this->job->payload;
    }

    /**
     * Resolve job
     *
     * @param string $class
     *
     * @return JobInterface
     */
    protected function resolve(string $class): JobInterface
    {
        return $this->resolver->resolve($class);
    }
}


1			<?php
2
3			namespace SfCod\QueueBundle\Job;
4
5			use SfCod\QueueBundle\Base\JobInterface;
6			use SfCod\QueueBundle\Base\JobResolverInterface;
7			use SfCod\QueueBundle\Queue\QueueInterface;
8			use stdClass;
9
10			/**
11			* MongoJob for laravel queue
12			*
13			* @author Alexey Orlov <[email protected]>
14			* @author Virchenko Maksim <[email protected]>
15			*/
16			class MongoJobContract extends JobContract implements JobContractInterface
17			{
18			/**
19			* Job resolver
20			*
21			* @var JobResolverInterface
22			*/
23			protected $resolver;
24
25			/**
26			* The database queue instance.
27			*
28			* @var QueueInterface
29			*/
30			protected $database;
31
32			/**
33			* The database job payload.
34			*
35			* @var StdClass
36			*/
37			protected $job;
38
39			/**
40			* Create a new job instance.
41			*
42			* @param JobResolverInterface $resolver
43			* @param QueueInterface $database
44			* @param StdClass\|MongoDB\Model\BSONDocument $job
45			* @param string $queue
46			*/
47			public function __construct(JobResolverInterface $resolver, QueueInterface $database, $job, string $queue)
48			{
49			$this->resolver = $resolver;
50			$this->database = $database;
51			$this->job = $job;
			0 ignored issues – show Documentation Bug introduced 2018-05-18 17:10 UTC by Report Bug Copy Issue Report It seems like `$job` can also be of type `object<SfCod\QueueBundle...oDB\Model\BSONDocument>`. However, the property `$job` is declared as type `object<SfCod\QueueBundle\Job\StdClass>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
52			$this->queue = $queue;
53			}
54
55			/**
56			* Delete the job from the queue.
57			*/
58			public function delete()
59			{
60			parent::delete();
61
62			if ($this->database->deleteReserved($this->queue, (string)$this->getJobId())) {
63			$this->deleted = true;
64			}
65			}
66
67			/**
68			* Get the number of times the job has been attempted.
69			*
70			* @return int
71			*/
72			public function attempts(): int
73			{
74			return (int)$this->job->attempts;
75			}
76
77			/**
78			* Check if job reserved
79			*
80			* @return bool
81			*/
82			public function reserved(): bool
83			{
84			return (bool)$this->job->reserved;
85			}
86
87			/**
88			* Get reserved at time
89			*
90			* @return int
91			*/
92			public function reservedAt(): int
93			{
94			return (int)$this->job->reserved_at;
95			}
96
97			/**
98			* Get the job identifier.
99			*
100			* @return string
101			*/
102			public function getJobId(): string
103			{
104			return (string)$this->job->_id;
105			}
106
107			/**
108			* Get the raw body string for the job.
109			*
110			* @return string
111			*/
112			public function getRawBody(): string
113			{
114			return $this->job->payload;
115			}
116
117			/**
118			* Resolve job
119			*
120			* @param string $class
121			*
122			* @return JobInterface
123			*/
124			protected function resolve(string $class): JobInterface
125			{
126			return $this->resolver->resolve($class);
127			}
128			}
129

sfcod / jobqueue

Pull Request — master (#2)

MongoJobContract A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like