Issues in TwigFileRepository.php (master) - Issues in master - sfcod/email-engine - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Repository/TwigFileRepository.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SfCod\EmailEngineBundle\Repository;

use SfCod\EmailEngineBundle\Exception\RepositoryUnavailableException;
use SfCod\EmailEngineBundle\Template\TemplateInterface;
use SfCod\EmailEngineBundle\Template\TwigTemplateAwareInterface;
use Twig_Environment;

/**
 * Class TwigFileRepository
 *
 * @author Virchenko Maksim <[email protected]>
 *
 * @package SfCod\EmailEngineBundle\Repository
 */
class TwigFileRepository implements RepositoryInterface
{
    /**
     * Twig template
     *
     * @var string
     */
    protected $template;

    /**
     * @var Twig_Environment
     */
    protected $twig;

    /**
     * TwigFileRepository constructor.
     *
     * @param Twig_Environment $twig
     */
    public function __construct(Twig_Environment $twig)
    {
        $this->twig = $twig;
    }

    /**
     * Get subject template
     *
     * @param array $data
     *
     * @return string
     *
     * @throws \Throwable
     */
    public function getSubjectTemplate(array $data): string
    {
        return $this->renderBlock('subject', $data);
    }

    /**
     * Get body template
     *
     * @param array $data
     *
     * @return string
     *
     * @throws \Throwable
     */
    public function getBodyTemplate(array $data): string
    {
        return $this->renderBlock('content', $data);
    }

    /**
     * Get sender name template
     *
     * @param array $data
     *
     * @return string
     *
     * @throws \Throwable
     */
    public function getSenderNameTemplate(array $data): string
    {
        if ($this->template->hasBlock('sender_name')) {

            return $this->renderBlock('sender_name', $data);
        }

        return getenv('SENDER_NAME');
    }

    /**
     * Get sender email template
     *
     * @param array $data
     *
     * @return string
     *
     * @throws \Throwable
     */
    public function getSenderEmailTemplate(array $data): string
    {
        if ($this->template->hasBlock('sender_email')) {

            return $this->renderBlock('sender_email', $data);
        }

        return getenv('SENDER_EMAIL');
    }

    /**
     * Render twig template
     *
     * @param string $block
     * @param array $data
     *
     * @return string
     *
     * @throws \Throwable
     */
    protected function renderBlock(string $block, array $data): string
    {
        try {
            return $this->template->renderBlock($block, $data);

        } catch (\Throwable $e) {
            throw new RepositoryUnavailableException($e->getMessage());
        }
    }

    /**
     * Repository initialize
     *
     * @param TemplateInterface $template
     * @param array $arguments
     *
     * @throws RepositoryUnavailableException
     */
    public function connect(TemplateInterface $template, array $arguments = [])
    {
        if (false === $template instanceof TwigTemplateAwareInterface) {
            throw new RepositoryUnavailableException('Template should implement TwigTemplateAwareInterface to work with TwigFileRepository.');
        }

        try {
            if (file_exists($template->getTwigTemplate())) {
                $directory = dirname($template->getTwigTemplate());

                $this->twig->setLoader(new \Twig_Loader_Chain([
                    $this->twig->getLoader(),
                    new \Twig_Loader_Filesystem(basename($directory), dirname($directory)),
                ]));

                $templateName = basename($template->getTwigTemplate());
            } else {
                $templateName = $template->getTwigTemplate();
            }

            $this->twig->setCache(false);

            $this->template = $this->twig->load($templateName);
        } catch (\Throwable $e) {
            throw new RepositoryUnavailableException($e->getMessage());
        }
    }
}


1			<?php
2
3			namespace SfCod\EmailEngineBundle\Repository;
4
5			use SfCod\EmailEngineBundle\Exception\RepositoryUnavailableException;
6			use SfCod\EmailEngineBundle\Template\TemplateInterface;
7			use SfCod\EmailEngineBundle\Template\TwigTemplateAwareInterface;
8			use Twig_Environment;
9
10			/**
11			* Class TwigFileRepository
12			*
13			* @author Virchenko Maksim <[email protected]>
14			*
15			* @package SfCod\EmailEngineBundle\Repository
16			*/
17			class TwigFileRepository implements RepositoryInterface
18			{
19			/**
20			* Twig template
21			*
22			* @var string
23			*/
24			protected $template;
25
26			/**
27			* @var Twig_Environment
28			*/
29			protected $twig;
30
31			/**
32			* TwigFileRepository constructor.
33			*
34			* @param Twig_Environment $twig
35			*/
36			public function __construct(Twig_Environment $twig)
37			{
38			$this->twig = $twig;
39			}
40
41			/**
42			* Get subject template
43			*
44			* @param array $data
45			*
46			* @return string
47			*
48			* @throws \Throwable
49			*/
50			public function getSubjectTemplate(array $data): string
51			{
52			return $this->renderBlock('subject', $data);
53			}
54
55			/**
56			* Get body template
57			*
58			* @param array $data
59			*
60			* @return string
61			*
62			* @throws \Throwable
63			*/
64			public function getBodyTemplate(array $data): string
65			{
66			return $this->renderBlock('content', $data);
67			}
68
69			/**
70			* Get sender name template
71			*
72			* @param array $data
73			*
74			* @return string
75			*
76			* @throws \Throwable
77			*/
78			public function getSenderNameTemplate(array $data): string
79			{
80			if ($this->template->hasBlock('sender_name')) {
			0 ignored issues – show Bug introduced 2018-02-21 21:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `hasBlock` cannot be called on `$this->template` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
81			return $this->renderBlock('sender_name', $data);
82			}
83
84			return getenv('SENDER_NAME');
85			}
86
87			/**
88			* Get sender email template
89			*
90			* @param array $data
91			*
92			* @return string
93			*
94			* @throws \Throwable
95			*/
96			public function getSenderEmailTemplate(array $data): string
97			{
98			if ($this->template->hasBlock('sender_email')) {
			0 ignored issues – show Bug introduced 2018-02-21 21:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `hasBlock` cannot be called on `$this->template` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
99			return $this->renderBlock('sender_email', $data);
100			}
101
102			return getenv('SENDER_EMAIL');
103			}
104
105			/**
106			* Render twig template
107			*
108			* @param string $block
109			* @param array $data
110			*
111			* @return string
112			*
113			* @throws \Throwable
114			*/
115			protected function renderBlock(string $block, array $data): string
116			{
117			try {
118			return $this->template->renderBlock($block, $data);
			0 ignored issues – show Bug introduced 2018-02-21 21:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `renderBlock` cannot be called on `$this->template` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
119			} catch (\Throwable $e) {
120			throw new RepositoryUnavailableException($e->getMessage());
121			}
122			}
123
124			/**
125			* Repository initialize
126			*
127			* @param TemplateInterface $template
128			* @param array $arguments
129			*
130			* @throws RepositoryUnavailableException
131			*/
132			public function connect(TemplateInterface $template, array $arguments = [])
133			{
134			if (false === $template instanceof TwigTemplateAwareInterface) {
135			throw new RepositoryUnavailableException('Template should implement TwigTemplateAwareInterface to work with TwigFileRepository.');
136			}
137
138			try {
139			if (file_exists($template->getTwigTemplate())) {
140			$directory = dirname($template->getTwigTemplate());
141
142			$this->twig->setLoader(new \Twig_Loader_Chain([
143			$this->twig->getLoader(),
144			new \Twig_Loader_Filesystem(basename($directory), dirname($directory)),
145			]));
146
147			$templateName = basename($template->getTwigTemplate());
148			} else {
149			$templateName = $template->getTwigTemplate();
150			}
151
152			$this->twig->setCache(false);
153
154			$this->template = $this->twig->load($templateName);
155			} catch (\Throwable $e) {
156			throw new RepositoryUnavailableException($e->getMessage());
157			}
158			}
159			}
160

sfcod / email-engine

Issues (14)

Security Analysis no request data

Repository/TwigFileRepository.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like