SfCod\EmailEngineBundle\Mailer\Mailer

Complexity

Total Complexity

11

Size/Duplication

Total Lines	127
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getSenders()	0	4	1
A	setSenders()	0	4	1
B	send()	0	34	5
A	makeSender()	0	11	2
A	makeRepository()	0	8	1

<?php

namespace SfCod\EmailEngineBundle\Mailer;

use Psr\Log\LoggerInterface;
use SfCod\EmailEngineBundle\Exception\RepositoryUnavailableException;
use SfCod\EmailEngineBundle\Repository\RepositoryInterface;
use SfCod\EmailEngineBundle\Sender\MessageOptionsInterface;
use SfCod\EmailEngineBundle\Sender\SenderInterface;
use SfCod\EmailEngineBundle\Template\ParametersAwareInterface;
use SfCod\EmailEngineBundle\Template\Params\ParameterResolverInterface;
use SfCod\EmailEngineBundle\Template\RepositoryAwareInterface;
use SfCod\EmailEngineBundle\Template\TemplateInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Class Mailer
 *
 * @author Virchenko Maksim <muslim1992@gmail.com>
 *
 * @package SfCod\EmailEngineBundle\Sender
 */
class Mailer
{
    /**
     * Senders for email sending
     *
     * @var SenderInterface[]
     */
    private $senders = [];

    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * EmailSender constructor.
     *
     * @param ContainerInterface $container
     * @param LoggerInterface $logger

There is no parameter named $logger. Was it maybe removed?

     */
    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
    }

    /**
     * Get senders
     *
     * @return array
     */
    public function getSenders(): array
    {
        return $this->senders;
    }

    /**
     * Set senders
     *
     * @param array $senders
     */
    public function setSenders(array $senders): void
    {
        $this->senders = $senders;
    }

    /**
     * Send email template
     *
     * @param TemplateInterface $template
     * @param array|string $emails
     * @param null|MessageOptionsInterface $options
     *
     * @return int
     */
    public function send(TemplateInterface $template, $emails, ?MessageOptionsInterface $options = null): int
    {
        $sentCount = 0;

        foreach ($this->senders as $config) {
//            try {
            $concreteTemplate = clone $template;
            $sender = array_merge($config['sender'], ['options' => $options]);
            $concreteSender = $this->makeSender($sender['class'], $sender['options'] ?? []);

$sender['class'] is of type null|object<SfCod\EmailEngineBundle\Sender\MessageOptionsInterface>, but the function expects a string.

It seems like $sender['options'] ?? array() can also be of type object<SfCod\EmailEngineBundle\Sender\MessageOptionsInterface>; however, SfCod\EmailEngineBundle\Mailer\Mailer::makeSender() does only seem to accept array, maybe add an additional type check?

            if ($concreteTemplate instanceof RepositoryAwareInterface) {
                $concreteTemplate->setRepository($this->makeRepository($config['repository']['class'], $concreteTemplate, $config['repository']['arguments']));
            }

            if ($concreteTemplate instanceof ParametersAwareInterface) {
                $concreteTemplate->setParameterResolver($this->container->get(ParameterResolverInterface::class));
            }

            if ($concreteSender->send($concreteTemplate, $emails)) {
                ++$sentCount;

                break;
            }
//            } catch (RepositoryUnavailableException $e) {
//                if ($this->container->get('kernel')->isDebug()) {
//                    $this->container->get(LoggerInterface::class)->error($e->getMessage(), ['exception' => $e]);
//                }
//
//                // Try next sender
//            }
        }

        return $sentCount;
    }

    /**
     * Make email engine sender
     *
     * @param string $sender
     * @param array $options
     *
     * @return SenderInterface
     */
    protected function makeSender(string $sender, array $options = []): SenderInterface
    {
        /** @var SenderInterface $sender */
        $sender = $this->container->get($sender);

$sender is of type object<SfCod\EmailEngineBundle\Sender\SenderInterface>, but the function expects a string.

        if (false === empty($options)) {
            $sender->setOptions($options);

$options is of type array, but the function expects a object<SfCod\EmailEngineBundle\Sender\MessageOptionsInterface>.

        }

        return $sender;
    }

    /**
     * Make email engine repository
     *
     * @param string $repository
     * @param TemplateInterface $template
     * @param array $arguments
     *
     * @return RepositoryInterface
     */
    protected function makeRepository(string $repository, TemplateInterface $template, array $arguments = []): RepositoryInterface
    {
        /** @var RepositoryInterface $repository */
        $repository = $this->container->get($repository);

$repository is of type object<SfCod\EmailEngineBundle\Repository\RepositoryInterface>, but the function expects a string.

        $repository->connect($template, $arguments);

        return $repository;
    }
}