Checkbox - Code Metrics - Inspection of "fix short tags" - sevikerr/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3cc3b2...768def )

by Vitaliy

created 2017-01-06 07:56 UTC

Checkbox A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	11
c	1
b	0
f	0
lcom	2
cbo	2
dl	0
loc	98
ccs	26
cts	26
cp	1
rs	10

7 Methods

Rating	Name	Size	Complexity
A	handle()	6	2
A	setValue()	12	4
A	check()	5	1
A	unCheck()	5	1
A	isChecked()	3	1
A	setLabel()	4	1
A	render()	3	1

<?php

  namespace Fiv\Form\Element;

  use Fiv\Form\Element;
  use Fiv\Form\FormData;

  /**
   * Generate <input type="submit" /> element
   *
   * @author Ivan Shcherbak <[email protected]>
   */
  class Checkbox extends Element\Input {

    /**
     * @var int
     */
    protected $value = 0;

    /**
     * @var string
     */
    protected $label = '';

    /**
     * @var array
     */
    protected $attributes = [
      'type' => 'checkbox',
    ];


    /**
     * @inheritdoc
     */
    public function handle(FormData $data) {
      $value = $data->get($this->getName());
      $value = ($value === null) ? 0 : (int) $value;
      $this->setValue($value);
      return $this;
    }


    /**
     * Value in checkbox can be true or false
     *
     * @param int $value
     * @return $this
     */
    public function setValue($value) {
      if ($value !== 1 and $value !== 0) {
        throw new \InvalidArgumentException('Expect int: 1 or 0');
      }

      if ($value === 1) {
        return $this->check();
      } else {
        return $this->unCheck();
      }

    }


    /**
     * @return $this
     */
    public function check() {
      $this->setAttribute('checked', 'checked');
      parent::setValue(1);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
      return $this;
    }


    /**
     * Set value to 0
     * @return $this
     */
    public function unCheck() {
      $this->removeAttribute('checked');
      parent::setValue(0);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
      return $this;
    }


    /**
     * @return bool
     */
    public function isChecked() {
      return $this->getValue() === 1;
    }


    /**
     * @param string $text
     * @return $this
     */
    public function setLabel($text) {
      $this->label = $text;
      return $this;
    }


    /**
     * @return string
     */
    public function render() {
      return '<label>' . parent::render() . $this->label . '</label>';
    }

  }

1		<?php
2
3		namespace Fiv\Form\Element;
4
5		use Fiv\Form\Element;
6		use Fiv\Form\FormData;
7
8		/**
9		* Generate <input type="submit" /> element
10		*
11		* @author Ivan Shcherbak <[email protected]>
12		*/
13		class Checkbox extends Element\Input {
14
15		/**
16		* @var int
17		*/
18		protected $value = 0;
19
20		/**
21		* @var string
22		*/
23		protected $label = '';
24
25		/**
26		* @var array
27		*/
28		protected $attributes = [
29		'type' => 'checkbox',
30		];
31
32
33		/**
34		* @inheritdoc
35		*/
36	7	public function handle(FormData $data) {
37	7	$value = $data->get($this->getName());
38	7	$value = ($value === null) ? 0 : (int) $value;
39	7	$this->setValue($value);
40	7	return $this;
41		}
42
43
44		/**
45		* Value in checkbox can be true or false
46		*
47		* @param int $value
48		* @return $this
49		*/
50	8	public function setValue($value) {
51	8	if ($value !== 1 and $value !== 0) {
52	1	throw new \InvalidArgumentException('Expect int: 1 or 0');
53		}
54
55	7	if ($value === 1) {
56	5	return $this->check();
57		} else {
58	5	return $this->unCheck();
59		}
60
61		}
62
63
64		/**
65		* @return $this
66		*/
67	5	public function check() {
68	5	$this->setAttribute('checked', 'checked');
69	5	parent::setValue(1);
		0 ignored issues – show Comprehensibility Bug introduced 2016-03-25 12:37 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setValue()` instead of `check()`). Are you sure this is correct? If so, you might want to change this to `$this->setValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
70	5	return $this;
71		}
72
73
74		/**
75		* Set value to 0
76		* @return $this
77		*/
78	7	public function unCheck() {
79	7	$this->removeAttribute('checked');
80	7	parent::setValue(0);
		0 ignored issues – show Comprehensibility Bug introduced 2016-03-25 12:37 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setValue()` instead of `unCheck()`). Are you sure this is correct? If so, you might want to change this to `$this->setValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
81	7	return $this;
82		}
83
84
85		/**
86		* @return bool
87		*/
88	4	public function isChecked() {
89	4	return $this->getValue() === 1;
90		}
91
92
93		/**
94		* @param string $text
95		* @return $this
96		*/
97	6	public function setLabel($text) {
98	6	$this->label = $text;
99	6	return $this;
100		}
101
102
103		/**
104		* @return string
105		*/
106	1	public function render() {
107	1	return '<label>' . parent::render() . $this->label . '</label>';
108		}
109
110		}

sevikerr / form

Push — master ( 3cc3b2...768def )

Checkbox A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like