AdminCanResetPassword - Code Metrics - Inspection of "Fix reset password" - serverfireteam/panel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#327)

unknown

created 2017-02-01 22:06 UTC

AdminCanResetPassword A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	0
cbo	1
dl	0
loc	23
rs	10
c	1
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getEmailForPasswordReset()	0	4	1
A	sendPasswordResetNotification()	0	4	1

<?php

namespace Serverfireteam\Panel;


trait AdminCanResetPassword
{
    /**
     * Get the e-mail address where password reset links are sent.
     *
     * @return string
     */
    public function getEmailForPasswordReset()
    {
        return $this->email;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Send the password reset notification.
     *
     * @param  string  $token
     * @return void
     */
    public function sendPasswordResetNotification($token)
    {
        $this->notify(new AdminResetPassword($token));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Serverfireteam\Panel;
4
5
6			trait AdminCanResetPassword
7			{
8			/**
9			* Get the e-mail address where password reset links are sent.
10			*
11			* @return string
12			*/
13			public function getEmailForPasswordReset()
14			{
15			return $this->email;
			0 ignored issues – show Bug introduced 2017-02-01 22:13 UTC by Report Bug Copy Issue Report The property `email` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			}
17
18			/**
19			* Send the password reset notification.
20			*
21			* @param string $token
22			* @return void
23			*/
24			public function sendPasswordResetNotification($token)
25			{
26			$this->notify(new AdminResetPassword($token));
			0 ignored issues – show Bug introduced 2017-02-01 22:13 UTC by Report Bug Copy Issue Report It seems like `notify()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28			}
29

serverfireteam / panel

GitHub Access Token became invalid

Pull Request — master (#327)

AdminCanResetPassword A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like