UsersController::postCreateUser() - Code Metrics - serverfireteam/panel - Measure and Improve Code Quality continuously with Scrutinizer

UsersController::postCreateUser() A
last analyzed 2020-03-04 14:41 UTC

↳ Parent: UsersController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
namespace Serverfireteam\Panel;

use Illuminate\Routing\Controller;
/* 
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */

class UsersController extends Controller{
    
    
    public  function all($entity){
        
        parent::all($entity);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
       
        $this->filter = \DataFilter::source(new \User());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->filter->add('id', 'ID', 'text');
        $this->filter->add('name', 'Name', 'text');
        $this->filter->submit('search');
        $this->filter->reset('reset');
        $this->filter->build();
                
        $this->grid = \DataGrid::source($this->filter);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->grid->add('id','ID', true)->style("width:100px");
        $this->grid->add('name','Name');
        $this->addStylesToGrid();           
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                       
        return $this->returnView();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
           
    
    
    
    public function edit($entity){
                
        parent::edit($entity);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
              
        $this->edit = \DataEdit::source(new \User());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        
        $this->edit->label('Edit User');
        $this->edit->link("rapyd-demo/filter","Articles", "TR")->back();
        $this->edit->add('name','Name', 'text')->rule('required|min:5');
        $this->edit->add('username','userame', 'text')->rule('required|min:5');
        return $this->returnEditView();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
   
    public function getCreateUser(){
        return \View::make('panelViews::createUser');
    }

    public function postCreateUser(){
        
    }
}

1			<?php
2			namespace Serverfireteam\Panel;
3
4			use Illuminate\Routing\Controller;
5			/*
6			* To change this license header, choose License Headers in Project Properties.
7			* To change this template file, choose Tools \| Templates
8			* and open the template in the editor.
9			*/
10
11			class UsersController extends Controller{
12
13
14			public function all($entity){
15
16			parent::all($entity);
			0 ignored issues – show Bug introduced 2016-02-18 09:57 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Illuminate\Routing\Controller` as the method `all()` does only exist in the following sub-classes of `Illuminate\Routing\Controller`: `Serverfireteam\Panel\AdminController`, `Serverfireteam\Panel\CrudController`, `Serverfireteam\Panel\LinkController`, `Serverfireteam\Panel\PermissionController`, `Serverfireteam\Panel\RoleController`, `Serverfireteam\Panel\UsersController`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
17
18			$this->filter = \DataFilter::source(new \User());
			0 ignored issues – show Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The property `filter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			$this->filter->add('id', 'ID', 'text');
20			$this->filter->add('name', 'Name', 'text');
21			$this->filter->submit('search');
22			$this->filter->reset('reset');
23			$this->filter->build();
24
25			$this->grid = \DataGrid::source($this->filter);
			0 ignored issues – show Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The property `grid` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$this->grid->add('id','ID', true)->style("width:100px");
27			$this->grid->add('name','Name');
28			$this->addStylesToGrid();
			0 ignored issues – show Documentation Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The method `addStylesToGrid` does not exist on `object<Serverfireteam\Panel\UsersController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
29
30			return $this->returnView();
			0 ignored issues – show Documentation Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The method `returnView` does not exist on `object<Serverfireteam\Panel\UsersController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
31			}
32
33
34
35
36			public function edit($entity){
37
38			parent::edit($entity);
			0 ignored issues – show Bug introduced 2016-02-18 09:57 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Illuminate\Routing\Controller` as the method `edit()` does only exist in the following sub-classes of `Illuminate\Routing\Controller`: `Serverfireteam\Panel\AdminController`, `Serverfireteam\Panel\CrudController`, `Serverfireteam\Panel\LinkController`, `Serverfireteam\Panel\PermissionController`, `Serverfireteam\Panel\RoleController`, `Serverfireteam\Panel\UsersController`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
39
40			$this->edit = \DataEdit::source(new \User());
			0 ignored issues – show Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The property `edit` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41
42			$this->edit->label('Edit User');
43			$this->edit->link("rapyd-demo/filter","Articles", "TR")->back();
44			$this->edit->add('name','Name', 'text')->rule('required\|min:5');
45			$this->edit->add('username','userame', 'text')->rule('required\|min:5');
46			return $this->returnEditView();
			0 ignored issues – show Documentation Bug introduced 2016-01-25 15:46 UTC by Report Bug Copy Issue Report The method `returnEditView` does not exist on `object<Serverfireteam\Panel\UsersController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
47			}
48
49			public function getCreateUser(){
50			return \View::make('panelViews::createUser');
51			}
52
53			public function postCreateUser(){
54
55			}
56			}

serverfireteam / panel

GitHub Access Token became invalid

UsersController::postCreateUser() A last analyzed 2020-03-04 14:41 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

UsersController::postCreateUser() A
last analyzed 2020-03-04 14:41 UTC