sergisergio /
Ads
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 107 |
| Code Lines | 102 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 11 | public function load(ObjectManager $manager) |
||
| 12 | { |
||
| 13 | $names = [ |
||
| 14 | [ 'department' => '01 Ain'], |
||
| 15 | [ 'department' => '02 Aisne'], |
||
| 16 | [ 'department' => '03 Allier'], |
||
| 17 | [ 'department' => '04 Alpes-de-Haute-Provence'], |
||
| 18 | [ 'department' => '05 Hautes-Alpes'], |
||
| 19 | [ 'department' => '06 Alpes-Maritimes'], |
||
| 20 | [ 'department' => '07 Ardèche'], |
||
| 21 | [ 'department' => '08 Ardennes'], |
||
| 22 | [ 'department' => '09 Ariège'], |
||
| 23 | [ 'department' => '10 Aube'], |
||
| 24 | [ 'department' => '11 Aude'], |
||
| 25 | [ 'department' => '12 Aveyron'], |
||
| 26 | [ 'department' => '13 Bouches-du-Rhône'], |
||
| 27 | [ 'department' => '14 Calvados'], |
||
| 28 | [ 'department' => '15 Cantal'], |
||
| 29 | [ 'department' => '16 Charente'], |
||
| 30 | [ 'department' => '17 Charente-Maritime'], |
||
| 31 | [ 'department' => '18 Cher'], |
||
| 32 | [ 'department' => '19 Corrèze'], |
||
| 33 | [ 'department' => '2A Corse-du-Sud'], |
||
| 34 | [ 'department' => '2B Haute-Corse'], |
||
| 35 | [ 'department' => '21 Côte-d\'Or'], |
||
| 36 | [ 'department' => '22 Côtes d\'Armor'], |
||
| 37 | [ 'department' => '23 Creuse'], |
||
| 38 | [ 'department' => '24 Dordogne'], |
||
| 39 | [ 'department' => '25 Doubs'], |
||
| 40 | [ 'department' => '26 Drome'], |
||
| 41 | [ 'department' => '27 Eure'], |
||
| 42 | [ 'department' => '28 Eure-et-Loir'], |
||
| 43 | [ 'department' => '29 Finistère'], |
||
| 44 | [ 'department' => '30 Gard'], |
||
| 45 | [ 'department' => '31 Haute-Garonne'], |
||
| 46 | [ 'department' => '32 Gers'], |
||
| 47 | [ 'department' => '33 Gironde'], |
||
| 48 | [ 'department' => '34 Hérault'], |
||
| 49 | [ 'department' => '35 Ille-et-Vilaine'], |
||
| 50 | [ 'department' => '36 Indre'], |
||
| 51 | [ 'department' => '37 Indre-et-Loire'], |
||
| 52 | [ 'department' => '38 Isère'], |
||
| 53 | [ 'department' => '39 Jura'], |
||
| 54 | [ 'department' => '40 Landes'], |
||
| 55 | [ 'department' => '41 Loir-et-Cher'], |
||
| 56 | [ 'department' => '42 Loire'], |
||
| 57 | [ 'department' => '43 Haute-Loire'], |
||
| 58 | [ 'department' => '44 Loire-Atlantique'], |
||
| 59 | [ 'department' => '45 Loiret'], |
||
| 60 | [ 'department' => '46 Lot'], |
||
| 61 | [ 'department' => '47 Lot-et-Garonne'], |
||
| 62 | [ 'department' => '48 Lozère'], |
||
| 63 | [ 'department' => '49 Maine-et-Loire'], |
||
| 64 | [ 'department' => '50 Manche'], |
||
| 65 | [ 'department' => '51 Marne'], |
||
| 66 | [ 'department' => '52 Haute-Marne'], |
||
| 67 | [ 'department' => '53 Mayenne'], |
||
| 68 | [ 'department' => '54 Meurthe-et-Moselle'], |
||
| 69 | [ 'department' => '55 Meuse'], |
||
| 70 | [ 'department' => '56 Morbihan'], |
||
| 71 | [ 'department' => '57 Moselle'], |
||
| 72 | [ 'department' => '58 Nièvre'], |
||
| 73 | [ 'department' => '59 Nord'], |
||
| 74 | [ 'department' => '60 Oise'], |
||
| 75 | [ 'department' => '61 Orne'], |
||
| 76 | [ 'department' => '62 Pas-de-Calais'], |
||
| 77 | [ 'department' => '63 Puy-de-Dôme'], |
||
| 78 | [ 'department' => '64 Pyrénées-Atlantiques'], |
||
| 79 | [ 'department' => '65 Hautes-Pyrénées'], |
||
| 80 | [ 'department' => '66 Pyrénées-Orientales'], |
||
| 81 | [ 'department' => '67 Bas-Rhin'], |
||
| 82 | [ 'department' => '68 Haut-Rhin'], |
||
| 83 | [ 'department' => '69 Rhône'], |
||
| 84 | [ 'department' => '70 Haute-Saône'], |
||
| 85 | [ 'department' => '71 Saône-et-Loire'], |
||
| 86 | [ 'department' => '72 Sarthe'], |
||
| 87 | [ 'department' => '73 Savoie'], |
||
| 88 | [ 'department' => '74 Haute-Savoie'], |
||
| 89 | [ 'department' => '75 Paris'], |
||
| 90 | [ 'department' => '76 Seine-Maritime'], |
||
| 91 | [ 'department' => '77 Seine-et-Marne'], |
||
| 92 | [ 'department' => '78 Yvelines'], |
||
| 93 | [ 'department' => '79 Deux-Sèvres'], |
||
| 94 | [ 'department' => '80 Somme'], |
||
| 95 | [ 'department' => '81 Tarn'], |
||
| 96 | [ 'department' => '82 Tarn-et-Garonne'], |
||
| 97 | [ 'department' => '83 Var'], |
||
| 98 | [ 'department' => '84 Vaucluse'], |
||
| 99 | [ 'department' => '85 Vendée'], |
||
| 100 | [ 'department' => '86 Vienne'], |
||
| 101 | [ 'department' => '87 Haute-Vienne'], |
||
| 102 | [ 'department' => '88 Vosges'], |
||
| 103 | [ 'department' => '89 Yonne'], |
||
| 104 | [ 'department' => '90 Territoire de Belfort'], |
||
| 105 | [ 'department' => '91 Essonne'], |
||
| 106 | [ 'department' => '92 Hauts-de-Seine'], |
||
| 107 | [ 'department' => '93 Seine-St-Denis'], |
||
| 108 | [ 'department' => '94 Val-de-Marne'], |
||
| 109 | [ 'department' => '95 Val-D\'Oise'] |
||
| 110 | ]; |
||
| 111 | |||
| 112 | foreach ($names as $name) { |
||
| 113 | $department = new Department(); |
||
| 114 | $department->setName($name['department']); |
||
| 115 | |||
| 116 | $manager->persist($department); |
||
| 117 | $manager->flush(); |
||
| 118 | } |
||
| 122 |
