App\Http\Controllers\TaskController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	138
Duplicated Lines	3.62 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes	7
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	16	1
A	create()	0	4	1
A	store()	5	12	4
A	show()	0	19	2
A	edit()	0	4	1
A	update()	0	5	1
A	destroy()	0	4	1
A	saveTask()	0	7	1

<?php

namespace App\Http\Controllers;

use App\Task;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Response;
use App\Transformers\TaskTransformer;


class TaskController extends Controller
{
    /**
     * TaskController constructor.
     */
    public function __construct(TaskTransformer $taskTransformer)
    {
        $this->TaskTransformer = $taskTransformer;

The property TaskTransformer does not exist. Did you maybe forget to declare it?

        //$this->middleware('auth.basic', ['only' => 'store']);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->middleware('auth:api');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {

      $tasks = Task::all();
//
//
  //$task = Task::all();

58% of this comment could be valid code. Did you maybe forget this after debugging?

//        return $this->respond([
//            'data' => $this->TaskTransformer->transformCollection($task->all())
//        ]);

        return Response::json(
            $this->TaskTransformer->transformCollection($tasks),
            200
        );
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store()
    {

        if (! Input::get('name') or ! Input::get('done') or ! Input::get('priority'))

Using logical operators such as or instead of || is generally not recommended.

This code seems to be duplicated across your project.

        {
            return $this->setStatusCode(IlluminateResponse::HTTP_UNPROCESSABLE_ENTITY)

The method setStatusCode does not exist on object<App\Http\Controllers\TaskController>? Since you implemented __call, maybe consider adding a @method annotation.

                ->respondWithError('Parameters failed validation for a task.');
        }
        Task::create(Input::all());
        return $this->respondCreated('Task successfully created.');

The method respondCreated() does not exist on App\Http\Controllers\TaskController. Did you maybe mean create()?

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {

        $task = Task::find($id);
       // $task = Task::where('id',$id)->first();

62% of this comment could be valid code. Did you maybe forget this after debugging?

        if (! $task){
            return Response::json([

                'error' => [
                    'message' => 'La tasca no existeix',
                    'code'
                ]
            ], 404);
        }
        return Response::json([
             $this->taskTransfomer->transform($task)

The property taskTransfomer does not exist. Did you maybe forget to declare it?

        ], 200);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $task =  Task::findorFail($id);
        $this->saveTask($request, $task);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Task::destroy($id);
    }

    /**
     * @param Request $request
     * @param $task
     */
    public function saveTask(Request $request, $task)
    {
        $task->name = $request->name;

The property name does not seem to exist in Illuminate\Http\Request.

        $task->priority = $request->priority;

The property priority does not seem to exist in Illuminate\Http\Request.

        $task->done = $request->done;

The property done does not seem to exist in Illuminate\Http\Request.

        $task->save();
    }


}