App\Http\Controllers\TagController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	129
Duplicated Lines	3.88 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	9	1
A	create()	0	4	1
A	show()	0	19	2
A	edit()	0	4	1
A	update()	0	5	1
A	destroy()	0	4	1
A	saveTag()	0	7	1
A	store()	5	12	4

<?php

namespace App\Http\Controllers;

use App\Tag;
use App\Transformers\TagTransformer;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Response;
use Symfony\Component\Console\Input\Input;

class TagController extends Controller
{
    /**
     * TaskController constructor.
     */
    public function __construct(TagTransformer $tagTransformer)
    {
        $this->tagTransformer = $tagTransformer;

The property tagTransformer does not exist. Did you maybe forget to declare it?

        $this->middleware('auth.basic', ['only' => 'store']);
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index($tagId = null)
    {

        //$tags = Tag::all();

50% of this comment could be valid code. Did you maybe forget this after debugging?

        $tag = $this->getTags($tagId);

The method getTags does not exist on object<App\Http\Controllers\TagController>? Since you implemented __call, maybe consider adding a @method annotation.

        return $this->respond($this->tagTransformer->transformCollection($tag->all()));

The method respond does not exist on object<App\Http\Controllers\TagController>? Since you implemented __call, maybe consider adding a @method annotation.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store()
    {

        if (! Input::get('name') or ! Input::get('done') or ! Input::get('priority'))

The method get() does not seem to exist on object<Symfony\Component\Console\Input\Input>.

Using logical operators such as or instead of || is generally not recommended.

This code seems to be duplicated across your project.

        {
            return $this->setStatusCode(IlluminateResponse::HTTP_UNPROCESSABLE_ENTITY)

The method setStatusCode does not exist on object<App\Http\Controllers\TagController>? Since you implemented __call, maybe consider adding a @method annotation.

                ->respondWithError('Parameters failed validation for a tag.');
        }
        Tag::create(Input::all());

The method all() does not seem to exist on object<Symfony\Component\Console\Input\Input>.

        return $this->respondCreated('Tag successfully created.');

The method respondCreated() does not exist on App\Http\Controllers\TagController. Did you maybe mean create()?

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {

        $tag = Tag::find($id);
        // $task = Task::where('id',$id)->first();

62% of this comment could be valid code. Did you maybe forget this after debugging?

        if (! $tag){
            return Response::json([

                'error' => [
                    'message' => 'La tag no existeix',
                    'code'
                ]
            ], 404);
        }
        return Response::json([
            $this->tagTransfomer->transform($tag)

The property tagTransfomer does not seem to exist. Did you mean tagTransformer?

        ], 200);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $tag =  Tag::findorFail($id);
        $this->saveTag($request, $tag);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Tag::destroy($id);
    }

    /**
     * @param Request $request
     * @param $tag
     */
    public function saveTag(Request $request, $tag)
    {
        $tag->name = $request->name;

The property name does not seem to exist in Illuminate\Http\Request.

        $tag->priority = $request->priority;

The property priority does not seem to exist in Illuminate\Http\Request.

        $tag->done = $request->done;

The property done does not seem to exist in Illuminate\Http\Request.

        $tag->save();
    }

}