seregazhuk\SmsIntel\Api\Requests\AbstractRequest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	123
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setCredentials()	0	7	1
A	exec()	0	18	3
A	createRequestBody()	0	14	1
A	makeOptions()	0	11	4
	formatRequestBody()	0	1	?
	parseResponse()	0	1	?
	makeEndPoint()	0	1	?

<?php

namespace seregazhuk\SmsIntel\Api\Requests;

use GuzzleHttp\ClientInterface;
use seregazhuk\SmsIntel\Exceptions\BaseSmsIntelException;

abstract class AbstractRequest
{
    /**
     * @var array
     */
    public static $allowedMethod = [];

    /**
     * @var ClientInterface
     */
    protected $guzzle;

    /**
     * @var string
     */
    protected $login;

    /**
     * @var string
     */
    protected $password;

    public function __construct(ClientInterface $client)
    {
        $this->guzzle = $client;
    }


    /**
     * @param string $login
     * @param string $password
     * @return $this
     */
    public function setCredentials($login, $password)
    {
        $this->login = $login;
        $this->password = $password;

        return $this;
    }

    /**
     * Make the request to API
     *
     * @param string $action
     * @param array $params
     * @param string $method
     * @return array|null
     * @throws \GuzzleHttp\Exception\GuzzleException
     */
    public function exec($action, $params = [], $method = 'GET')
    {
        $endPoint = $this->makeEndPoint($action);
        $requestBody = $this->createRequestBody($params);

        $options = $this->makeOptions($method, $requestBody);

        $response = $this->guzzle->request($method, $endPoint, $options);

It seems like $options defined by $this->makeOptions($method, $requestBody) on line 63 can also be of type null; however, GuzzleHttp\ClientInterface::request() does only seem to accept array, maybe add an additional type check?

        $respArr = $this->parseResponse($response->getBody()->getContents());

        if (is_array($respArr) && array_key_exists('error_descr', $respArr)) {
            $respArr = array_merge(['code' => 0, 'descr' => '', 'error_descr' => []], $respArr); // screw the notices!
            throw new BaseSmsIntelException($respArr['descr'], $respArr['code'], $respArr['error_descr']);
        }

        return $respArr;
    }

    /**
     * @param array $params
     * @return string|array
     */
    protected function createRequestBody(array $params)
    {
        $params = array_merge(
            [
                'login'    => $this->login,
                'password' => $this->password,
            ],
            $params
        );

        ksort($params);

        return $this->formatRequestBody($params);
    }

    /**
     * @param string $method
     * @param string|array $requestBody
     * @return array
     */
    private function makeOptions($method, $requestBody)
    {
        switch (strtoupper($method)) {
            case 'GET':
                return ['query' => $requestBody];
            case 'POST':
                $body = is_array($requestBody) ? \GuzzleHttp\json_encode($requestBody) : $requestBody;
                return ['body' => $body];

        }
    }

    /**
     * @param array $requestBody
     * @return string|array
     */
    abstract protected function formatRequestBody(array $requestBody);

    /**
     * @param string $response
     * @return array
     */
    abstract protected function parseResponse($response);

    /**
     * @param string $action
     * @return string
     */
    abstract protected function makeEndPoint($action);
}