Sender::checkCoupon() - Code Metrics - Inspection of "Develop" - seregazhuk/php-smsintel-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Sergey

created 2016-08-02 05:56 UTC

Sender::checkCoupon() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	11
rs	9.4285
cc	1
eloc	6
nc	1
nop	3

<?php

namespace seregazhuk\SmsIntel;

use seregazhuk\SmsIntel\Contracts\RequestInterface;
use seregazhuk\SmsIntel\Requests\RequestsContainer;

class Sender
{
    /**
     * @var RequestsContainer
     */
    protected $requestsContainer;

    /**
     * @param RequestsContainer $requestsContainer
     */
    public function __construct(RequestsContainer $requestsContainer)
    {
        $this->requestsContainer = $requestsContainer;
    }

    /**
     * Proxies all methods to appropriate Request object
     *
     * @param string $method
     * @param array $arguments
     * @return array
     */
    public function __call($method, $arguments)
    {
        $request = $this
            ->requestsContainer
            ->resolveRequestByAction($method);

        return $this->callRequestMethod($request, $method, $arguments);
    }

    /**
     * @param RequestInterface $request
     * @param string $method
     * @param array $arguments
     * @return mixed
     */
    protected function callRequestMethod(RequestInterface $request, $method, array $arguments)
    {
        switch (count($arguments)) {
            case 1: return $request->{$method}($arguments[0]);
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 2: return $request->{$method}($arguments[0], $arguments[1]);
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 3: return $request->{$method}($arguments[0], $arguments[1], $arguments[2]);
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 4: return $request->{$method}($arguments[0], $arguments[1], $arguments[2], $arguments[3], $arguments[4]);
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            default: return $request->{$method}($arguments);
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}
        }
    }
}

1			<?php
2
3			namespace seregazhuk\SmsIntel;
4
5			use seregazhuk\SmsIntel\Contracts\RequestInterface;
6			use seregazhuk\SmsIntel\Requests\RequestsContainer;
7
8			class Sender
9			{
10			/**
11			* @var RequestsContainer
12			*/
13			protected $requestsContainer;
14
15			/**
16			* @param RequestsContainer $requestsContainer
17			*/
18			public function __construct(RequestsContainer $requestsContainer)
19			{
20			$this->requestsContainer = $requestsContainer;
21			}
22
23			/**
24			* Proxies all methods to appropriate Request object
25			*
26			* @param string $method
27			* @param array $arguments
28			* @return array
29			*/
30			public function __call($method, $arguments)
31			{
32			$request = $this
33			->requestsContainer
34			->resolveRequestByAction($method);
35
36			return $this->callRequestMethod($request, $method, $arguments);
37			}
38
39			/**
40			* @param RequestInterface $request
41			* @param string $method
42			* @param array $arguments
43			* @return mixed
44			*/
45			protected function callRequestMethod(RequestInterface $request, $method, array $arguments)
46			{
47			switch (count($arguments)) {
48			case 1: return $request->{$method}($arguments[0]);
			0 ignored issues – show Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
49			case 2: return $request->{$method}($arguments[0], $arguments[1]);
			0 ignored issues – show Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
50			case 3: return $request->{$method}($arguments[0], $arguments[1], $arguments[2]);
			0 ignored issues – show Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
51			case 4: return $request->{$method}($arguments[0], $arguments[1], $arguments[2], $arguments[3], $arguments[4]);
			0 ignored issues – show Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
52			default: return $request->{$method}($arguments);
			0 ignored issues – show Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-08-02 05:58 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
53			}
54			}
55			}

seregazhuk / php-smsintel-api

Pull Request — master (#3)

Sender::checkCoupon() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like