seregazhuk\PinterestBot\Api\Providers\Conversations

Complexity

Total Complexity

8

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	7
Bugs	0	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	sendMessage()	0	6	2
A	sendEmail()	0	6	2
A	last()	0	8	1
A	callSendMessage()	0	15	3

<?php
namespace seregazhuk\PinterestBot\Api\Providers;

use seregazhuk\PinterestBot\Api\Request;
use seregazhuk\PinterestBot\Exceptions\InvalidRequestException;
use seregazhuk\PinterestBot\Helpers\UrlHelper;

class Conversations extends Provider
{
    protected $loginRequired = ['last', 'sendMessage', 'sendEmail'];

    /**
     * Send message to a user
     *
     * @param array|int $userId
     * @param string $text
     * @param int|null $pinId
     * @return bool
     *
     * @throws InvalidRequestException
     */
    public function sendMessage($userId = [], $text, $pinId = null)
    {
        $userId = is_array($userId) ?: array($userId);

        return $this->callSendMessage($userId, $text, $pinId);

It seems like $userId defined by is_array($userId) ?: array($userId) on line 24 can also be of type boolean; however, seregazhuk\PinterestBot\Api\Providers\Conversations::callSendMessage() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Send email
     *
     * @param array $emails
     * @param string $text
     * @param int|null $pinId
     * @return bool
     * @throws InvalidRequestException
     */
    public function sendEmail($emails = [], $text, $pinId = null)
    {
        $emails = is_array($emails) ?: array($emails);

        return $this->callSendMessage([], $text, $pinId, $emails);

It seems like $emails defined by is_array($emails) ?: array($emails) on line 40 can also be of type boolean; however, seregazhuk\PinterestBot\Api\Providers\Conversations::callSendMessage() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Get last user conversations
     *
     * @return array|bool
     */
    public function last()
    {
        $response = $this->request->exec(
            UrlHelper::RESOURCE_GET_LAST_CONVERSATIONS.'?'.Request::createQuery()
        );

        return $this->response->getData($response);
    }

    /**
     * @param array $userId
     * @param string $text
     * @param int $pinId
     * @param array $emails
     * @return mixed
     *
     * @throws InvalidRequestException
     */
    protected function callSendMessage($userId = [], $text, $pinId, $emails = [])
    {
        if (empty($userId) && empty($emails)) {
            throw new InvalidRequestException('You must specify user_ids or emails to send message.');
        }

        $requestOptions = array(
            'pin'      => $pinId,
            'text'     => $text,
            'emails'   => $emails,
            'user_ids' => $userId,
        );

        return $this->callPostRequest($requestOptions, UrlHelper::RESOURCE_SEND_MESSAGE);
    }
}