CsrfHelper::getCsrfToken() - Code Metrics - Inspection of "Tests and Helpers refactoring" - seregazhuk/php-pinterest-bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89c8a9...bb4dcf )

by Sergey

created 2015-12-19 17:38 UTC

CsrfHelper::getCsrfToken() B

↳ Parent: CsrfHelper

Complexity

Conditions	6
Paths	5

Size

Total Lines	23
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	3	Features	0

Metric	Value
c	6
b	3
f	0
dl	0
loc	23
rs	8.5907
cc	6
eloc	11
nc	5
nop	1

<?php

namespace seregazhuk\PinterestBot\Helpers;

class CsrfHelper
{
    const TOKEN_NAME = 'csrftoken';

    /**
     * Get a CSRF token from the given cookie file
     *
     * @param string $file
     * @return string
     */
    public static function getTokenFromFile($file)
    {
        if ( ! file_exists($file)) {
            return null;
        }

        foreach (file($file) as $line) {

            if ($token = self::_parseLineForToken($line)) {
                return $token;
            }
        }

        return null;
    }

    /**
     * @param string $line
     * @return bool
     */
    protected static function _parseLineForToken($line)
    {
        if (empty(strstr($line, self::TOKEN_NAME))) {
            return false;
        }

        preg_match('/' . self::TOKEN_NAME . '\s(\w*)/', $line, $matches);
        if ($matches) {

            return $matches[1];
        }

        return false;
    }
}


1			<?php
2
3			namespace seregazhuk\PinterestBot\Helpers;
4
5			class CsrfHelper
6			{
7			const TOKEN_NAME = 'csrftoken';
8
9			/**
10			* Get a CSRF token from the given cookie file
11			*
12			* @param string $file
13			* @return string
14			*/
15			public static function getTokenFromFile($file)
16			{
17			if ( ! file_exists($file)) {
18			return null;
19			}
20
21			foreach (file($file) as $line) {
22
23			if ($token = self::_parseLineForToken($line)) {
24			return $token;
25			}
26			}
27
28			return null;
29			}
30
31			/**
32			* @param string $line
33			* @return bool
34			*/
35			protected static function _parseLineForToken($line)
36			{
37			if (empty(strstr($line, self::TOKEN_NAME))) {
38			return false;
39			}
40
41			preg_match('/' . self::TOKEN_NAME . '\s(\w*)/', $line, $matches);
42			if ($matches) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-19 17:41 UTC by Report Bug Copy Issue Report The expression `$matches` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
43			return $matches[1];
44			}
45
46			return false;
47			}
48			}
49

seregazhuk / php-pinterest-bot

Push — master ( 89c8a9...bb4dcf )

CsrfHelper::getCsrfToken() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like