Bot::getLastError() - Code Metrics - Inspection of "New way of creating bot instance (with factory)" - seregazhuk/php-pinterest-bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#32)

by Sergey

created 2016-01-15 20:25 UTC

Bot::getLastError() A

↳ Parent: Bot

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace seregazhuk\PinterestBot;

use LogicException;
use seregazhuk\PinterestBot\Api\Providers\Pins;
use seregazhuk\PinterestBot\Api\Providers\Boards;
use seregazhuk\PinterestBot\Api\Providers\Pinners;
use seregazhuk\PinterestBot\Api\Providers\Provider;
use seregazhuk\PinterestBot\Api\Providers\Interests;
use seregazhuk\PinterestBot\Api\Providers\Conversations;
use seregazhuk\PinterestBot\Contracts\ProvidersContainerInterface;

/**
 * Class Bot
 *
 * @package Pinterest
 * @property string        $username
 * @property string        $password
 * @property Pinners       $pinners
 * @property Pins          $pins
 * @property Boards        $boards
 * @property Interests     $interests
 * @property Conversations $conversations
 */
class Bot
{
    protected $username;
    protected $password;

    /**
     * @var ProvidersContainerInterface
     */
    private $providersContainer;

    public function __construct(ProvidersContainerInterface $providersContainer)
    {
        $this->providersContainer = $providersContainer;

        $this->request = $providersContainer->getRequest();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->response = $providersContainer->getResponse();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Login and parsing csrfToken from cookies if success
     * @param $username
     * @param $password
     * @return bool
     */
    public function login($username, $password)
    {
        $this->username = $username;
        $this->password = $password;

        $this->_checkCredentials();
        $res = $this->pinners->login($this->username, $this->password);

        return $res;
    }

    /**
     * @param string $provider
     * @return Provider
     */
    public function __get($provider)
    {
        $provider = strtolower($provider);

        return $this->providersContainer->getProvider($provider);
    }

    /**
     * @throws LogicException
     */
    protected function _checkCredentials()
    {
        if ( ! $this->username || ! $this->password) {
            throw new LogicException('You must set username and password to login.');
        }
    }

    /**
     * @return array
     */
    public function getLastError()
    {
        return $this->providersContainer->getResponse()->getLastError();
    }
}

1			<?php
2
3			namespace seregazhuk\PinterestBot;
4
5			use LogicException;
6			use seregazhuk\PinterestBot\Api\Providers\Pins;
7			use seregazhuk\PinterestBot\Api\Providers\Boards;
8			use seregazhuk\PinterestBot\Api\Providers\Pinners;
9			use seregazhuk\PinterestBot\Api\Providers\Provider;
10			use seregazhuk\PinterestBot\Api\Providers\Interests;
11			use seregazhuk\PinterestBot\Api\Providers\Conversations;
12			use seregazhuk\PinterestBot\Contracts\ProvidersContainerInterface;
13
14			/**
15			* Class Bot
16			*
17			* @package Pinterest
18			* @property string $username
19			* @property string $password
20			* @property Pinners $pinners
21			* @property Pins $pins
22			* @property Boards $boards
23			* @property Interests $interests
24			* @property Conversations $conversations
25			*/
26			class Bot
27			{
28			protected $username;
29			protected $password;
30
31			/**
32			* @var ProvidersContainerInterface
33			*/
34			private $providersContainer;
35
36			public function __construct(ProvidersContainerInterface $providersContainer)
37			{
38			$this->providersContainer = $providersContainer;
39
40			$this->request = $providersContainer->getRequest();
			0 ignored issues – show Bug introduced 2016-01-15 20:34 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41			$this->response = $providersContainer->getResponse();
			0 ignored issues – show Bug introduced 2016-01-15 20:34 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			}
43
44			/**
45			* Login and parsing csrfToken from cookies if success
46			* @param $username
47			* @param $password
48			* @return bool
49			*/
50			public function login($username, $password)
51			{
52			$this->username = $username;
53			$this->password = $password;
54
55			$this->_checkCredentials();
56			$res = $this->pinners->login($this->username, $this->password);
57
58			return $res;
59			}
60
61			/**
62			* @param string $provider
63			* @return Provider
64			*/
65			public function __get($provider)
66			{
67			$provider = strtolower($provider);
68
69			return $this->providersContainer->getProvider($provider);
70			}
71
72			/**
73			* @throws LogicException
74			*/
75			protected function _checkCredentials()
76			{
77			if ( ! $this->username \|\| ! $this->password) {
78			throw new LogicException('You must set username and password to login.');
79			}
80			}
81
82			/**
83			* @return array
84			*/
85			public function getLastError()
86			{
87			return $this->providersContainer->getResponse()->getLastError();
88			}
89			}

seregazhuk / php-pinterest-bot

Pull Request — master (#32)

Bot::getLastError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like