seregazhuk\HeadHunterApi\Adapters\GuzzleHttpAdater

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	14	2
A	post()	0	10	1
A	parseResponse()	0	4	1

<?php

namespace seregazhuk\HeadHunterApi\Adapters;

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use seregazhuk\HeadHunterApi\Contracts\HttpInterface;

class GuzzleHttpAdater implements HttpInterface
{
    /**
     * @var Client
     */
    protected $client;

    public function __construct($baseUrl)
    {
        $this->client = new Client(['base_uri' => $baseUrl]);
    }

    /**
     * @param string $uri
     * @param array $params
     * @param null $headers
     * @return array|null
     */
    public function get($uri, $params = [], $headers = null)
    {
        if(!empty($params)){
            $uri .= '?'. http_build_query($params);
        }

        $request = new Request('GET', $uri, $headers);

$headers is of type null, but the function expects a array.

        $response = $this
            ->client
            ->send($request);

        return $this->parseResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

    }

    /**
     * @param string $uri
     * @param array $params
     * @param null $headers
     * @return array|null
     */
    public function post($uri, $params = [], $headers = null)
    {
        $request = new Request('POST', $uri, $headers);

$headers is of type null, but the function expects a array.

        $response = $this
            ->client
            ->send($request, ['query' => $params]);

        return $this->parseResponse($response);

$response of type object<Psr\Http\Message\ResponseInterface> is not a sub-type of object<GuzzleHttp\Psr7\Response>. It seems like you assume a concrete implementation of the interface Psr\Http\Message\ResponseInterface to be always present.

    }

    /**
     * @param Response $response
     * @return array|null
     */
    private function parseResponse(Response $response)
    {
        return json_decode($response->getBody(), true);
    }

}