Request::setLocale() - Code Metrics - Inspection of "Merge pull request #22 from seregazhuk/dev" - seregazhuk/php-headhunter-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 625f62...bd2e65 )

by Sergey

created 2017-05-04 17:33 UTC

Request::setLocale() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

namespace seregazhuk\HeadHunterApi;

use GuzzleHttp\Client;
use Psr\Http\Message\ResponseInterface;
use GuzzleHttp\Psr7\Request as GuzzleRequest;

class Request
{
    const BASE_URL = 'https://api.hh.ru/';

    /**
     * @var \GuzzleHttp\Client
     */
    protected $client;

    /**
     * @var array
     */
    protected $headers = [];

    /**
     * @var string
     */
    protected $locale = 'RU';

    /**
     * @var string
     */
    protected $host = 'hh.ru';

    /**
     * @param string $token
     */
    public function __construct($token = null)
    {
        $this->client = new Client(['base_uri' => self::BASE_URL]);

        if ($token) $this->addAuthHeader($token);
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function get($uri, $params = [])
    {
        if (!empty($params)) {
            $uri .= '?' . $this->makeQueryString($params);
        }

        return $this->executeRequest('GET', $uri);
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function post($uri, $params = [])
    {
        return $this->executeRequest(
            'POST', $uri, ['query' => $params]
        );
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function postJson($uri, $params = [])
    {
        return $this->executeRequest(
            'POST', $uri, ['json' => $params]
        );
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function postFile($uri, $params = [])
    {
        return $this->executeRequest(
            'POST', $uri, ['multipart' => $params]
        );
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function put($uri, $params = [])
    {
        return $this->executeRequest(
            'PUT', $uri, ['query' => $params]
        );
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function putJson($uri, $params = [])
    {
        return $this->executeRequest(
            'PUT', $uri, ['json' => $params]
        );
    }

    /**
     * @param string $uri
     * @return array|null
     */
    public function delete($uri)
    {
        return $this->executeRequest('DELETE', $uri);
    }

    /**
     * @param ResponseInterface $response
     * @return array|null
     */
    protected function parseResponse(ResponseInterface $response)
    {
        return json_decode($response->getBody(), true);
    }

    /**
     * @param string $method
     * @param string $uri
     * @param array $options
     * @return array|null
     */
    protected function executeRequest($method, $uri, array $options = [])
    {
        $request = new GuzzleRequest($method, $uri, $this->headers);

        $response = $this->client->send($request, $options);

        return $this->parseResponse($response);
    }

    /**
     * @param string $locale
     * @return Request
     */
    public function setLocale($locale)
    {
        $this->locale = $locale;

        return $this;
    }

    /**
     * @param $params
     * @return string
     */
    protected function makeQueryString($params = [])
    {
        $customOptions = [
            'host'   => $this->host,
            'locale' => $this->locale,
        ];

        $params = array_merge(
            $params, $customOptions
        );

        return http_build_query($params);
    }

    /**
     * @param string $host
     * @return Request
     */
    public function setHost($host)
    {
        $this->host = $host;

        return $this;
    }

    /**
     * @param string $token
     */
    protected function addAuthHeader($token)
    {
        $this->headers = ['Authorization' => 'Bearer ' . $token];
    }
}

1			<?php
2
3			namespace seregazhuk\HeadHunterApi;
4
5			use GuzzleHttp\Client;
6			use Psr\Http\Message\ResponseInterface;
7			use GuzzleHttp\Psr7\Request as GuzzleRequest;
8
9			class Request
10			{
11			const BASE_URL = 'https://api.hh.ru/';
12
13			/**
14			* @var \GuzzleHttp\Client
15			*/
16			protected $client;
17
18			/**
19			* @var array
20			*/
21			protected $headers = [];
22
23			/**
24			* @var string
25			*/
26			protected $locale = 'RU';
27
28			/**
29			* @var string
30			*/
31			protected $host = 'hh.ru';
32
33			/**
34			* @param string $token
35			*/
36			public function __construct($token = null)
37			{
38			$this->client = new Client(['base_uri' => self::BASE_URL]);
39
40			if ($token) $this->addAuthHeader($token);
			0 ignored issues – show Bug Best Practice introduced 2017-05-04 17:25 UTC by Report Bug Copy Issue Report The expression `$token` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
41			}
42
43			/**
44			* @param string $uri
45			* @param array $params
46			* @return array\|null
47			*/
48			public function get($uri, $params = [])
49			{
50			if (!empty($params)) {
51			$uri .= '?' . $this->makeQueryString($params);
52			}
53
54			return $this->executeRequest('GET', $uri);
55			}
56
57			/**
58			* @param string $uri
59			* @param array $params
60			* @return array\|null
61			*/
62			public function post($uri, $params = [])
63			{
64			return $this->executeRequest(
65			'POST', $uri, ['query' => $params]
66			);
67			}
68
69			/**
70			* @param string $uri
71			* @param array $params
72			* @return array\|null
73			*/
74			public function postJson($uri, $params = [])
75			{
76			return $this->executeRequest(
77			'POST', $uri, ['json' => $params]
78			);
79			}
80
81			/**
82			* @param string $uri
83			* @param array $params
84			* @return array\|null
85			*/
86			public function postFile($uri, $params = [])
87			{
88			return $this->executeRequest(
89			'POST', $uri, ['multipart' => $params]
90			);
91			}
92
93			/**
94			* @param string $uri
95			* @param array $params
96			* @return array\|null
97			*/
98			public function put($uri, $params = [])
99			{
100			return $this->executeRequest(
101			'PUT', $uri, ['query' => $params]
102			);
103			}
104
105			/**
106			* @param string $uri
107			* @param array $params
108			* @return array\|null
109			*/
110			public function putJson($uri, $params = [])
111			{
112			return $this->executeRequest(
113			'PUT', $uri, ['json' => $params]
114			);
115			}
116
117			/**
118			* @param string $uri
119			* @return array\|null
120			*/
121			public function delete($uri)
122			{
123			return $this->executeRequest('DELETE', $uri);
124			}
125
126			/**
127			* @param ResponseInterface $response
128			* @return array\|null
129			*/
130			protected function parseResponse(ResponseInterface $response)
131			{
132			return json_decode($response->getBody(), true);
133			}
134
135			/**
136			* @param string $method
137			* @param string $uri
138			* @param array $options
139			* @return array\|null
140			*/
141			protected function executeRequest($method, $uri, array $options = [])
142			{
143			$request = new GuzzleRequest($method, $uri, $this->headers);
144
145			$response = $this->client->send($request, $options);
146
147			return $this->parseResponse($response);
148			}
149
150			/**
151			* @param string $locale
152			* @return Request
153			*/
154			public function setLocale($locale)
155			{
156			$this->locale = $locale;
157
158			return $this;
159			}
160
161			/**
162			* @param $params
163			* @return string
164			*/
165			protected function makeQueryString($params = [])
166			{
167			$customOptions = [
168			'host' => $this->host,
169			'locale' => $this->locale,
170			];
171
172			$params = array_merge(
173			$params, $customOptions
174			);
175
176			return http_build_query($params);
177			}
178
179			/**
180			* @param string $host
181			* @return Request
182			*/
183			public function setHost($host)
184			{
185			$this->host = $host;
186
187			return $this;
188			}
189
190			/**
191			* @param string $token
192			*/
193			protected function addAuthHeader($token)
194			{
195			$this->headers = ['Authorization' => 'Bearer ' . $token];
196			}
197			}

seregazhuk / php-headhunter-api

Push — master ( 625f62...bd2e65 )

Request::setLocale() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like