Manager - Code Metrics - Inspection of "add: Manager preferences" - seregazhuk/php-headhunter-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c07173...5d7f79 )

by Sergey

created 2017-04-22 06:54 UTC

Manager A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	31.25 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	8
c	1
b	0
f	1
lcom	1
cbo	3
dl	20
loc	64
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	preferences()	0	13	2
A	getCurrentEmployerId()	10	10	2
A	getCurrentUser()	0	8	2
A	getCurrentManagerId()	10	10	2

How to fix Duplicated Code

<?php

namespace seregazhuk\HeadHunterApi\EndPoints;

use seregazhuk\HeadHunterApi\Exceptions\HeadHunterApiException;

class Manager extends Endpoint
{

    const RESOURCE = '/employers/{employer_id}/managers/{manager_id}/settings';

    /**
     * @var array
     */
    protected $currentUser;

    /**
     * Get manager settings
     * @param integer $managerId
     * @return array
     */
    public function preferences($managerId = null)
    {
        $employerId = $this->getCurrentEmployerId();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $managerId = $managerId ? : $this->getCurrentManagerId();

        $resource = str_replace(
            ['{employer_id}', '{manager_id}'],
            [$employerId, $managerId],
            self::RESOURCE);


        return $this->request->get($resource);
    }

    /**
     * @return null
     * @throws HeadHunterApiException
     */
    protected function getCurrentEmployerId()

    {
        $currentUser = $this->getCurrentUser();

        if(!isset($currentUser['employer']['id'])) {
            throw new HeadHunterApiException('Cannot resolve employer id');
        }

        return $currentUser['employer']['id'];
    }

    protected function getCurrentUser()
    {
        if(!empty($this->currentUser)) return $this->currentUser;

        $this->currentUser = $this->request->get(Me::RESOURCE);

        return $this->currentUser;
    }

    protected function getCurrentManagerId()

    {
        $currentUser = $this->getCurrentUser();

        if(!isset($currentUser['manager']['id'])) {
            throw new HeadHunterApiException('Cannot resolve manager id');
        }

        return $currentUser['manager']['id'];
    }
}

1		<?php
2
3		namespace seregazhuk\HeadHunterApi\EndPoints;
4
5		use seregazhuk\HeadHunterApi\Exceptions\HeadHunterApiException;
6
7		class Manager extends Endpoint
8		{
9
10		const RESOURCE = '/employers/{employer_id}/managers/{manager_id}/settings';
11
12		/**
13		* @var array
14		*/
15		protected $currentUser;
16
17		/**
18		* Get manager settings
19		* @param integer $managerId
20		* @return array
21		*/
22		public function preferences($managerId = null)
23		{
24		$employerId = $this->getCurrentEmployerId();
		0 ignored issues – show Bug introduced 2017-04-22 06:56 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$employerId` is correct as `$this->getCurrentEmployerId()` (which targets `seregazhuk\HeadHunterApi...:getCurrentEmployerId()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
25		$managerId = $managerId ? : $this->getCurrentManagerId();
26
27		$resource = str_replace(
28		['{employer_id}', '{manager_id}'],
29		[$employerId, $managerId],
30		self::RESOURCE);
31
32
33		return $this->request->get($resource);
34		}
35
36		/**
37		* @return null
38		* @throws HeadHunterApiException
39		*/
40	View Code Duplication	protected function getCurrentEmployerId()
		0 ignored issues – show Duplication introduced 2017-04-22 06:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$currentUser = $this->getCurrentUser();
43
44		if(!isset($currentUser['employer']['id'])) {
45		throw new HeadHunterApiException('Cannot resolve employer id');
46		}
47
48		return $currentUser['employer']['id'];
49		}
50
51		protected function getCurrentUser()
52		{
53		if(!empty($this->currentUser)) return $this->currentUser;
54
55		$this->currentUser = $this->request->get(Me::RESOURCE);
56
57		return $this->currentUser;
58		}
59
60	View Code Duplication	protected function getCurrentManagerId()
		0 ignored issues – show Duplication introduced 2017-04-22 06:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		$currentUser = $this->getCurrentUser();
63
64		if(!isset($currentUser['manager']['id'])) {
65		throw new HeadHunterApiException('Cannot resolve manager id');
66		}
67
68		return $currentUser['manager']['id'];
69		}
70		}

seregazhuk / php-headhunter-api

Push — master ( c07173...5d7f79 )

Manager A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like