seregazhuk\HeadHunterApi\Request

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	get()	0	5	1
A	createHeaders()	0	7	2
A	post()	0	5	1

<?php

namespace seregazhuk\HeadHunterApi;


use seregazhuk\HeadHunterApi\Contracts\HttpInterface;
use seregazhuk\HeadHunterApi\Contracts\RequestInterface;

class Request implements RequestInterface
{
    const BASE_URL = 'https://api.hh.ru';
    private $client;
    private $token;

    public function __construct(HttpInterface $http, $token = null)
    {
        $http->setBaseUrl(self::BASE_URL);
        $this->client = $http;
        $this->token = $token;
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array|null
     */
    public function get($uri, $params = [])
    {
        $headers = $this->createHeaders();
        return $this->client->get($uri, $params, $headers);

It seems like $headers defined by $this->createHeaders() on line 29 can also be of type array; however, seregazhuk\HeadHunterApi\Contracts\HttpInterface::get() does only seem to accept null, maybe add an additional type check?

    }

    /**
     * @return array|null
     */
    protected function createHeaders()
    {
        $headers = null;
        if(isset($this->token)) $headers['Authorization'] = 'Bearer ' . $this->token;

        return $headers;
    }

    /**
     * @param string $uri
     * @param array $params
     * @return array
     */
    public function post($uri, $params = [])
    {
        $headers = $this->createHeaders();
        return $this->client->post($uri, $params, $headers);

It seems like $headers defined by $this->createHeaders() on line 51 can also be of type array; however, seregazhuk\HeadHunterApi\Contracts\HttpInterface::post() does only seem to accept null, maybe add an additional type check?

    }
}