Manager::preferences() - Code Metrics - Inspection of "resume: edit, create" - seregazhuk/php-headhunter-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Sergey

created 2017-04-28 20:47 UTC

Manager::preferences() A

↳ Parent: Manager

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	13
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php

namespace seregazhuk\HeadHunterApi\EndPoints;

use seregazhuk\HeadHunterApi\Exceptions\HeadHunterApiException;

class Manager extends Endpoint
{
    const RESOURCE = '/employers';

    /**
     * Get manager settings
     * @param integer $managerId
     * @return array
     */
    public function preferences($managerId = null)
    {
        $employerId = $this->getCurrentUserDataId('employer');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $managerId = $managerId ?: $this->getCurrentUserDataId('manager');

        $uri = str_replace(
            ['{employer_id}', '{manager_id}'],
            [$employerId, $managerId],
            '{employer_id}/managers/{manager_id}/settings'
        );

        return $this->getResource($uri);
    }

    /**
     * @param $key
     * @return null
     * @throws HeadHunterApiException
     */
    protected function getCurrentUserDataId($key)
    {
        $currentUser = $this->getCurrentUserInfo();

        if (!isset($currentUser[$key]['id'])) {
            throw new HeadHunterApiException("Cannot resolve $key id");
        }

        return $currentUser[$key]['id'];
    }

    /**
     * @return array
     */
    protected function getCurrentUserInfo()
    {
        /** @var Me $meEndpoint */
        $meEndpoint = $this->container->getEndpoint('me');

        return $meEndpoint->info();
    }
}

1			<?php
2
3			namespace seregazhuk\HeadHunterApi\EndPoints;
4
5			use seregazhuk\HeadHunterApi\Exceptions\HeadHunterApiException;
6
7			class Manager extends Endpoint
8			{
9			const RESOURCE = '/employers';
10
11			/**
12			* Get manager settings
13			* @param integer $managerId
14			* @return array
15			*/
16			public function preferences($managerId = null)
17			{
18			$employerId = $this->getCurrentUserDataId('employer');
			0 ignored issues – show Bug introduced 2017-04-25 13:46 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$employerId` is correct as `$this->getCurrentUserDataId('employer')` (which targets `seregazhuk\HeadHunterApi...:getCurrentUserDataId()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
19			$managerId = $managerId ?: $this->getCurrentUserDataId('manager');
20
21			$uri = str_replace(
22			['{employer_id}', '{manager_id}'],
23			[$employerId, $managerId],
24			'{employer_id}/managers/{manager_id}/settings'
25			);
26
27			return $this->getResource($uri);
28			}
29
30			/**
31			* @param $key
32			* @return null
33			* @throws HeadHunterApiException
34			*/
35			protected function getCurrentUserDataId($key)
36			{
37			$currentUser = $this->getCurrentUserInfo();
38
39			if (!isset($currentUser[$key]['id'])) {
40			throw new HeadHunterApiException("Cannot resolve $key id");
41			}
42
43			return $currentUser[$key]['id'];
44			}
45
46			/**
47			* @return array
48			*/
49			protected function getCurrentUserInfo()
50			{
51			/** @var Me $meEndpoint */
52			$meEndpoint = $this->container->getEndpoint('me');
53
54			return $meEndpoint->info();
55			}
56			}

seregazhuk / php-headhunter-api

Pull Request — master (#14)

Manager::preferences() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like