Endpoint - Code Metrics - Inspection of "upd: BelongsToOrganization trait removed" - seregazhuk/php-favro-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c6a286...b1bd72 )

by Sergey

created 2016-08-31 09:21 UTC

Endpoint A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes	11
Bugs	2	Features	0

Metric	Value
wmc	8
c	11
b	2
f	0
lcom	2
cbo	1
dl	0
loc	111
rs	10

8 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	makeRequestUrl()	4	1
A	isMethodAllowed()	4	1
A	getHttp()	4	1
A	getAll()	6	1
A	getById()	6	1
A	getHeaders()	7	1
A	setOrganizationId()	6	1

<?php

namespace seregazhuk\Favro\Api\Endpoints;

use seregazhuk\Favro\Contracts\HttpClient;

class Endpoint
{
    /**
     * @var array
     */
    protected $allowedMethods = [
        'getById',
        'getAll',
        'create',
        'update',
        'delete',
    ];

    /**
     * @var string
     */
    protected $endpoint;

    /**
     * @var array
     */
    protected $headers = [];

    /**
     * @var HttpClient
     */
    protected $http;

    /**
     * @var string
     */
    protected $organizationId;

    /**
     * @param HttpClient $http
     */
    public function __construct(HttpClient $http)
    {
        $this->http = $http;
    }

    /**
     * @param string $verb
     * @return string
     */
    public function makeRequestUrl($verb = '')
    {
        return "https://favro.com/api/v1/{$this->endpoint}/$verb";
    }

    /**
     * @param string $method
     * @return bool
     */
    public function isMethodAllowed($method)
    {
        return in_array($method, $this->allowedMethods);
    }

    /**
     * @return HttpClient
     */
    public function getHttp()
    {
        return $this->http;
    }

    /**
     * @param array $params
     * @return array
     */
    public function getAll(array $params = [])
    {
        return $this->getHttp()->get(
            $this->makeRequestUrl(), $params, $this->getHeaders()
        );
    }

    /**
     * @param string $id
     * @return array
     */
    public function getById($id)
    {
        return $this->getHttp()->get(
            $this->makeRequestUrl($id), [], $this->getHeaders()
        );
    }

    /**
     * @return array
     */
    protected function getHeaders()
    {
        return array_merge(
            $this->headers,
            ['organizationId' => $this->organizationId]
        );
    }

    /**
     * @param int $organizationId
     * @return $this
     */
    public function setOrganizationId($organizationId)
    {
        $this->organizationId = $organizationId;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        return $this;
    }
}

1			<?php
2
3			namespace seregazhuk\Favro\Api\Endpoints;
4
5			use seregazhuk\Favro\Contracts\HttpClient;
6
7			class Endpoint
8			{
9			/**
10			* @var array
11			*/
12			protected $allowedMethods = [
13			'getById',
14			'getAll',
15			'create',
16			'update',
17			'delete',
18			];
19
20			/**
21			* @var string
22			*/
23			protected $endpoint;
24
25			/**
26			* @var array
27			*/
28			protected $headers = [];
29
30			/**
31			* @var HttpClient
32			*/
33			protected $http;
34
35			/**
36			* @var string
37			*/
38			protected $organizationId;
39
40			/**
41			* @param HttpClient $http
42			*/
43			public function __construct(HttpClient $http)
44			{
45			$this->http = $http;
46			}
47
48			/**
49			* @param string $verb
50			* @return string
51			*/
52			public function makeRequestUrl($verb = '')
53			{
54			return "https://favro.com/api/v1/{$this->endpoint}/$verb";
55			}
56
57			/**
58			* @param string $method
59			* @return bool
60			*/
61			public function isMethodAllowed($method)
62			{
63			return in_array($method, $this->allowedMethods);
64			}
65
66			/**
67			* @return HttpClient
68			*/
69			public function getHttp()
70			{
71			return $this->http;
72			}
73
74			/**
75			* @param array $params
76			* @return array
77			*/
78			public function getAll(array $params = [])
79			{
80			return $this->getHttp()->get(
81			$this->makeRequestUrl(), $params, $this->getHeaders()
82			);
83			}
84
85			/**
86			* @param string $id
87			* @return array
88			*/
89			public function getById($id)
90			{
91			return $this->getHttp()->get(
92			$this->makeRequestUrl($id), [], $this->getHeaders()
93			);
94			}
95
96			/**
97			* @return array
98			*/
99			protected function getHeaders()
100			{
101			return array_merge(
102			$this->headers,
103			['organizationId' => $this->organizationId]
104			);
105			}
106
107			/**
108			* @param int $organizationId
109			* @return $this
110			*/
111			public function setOrganizationId($organizationId)
112			{
113			$this->organizationId = $organizationId;
			0 ignored issues – show Documentation Bug introduced 2016-08-31 09:28 UTC by Report Bug Copy Issue Report The property `$organizationId` was declared of type `string`, but `$organizationId` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
114
115			return $this;
116			}
117			}

seregazhuk / php-favro-api

Push — master ( c6a286...b1bd72 )

Endpoint A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like