SubscriptionController - Code Metrics - seongbae/discuss - Measure and Improve Code Quality continuously with Scrutinizer

SubscriptionController A
last analyzed 2021-05-30 21:33 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	56.6 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	30
loc	53
rs	10
c	0
b	0
f	0
wmc	9
lcom	0
cbo	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	store()	15	15	4
A	destroy()	15	15	4

How to fix Duplicated Code

<?php

namespace Seongbae\Discuss\Http\Controllers;

use Illuminate\Database\Eloquent\Model;
use Seongbae\Discuss\Models\Subscription;
use Seongbae\Discuss\Models\Thread;
use Illuminate\Http\Request;
use Seongbae\Discuss\Models\Channel;
use App\Http\Controllers\Controller;
use Auth;
use Illuminate\Support\Facades\Log;
use App\Models\User;

class SubscriptionController extends Controller
{
    /**
     * ThreadsController constructor.
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request, User $user)

    {
        if ($request->type == 'thread')
            $subscribable = Thread::find($request->id);
        elseif ($request->type == 'channel')
            $subscribable = Channel::find($request->id);

        $subscribable->attachSubscriber($user);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        if ($request->ajax())
            return $request->json([], 200);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        else
            return redirect()->back();

    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, User $user)

    {
        if ($request->type == 'thread')
            $subscribable = Thread::find($request->id);
        elseif ($request->type == 'channel')
            $subscribable = Channel::find($request->id);

        $subscribable->detachSubscriber($user);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        if ($request->ajax())
            return $request->json([], 200);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        else
            return redirect()->back();

    }

}


1		<?php
2
3		namespace Seongbae\Discuss\Http\Controllers;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Seongbae\Discuss\Models\Subscription;
7		use Seongbae\Discuss\Models\Thread;
8		use Illuminate\Http\Request;
9		use Seongbae\Discuss\Models\Channel;
10		use App\Http\Controllers\Controller;
11		use Auth;
12		use Illuminate\Support\Facades\Log;
13		use App\Models\User;
14
15		class SubscriptionController extends Controller
16		{
17		/**
18		* ThreadsController constructor.
19		*/
20		public function __construct()
21		{
22		$this->middleware('auth');
23		}
24
25		/**
26		* Display a listing of the resource.
27		*
28		* @return \Illuminate\Http\Response
29		*/
30	View Code Duplication	public function store(Request $request, User $user)
		0 ignored issues – show Duplication introduced 2021-01-03 01:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		if ($request->type == 'thread')
33		$subscribable = Thread::find($request->id);
34		elseif ($request->type == 'channel')
35		$subscribable = Channel::find($request->id);
36
37		$subscribable->attachSubscriber($user);
		0 ignored issues – show Bug introduced 2021-01-03 01:14 UTC by Report Bug Copy Issue Report The variable `$subscribable` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
38
39		if ($request->ajax())
40		return $request->json([], 200);
		0 ignored issues – show Documentation introduced 2020-12-21 05:42 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41		else
42		return redirect()->back();
43
44		}
45
46		/**
47		* Display a listing of the resource.
48		*
49		* @return \Illuminate\Http\Response
50		*/
51	View Code Duplication	public function destroy(Request $request, User $user)
		0 ignored issues – show Duplication introduced 2021-01-03 01:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		if ($request->type == 'thread')
54		$subscribable = Thread::find($request->id);
55		elseif ($request->type == 'channel')
56		$subscribable = Channel::find($request->id);
57
58		$subscribable->detachSubscriber($user);
		0 ignored issues – show Bug introduced 2021-01-03 01:14 UTC by Report Bug Copy Issue Report The variable `$subscribable` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
59
60		if ($request->ajax())
61		return $request->json([], 200);
		0 ignored issues – show Documentation introduced 2021-01-03 01:14 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62		else
63		return redirect()->back();
64
65		}
66
67		}
68

seongbae / discuss

SubscriptionController A last analyzed 2021-05-30 21:33 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

SubscriptionController A
last analyzed 2021-05-30 21:33 UTC