Container::create() - Code Metrics - Inspection of "Support array definition of resources" - sensorario/resources - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#56)

by Simone

created 2016-07-11 22:43 UTC

Container::create() A

↳ Parent: Container

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	10
Ratio	62.5 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	10
loc	16
rs	9.2
cc	4
eloc	8
nc	4
nop	2

<?php

namespace Sensorario\Resources;

use \RuntimeException;

class Container
{
    private $resources;

    public function __construct(array $resources)
    {
        if (!isset($resources['resources'])) {
            throw new RuntimeException(
                ''
            );
        }

        foreach ($resources['resources'] as $item) {
            if (isset($item['constraints'])) {
                foreach ($item['constraints'] as $name => $value) {
                    $allowed = [
                        'allowed',
                    ];

                    if (!in_array($name, $allowed)) {
                        throw new RuntimeException(
                            'Invalid constraint'
                        );
                    }
                }
            }
        }

        $this->resources = $resources;
    }

    public function countResources()
    {
        return count(
            $this->resources['resources']
        );
    }

    public function create($resource, array $constraints)
    {
        foreach ($constraints as $name => $value) {
            if (!isset($this->resources['resources'][$resource]['constraints']['allowed'])) {

                throw new RuntimeException(
                    'Not allowed `' . $name . '` constraint'
                );
            }

            if (!in_array($name, $this->resources['resources'][$resource]['constraints']['allowed'])) {

                throw new RuntimeException(
                    'Not allowed `' . $name . '` constraint'
                );
            }
        }
    }

    public function allowed($resource)
    {
        return $this->resources['resources'][$resource]['constraints']['allowed'];
    }
}


1		<?php
2
3		namespace Sensorario\Resources;
4
5		use \RuntimeException;
6
7		class Container
8		{
9		private $resources;
10
11		public function __construct(array $resources)
12		{
13		if (!isset($resources['resources'])) {
14		throw new RuntimeException(
15		''
16		);
17		}
18
19		foreach ($resources['resources'] as $item) {
20		if (isset($item['constraints'])) {
21		foreach ($item['constraints'] as $name => $value) {
22		$allowed = [
23		'allowed',
24		];
25
26		if (!in_array($name, $allowed)) {
27		throw new RuntimeException(
28		'Invalid constraint'
29		);
30		}
31		}
32		}
33		}
34
35		$this->resources = $resources;
36		}
37
38		public function countResources()
39		{
40		return count(
41		$this->resources['resources']
42		);
43		}
44
45		public function create($resource, array $constraints)
46		{
47		foreach ($constraints as $name => $value) {
48	View Code Duplication	if (!isset($this->resources['resources'][$resource]['constraints']['allowed'])) {
		0 ignored issues – show Duplication introduced 2016-07-10 06:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		throw new RuntimeException(
50		'Not allowed `' . $name . '` constraint'
51		);
52		}
53
54	View Code Duplication	if (!in_array($name, $this->resources['resources'][$resource]['constraints']['allowed'])) {
		0 ignored issues – show Duplication introduced 2016-07-10 06:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		throw new RuntimeException(
56		'Not allowed `' . $name . '` constraint'
57		);
58		}
59		}
60		}
61
62		public function allowed($resource)
63		{
64		return $this->resources['resources'][$resource]['constraints']['allowed'];
65		}
66		}
67

sensorario / resources

Pull Request — master (#56)

Container::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like