Container::create() - Code Metrics - Inspection of "Code climate" - sensorario/resources - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#85)

by Simone

created 2016-12-04 11:19 UTC

Container::create() A

↳ Parent: Container

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	10
Ratio	62.5 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	10
loc	16
rs	9.2
cc	4
eloc	8
nc	4
nop	2

<?php

namespace Sensorario\Resources;

use \RuntimeException;

class Container
    extends ContainerBase

{
    private $resources;

    private $allowed = [
        'allowed',
        'allowedRanges',
        'allowedValues',
        'defaults',
        'mandatory',
        'rules',
    ];

    private function ensureValidConstraints($resources)
    {
        foreach ($resources['resources'] as $item) {
            if (isset($item['constraints'])) {
                foreach ($item['constraints'] as $name => $value) {
                    if (!in_array($name, $this->allowed)) {
                        throw new RuntimeException(
                            'Invalid constraint: '
                            . 'name ' . $name
                            . '; value ' . $value
                        );
                    }
                }
            }
        }
    }

    public function __construct(array $resources)
    {
        if (!isset($resources['resources'])) {
            throw new RuntimeException(
                'resources element is not defined'
            );
        }

        $this->rewrites = [];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->globals  = [];
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->ensureValidConstraints($resources);

        foreach ($resources['resources'] as $item) {
            if (isset($item['rewrite'])) {
                foreach ($item['rewrite'] as $field => $rewriteRule) {
                    $this->rewrites[$field] = $rewriteRule;
                }
            }
        }

        if (isset($resources['globals'])) {
            $this->globals = $resources['globals'];
        }

        $this->resources = $resources;
    }

    public function countResources()
    {
        return count(
            $this->resources['resources']
        );
    }

    public function create($resource, array $constraints)
    {
        foreach ($constraints as $name => $value) {
            if (!isset($this->resources['resources'][$resource]['constraints']['allowed'])) {

                throw new RuntimeException(
                    'Not allowed `' . $name . '` constraint with value `' . $value . '`'
                );
            }

            if (!in_array($name, $this->resources['resources'][$resource]['constraints']['allowed'])) {

                throw new RuntimeException(
                    'Not allowed `' . $name . '` constraint with value `' . $value . '`'
                );
            }
        }
    }

    public function allowed($resource)
    {
        $allowed = [];

        foreach ($this->allowed as $item) {
            if (isset($this->resources['resources'][$resource]['constraints'][$item])) {

                $allowed = array_merge(
                    $allowed,
                    $this->resources['resources'][$resource]['constraints'][$item]
                );
            }
        }

        return $allowed;
    }

    public function getConstraints(
        $constraintName,
        $resource
    ) {
        if (isset($this->resources['resources'][$resource]['constraints'][$constraintName])) {

            return $this->resources['resources'][$resource]['constraints'][$constraintName];
        }

        return [];
    }

    public function rewrites()
    {
        return $this->rewrites;
    }

    public function globals()
    {
        return $this->globals;
    }
}


1		<?php
2
3		namespace Sensorario\Resources;
4
5		use \RuntimeException;
6
7		class Container
8		extends ContainerBase
		0 ignored issues – show Coding Style introduced 2016-08-04 12:09 UTC by Report Bug Copy Issue Report The extends keyword must be on the same line as the class name Loading history...
9		{
10		private $resources;
11
12		private $allowed = [
13		'allowed',
14		'allowedRanges',
15		'allowedValues',
16		'defaults',
17		'mandatory',
18		'rules',
19		];
20
21		private function ensureValidConstraints($resources)
22		{
23		foreach ($resources['resources'] as $item) {
24		if (isset($item['constraints'])) {
25		foreach ($item['constraints'] as $name => $value) {
26		if (!in_array($name, $this->allowed)) {
27		throw new RuntimeException(
28		'Invalid constraint: '
29		. 'name ' . $name
30		. '; value ' . $value
31		);
32		}
33		}
34		}
35		}
36		}
37
38		public function __construct(array $resources)
39		{
40		if (!isset($resources['resources'])) {
41		throw new RuntimeException(
42		'resources element is not defined'
43		);
44		}
45
46		$this->rewrites = [];
		0 ignored issues – show Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The property `rewrites` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47		$this->globals = [];
		0 ignored issues – show Bug introduced 2016-07-30 08:11 UTC by Report Bug Copy Issue Report The property `globals` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48
49		$this->ensureValidConstraints($resources);
50
51		foreach ($resources['resources'] as $item) {
52		if (isset($item['rewrite'])) {
53		foreach ($item['rewrite'] as $field => $rewriteRule) {
54		$this->rewrites[$field] = $rewriteRule;
55		}
56		}
57		}
58
59		if (isset($resources['globals'])) {
60		$this->globals = $resources['globals'];
61		}
62
63		$this->resources = $resources;
64		}
65
66		public function countResources()
67		{
68		return count(
69		$this->resources['resources']
70		);
71		}
72
73		public function create($resource, array $constraints)
74		{
75		foreach ($constraints as $name => $value) {
76	View Code Duplication	if (!isset($this->resources['resources'][$resource]['constraints']['allowed'])) {
		0 ignored issues – show Duplication introduced 2016-07-10 06:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		throw new RuntimeException(
78		'Not allowed `' . $name . '` constraint with value `' . $value . '`'
79		);
80		}
81
82	View Code Duplication	if (!in_array($name, $this->resources['resources'][$resource]['constraints']['allowed'])) {
		0 ignored issues – show Duplication introduced 2016-07-10 06:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		throw new RuntimeException(
84		'Not allowed `' . $name . '` constraint with value `' . $value . '`'
85		);
86		}
87		}
88		}
89
90		public function allowed($resource)
91		{
92		$allowed = [];
93
94		foreach ($this->allowed as $item) {
95	View Code Duplication	if (isset($this->resources['resources'][$resource]['constraints'][$item])) {
		0 ignored issues – show Duplication introduced 2016-08-04 12:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		$allowed = array_merge(
97		$allowed,
98		$this->resources['resources'][$resource]['constraints'][$item]
99		);
100		}
101		}
102
103		return $allowed;
104		}
105
106		public function getConstraints(
107		$constraintName,
108		$resource
109		) {
110	View Code Duplication	if (isset($this->resources['resources'][$resource]['constraints'][$constraintName])) {
		0 ignored issues – show Duplication introduced 2016-08-04 12:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		return $this->resources['resources'][$resource]['constraints'][$constraintName];
112		}
113
114		return [];
115		}
116
117		public function rewrites()
118		{
119		return $this->rewrites;
120		}
121
122		public function globals()
123		{
124		return $this->globals;
125		}
126		}
127

sensorario / resources

Pull Request — master (#85)

Container::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like