Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class RuleTest extends \PHPUnit_Framework_TestCase |
||
17 | { |
||
18 | /** |
||
19 | * @expectedException \LogicException |
||
20 | * @expectedExceptionMessage rule type is not defined |
||
21 | */ |
||
22 | public function testIvalidInitializationThrowAndException() |
||
26 | |||
27 | public function test() |
||
42 | |||
43 | /** |
||
44 | * @expectedException \Sensorario\Resources\Exceptions\InvalidTypeException |
||
45 | * @expectedExceptionMessageRegex #Oops! Invalid configuration!!!Type `foo` is not valid.# |
||
46 | */ |
||
47 | public function testInvalidTypeIsNotAllowed() |
||
55 | |||
56 | public function testCheckFunctionReturnRuleValidityAsBoolean() |
||
67 | |||
68 | View Code Duplication | public function testIs() |
|
83 | |||
84 | View Code Duplication | public function testIsNot() |
|
99 | } |
||
100 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.