Resource - Code Metrics - Inspection of "Merge pull request #109 from sensorario/enhance/ru..." - sensorario/resources - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95eb92...833c5e )

by Simone

created 2017-01-16 23:27 UTC

Resource A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

Metric	Value
wmc	18
lcom	2
cbo	3
dl	0
loc	112
rs	10
c	0
b	0
f	0

15 Methods

Rating	Name	Size	Complexity
A	mandatory()	4	1
A	allowed()	4	1
A	allowedValues()	4	1
A	rules()	4	1
A	defaults()	4	1
A	rewrites()	4	1
A	ranges()	4	1
A	applyConfiguration()	21	3
A	isRuleDefinedFor()	4	1
A	isRuleNotDefinedFor()	4	1
A	getRule()	6	1
A	isFieldNumeric()	4	1
A	isFieldString()	4	1
A	isFieldNumericButString()	5	2
A	getFieldType()	4	1

<?php

/**
 * This file is part of sensorario/resources repository
 *
 * (c) Simone Gentili <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sensorario\Resources;

use RuntimeException;

class Resource extends MagicResource

    implements Interfaces\ResourceInterface

{
    protected $allowed = [];

    protected $allowedValues = [];

    protected $mandatory = [];

    protected $defaults = [];

    protected $rules = [];

    protected $rewrites = [];

    protected $ranges = [];

    public function mandatory()
    {
        return $this->mandatory;
    }

    public function allowed()
    {
        return $this->allowed;
    }

    public function allowedValues()
    {
        return $this->allowedValues;
    }

    public function rules()
    {
        return $this->rules;
    }

    public function defaults()
    {
        return $this->defaults;
    }

    public function rewrites()
    {
        return $this->rewrites;
    }

    public function ranges()
    {
        return $this->ranges;
    }

    public function applyConfiguration(
        Configurator $configurator
    ) {
        $this->allowed       = $configurator->allowed();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->mandatory     = $configurator->mandatory();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->defaults      = $configurator->defaults();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->rules         = $configurator->rules();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->allowedValues = $configurator->allowedValues();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->rewrites      = $configurator->rewrites();
        $this->ranges        = $configurator->ranges();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if ($configurator->globals()) {
            $globals = $configurator->globals();
            if (isset($globals['allowed'])) {
                $this->allowed = array_merge(
                    $this->allowed,
                    $globals['allowed']
                );
            }
        }
    }

    public function isRuleDefinedFor($ruleName)
    {
        return isset($this->rules()[$ruleName]);
    }

    public function isRuleNotDefinedFor($ruleName)
    {
        return !$this->isRuleDefinedFor($ruleName);
    }

    public function getRule($ruleName) : Rule
    {
        return Rule::fromArray(
            $this->rules()[$ruleName]
        );
    }

    public function isFieldNumeric($fieldName)
    {
        return is_numeric($this->get($fieldName));
    }

    public function isFieldString($fieldName)
    {
        return is_string($this->get($fieldName));
    }

    public function isFieldNumericButString($fieldName)
    {
        return $this->isFieldNumeric($fieldName)
            && $this->isFieldString($fieldName);
    }

    public function getFieldType($fieldName)
    {
        return gettype($this->get($fieldName));
    }
}


1			<?php
2
3			/**
4			* This file is part of sensorario/resources repository
5			*
6			* (c) Simone Gentili <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sensorario\Resources;
13
14			use RuntimeException;
15
16			class Resource extends MagicResource
			0 ignored issues – show Coding Style introduced 2017-01-16 21:45 UTC by Report Bug Copy Issue Report Expected 0 spaces between "MagicResource" and comma; 1 found Loading history...
17			implements Interfaces\ResourceInterface
			0 ignored issues – show Coding Style introduced 2016-07-10 06:27 UTC by Report Bug Copy Issue Report The implements keyword must be on the same line as the class name Loading history...
18			{
19			protected $allowed = [];
20
21			protected $allowedValues = [];
22
23			protected $mandatory = [];
24
25			protected $defaults = [];
26
27			protected $rules = [];
28
29			protected $rewrites = [];
30
31			protected $ranges = [];
32
33			public function mandatory()
34			{
35			return $this->mandatory;
36			}
37
38			public function allowed()
39			{
40			return $this->allowed;
41			}
42
43			public function allowedValues()
44			{
45			return $this->allowedValues;
46			}
47
48			public function rules()
49			{
50			return $this->rules;
51			}
52
53			public function defaults()
54			{
55			return $this->defaults;
56			}
57
58			public function rewrites()
59			{
60			return $this->rewrites;
61			}
62
63			public function ranges()
64			{
65			return $this->ranges;
66			}
67
68			public function applyConfiguration(
69			Configurator $configurator
70			) {
71			$this->allowed = $configurator->allowed();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `allowed` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
72			$this->mandatory = $configurator->mandatory();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `mandatory` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
73			$this->defaults = $configurator->defaults();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `defaults` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
74			$this->rules = $configurator->rules();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `rules` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
75			$this->allowedValues = $configurator->allowedValues();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `allowedValues` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
76			$this->rewrites = $configurator->rewrites();
77			$this->ranges = $configurator->ranges();
			0 ignored issues – show Documentation Bug introduced 2016-12-04 11:24 UTC by Report Bug Copy Issue Report The method `ranges` does not exist on `object<Sensorario\Resources\Configurator>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
78
79			if ($configurator->globals()) {
80			$globals = $configurator->globals();
81			if (isset($globals['allowed'])) {
82			$this->allowed = array_merge(
83			$this->allowed,
84			$globals['allowed']
85			);
86			}
87			}
88			}
89
90			public function isRuleDefinedFor($ruleName)
91			{
92			return isset($this->rules()[$ruleName]);
93			}
94
95			public function isRuleNotDefinedFor($ruleName)
96			{
97			return !$this->isRuleDefinedFor($ruleName);
98			}
99
100			public function getRule($ruleName) : Rule
101			{
102			return Rule::fromArray(
103			$this->rules()[$ruleName]
104			);
105			}
106
107			public function isFieldNumeric($fieldName)
108			{
109			return is_numeric($this->get($fieldName));
110			}
111
112			public function isFieldString($fieldName)
113			{
114			return is_string($this->get($fieldName));
115			}
116
117			public function isFieldNumericButString($fieldName)
118			{
119			return $this->isFieldNumeric($fieldName)
120			&& $this->isFieldString($fieldName);
121			}
122
123			public function getFieldType($fieldName)
124			{
125			return gettype($this->get($fieldName));
126			}
127			}
128

sensorario / resources

Push — master ( 95eb92...833c5e )

Resource A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

Duplication Side-by-Side

Filter issues like