Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 17 | class RuleTest extends TestCase |
||
| 18 | { |
||
| 19 | /** |
||
| 20 | * @expectedException \LogicException |
||
| 21 | * @expectedExceptionMessage rule type is not defined |
||
| 22 | */ |
||
| 23 | public function testIvalidInitializationThrowAndException() |
||
| 27 | |||
| 28 | public function testContainsConfigurationAsArray() |
||
| 29 | { |
||
| 30 | $rule = Rule::fromArray( |
||
| 31 | $ruleConfiguration = [ |
||
| 32 | Rule::TYPE_OBJECT => [ |
||
| 33 | '\DateTime', |
||
| 34 | ] |
||
| 35 | ] |
||
| 36 | ); |
||
| 37 | |||
| 38 | $this->assertEquals( |
||
| 39 | $ruleConfiguration, |
||
| 40 | $rule->asArray() |
||
| 41 | ); |
||
| 42 | } |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @expectedException \Sensorario\Resources\Exceptions\InvalidTypeException |
||
| 46 | * @expectedExceptionMessageRegex #Oops! Invalid configuration!!!Type `foo` is not valid.# |
||
| 47 | */ |
||
| 48 | public function testInvalidTypeIsNotAllowed() |
||
| 56 | |||
| 57 | public function testCheckFunctionReturnRuleValidityAsBoolean() |
||
| 68 | |||
| 69 | View Code Duplication | public function testCheckIfValueIsOfRightObjectType() |
|
| 84 | |||
| 85 | View Code Duplication | public function testCheckIfValueIsNotOfRightObjectType() |
|
| 100 | |||
| 101 | View Code Duplication | public function testGetExpectedType() |
|
| 116 | } |
||
| 117 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.