bika.health.widgets.casesymptomswidget.CaseSymptomsWidget.getSymptoms() - Code Metrics - senaite/senaite.health - Measure and Improve Code Quality continuously with Scrutinizer

CaseSymptomsWidget.getSymptoms() C
last analyzed 2020-02-18 09:40 UTC

↳ Parent: bika.health.widgets.casesymptomswidget

Complexity

Conditions

Size

Total Lines	51
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	44
dl	0
loc	51
rs	5.4
c	0
b	0
f	0
cc	11
nop	2

How to fix Long Method Complexity

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

If many parameters/temporary variables are present:
- Replace temporary variables with Query
- Introduce parameter object; often combined with preserve whole object
- If the above two are insufficient: Replace method with method object
If you have long conditionals: Decompose Conditional
Otherwise: Extract method

Complexity

Complex classes like bika.health.widgets.casesymptomswidget.CaseSymptomsWidget.getSymptoms() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

# -*- coding: utf-8 -*-
#
# This file is part of SENAITE.HEALTH.
#
# SENAITE.HEALTH is free software: you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by the Free
# Software Foundation, version 2.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
# details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, write to the Free Software Foundation, Inc., 51
# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Copyright 2018-2019 by it's authors.
# Some rights reserved, see README and LICENSE.

from AccessControl import ClassSecurityInfo
from Products.Archetypes.Registry import registerWidget
from Products.Archetypes.Widget import TypesWidget
from Products.ATExtensions.widget import RecordsWidget as ATRecordsWidget
from Products.Archetypes.Registry import registerWidget
from Products.CMFCore.utils import getToolByName
from operator import itemgetter
import json


class CaseSymptomsWidget(ATRecordsWidget):
    security = ClassSecurityInfo()
    _properties = ATRecordsWidget._properties.copy()
    _properties.update({
        'macro': "bika_health_widgets/casesymptomswidget",
        'helper_js': ("bika_health_widgets/casesymptomswidget.js",),
        'helper_css': ("bika_health_widgets/casesymptomswidget.css",),
        'gender': None,
        'allowDelete': False,
        'readonly': False,
        'combogrid_options': '',
    })

    def process_form(self, instance, field, form, empty_marker=None,
                     emptyReturnsMarker=False):
        outvalues = []
        values = form.get(field.getName(), empty_marker)
        for value in values:
            if 'Assigned' in value and int(value['Assigned']) == 1:
                outvalues.append({'UID': value['UID'],
                                  'Title': value.get('Title', ''),
                                  'Description': value.get('Description', ''),
                                  'Severity': value.get(value['UID'], '0'),
                                  'SeverityAllowed':value.get('SeverityAllowed', '0'),
                                  'Gender':value.get('Gender', 'dk')})
        return outvalues, {}

    def jsondumps(self, val):
        return json.dumps(val)

    def getSymptoms(self, gender=None):
        """ Returns the symptoms from the instance merged with those symptoms
            active from bika setup, with severity values assigned to default 0
        """
        outsymptoms = {}
        field = self.aq_parent.Schema()['Symptoms']
        value = field.get(self.aq_parent)
        casesymptoms = value and value or []

        if not gender:
            patient = self.aq_parent.Schema()['Patient'].get(self.aq_parent)
            gender = patient and patient.getGender() or 'dk'

        symptoms = self.bika_setup_catalog(portal_type='Symptom',
                                           is_active=True)
        for symptom in symptoms:
            symptom = symptom.getObject()
            s_gender = symptom.getGender()
            outsymptoms[symptom.UID()] = {
                'UID': symptom.UID(),
                'Title': symptom.Title(),
                'Description':symptom.Description(),
                'SeverityAllowed':symptom.getSeverityAllowed() and 1 or 0,
                'Severity':'0',
                'Assigned':0,
                'Gender':symptom.getGender(),
                'Visible':symptom.getGender()=='dk' or symptom.getGender()==gender}

        for symptom in casesymptoms:
            if 'UID' in symptom:
                if symptom['UID'] in outsymptoms \
                    and ('Severity' in symptom \
                         and symptom['Severity'] is not None \
                         and symptom['Severity'] != '0'):
                    sym = outsymptoms[symptom['UID']]
                    sym['Severity'] = symptom['Severity']
                    sym['Assigned'] = 1
                else:
                    outsymptoms[symptom['UID']] = {'UID': symptom['UID'],
                                                   'Title': symptom.get('Title',''),
                                                   'Description': symptom.get('Description',''),
                                                   'SeverityAllowed': 'SeverityAllowed' in symptom and symptom['SeverityAllowed'] or 0,
                                                   'Severity': symptom.get('Severity','0'),
                                                   'Assigned': 1,
                                                   'Gender':symptom.get('Gender', 'dk'),
                                                   'Visible':symptom.get('Gender', 'dk')=='dk' or symptom.get('Gender', 'dk')==gender}
        items=[]
        for symptom in outsymptoms.values():
            items.append(symptom)
        items.sort(lambda x, y: cmp(x['Title'].lower(), y['Title'].lower()))

        return items

registerWidget(CaseSymptomsWidget,
               title='CaseSymptomsWidget',
               description='Experiencing symptoms and severity',
               )


1			# -- coding: utf-8 --
2			#
3			# This file is part of SENAITE.HEALTH.
4			#
5			# SENAITE.HEALTH is free software: you can redistribute it and/or modify it
6			# under the terms of the GNU General Public License as published by the Free
7			# Software Foundation, version 2.
8			#
9			# This program is distributed in the hope that it will be useful, but WITHOUT
10			# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
11			# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
12			# details.
13			#
14			# You should have received a copy of the GNU General Public License along with
15			# this program; if not, write to the Free Software Foundation, Inc., 51
16			# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
17			#
18			# Copyright 2018-2019 by it's authors.
19			# Some rights reserved, see README and LICENSE.
20
21			from AccessControl import ClassSecurityInfo
22			from Products.Archetypes.Registry import registerWidget
23			from Products.Archetypes.Widget import TypesWidget
24			from Products.ATExtensions.widget import RecordsWidget as ATRecordsWidget
25			from Products.Archetypes.Registry import registerWidget
26			from Products.CMFCore.utils import getToolByName
27			from operator import itemgetter
28			import json
29
30
31			class CaseSymptomsWidget(ATRecordsWidget):
32			security = ClassSecurityInfo()
33			_properties = ATRecordsWidget._properties.copy()
34			_properties.update({
35			'macro': "bika_health_widgets/casesymptomswidget",
36			'helper_js': ("bika_health_widgets/casesymptomswidget.js",),
37			'helper_css': ("bika_health_widgets/casesymptomswidget.css",),
38			'gender': None,
39			'allowDelete': False,
40			'readonly': False,
41			'combogrid_options': '',
42			})
43
44			def process_form(self, instance, field, form, empty_marker=None,
45			emptyReturnsMarker=False):
46			outvalues = []
47			values = form.get(field.getName(), empty_marker)
48			for value in values:
49			if 'Assigned' in value and int(value['Assigned']) == 1:
50			outvalues.append({'UID': value['UID'],
51			'Title': value.get('Title', ''),
52			'Description': value.get('Description', ''),
53			'Severity': value.get(value['UID'], '0'),
54			'SeverityAllowed':value.get('SeverityAllowed', '0'),
55			'Gender':value.get('Gender', 'dk')})
56			return outvalues, {}
57
58			def jsondumps(self, val):
59			return json.dumps(val)
60
61			def getSymptoms(self, gender=None):
62			""" Returns the symptoms from the instance merged with those symptoms
63			active from bika setup, with severity values assigned to default 0
64			"""
65			outsymptoms = {}
66			field = self.aq_parent.Schema()['Symptoms']
67			value = field.get(self.aq_parent)
68			casesymptoms = value and value or []
69
70			if not gender:
71			patient = self.aq_parent.Schema()['Patient'].get(self.aq_parent)
72			gender = patient and patient.getGender() or 'dk'
73
74			symptoms = self.bika_setup_catalog(portal_type='Symptom',
75			is_active=True)
76			for symptom in symptoms:
77			symptom = symptom.getObject()
78			s_gender = symptom.getGender()
79			outsymptoms[symptom.UID()] = {
80			'UID': symptom.UID(),
81			'Title': symptom.Title(),
82			'Description':symptom.Description(),
83			'SeverityAllowed':symptom.getSeverityAllowed() and 1 or 0,
84			'Severity':'0',
85			'Assigned':0,
86			'Gender':symptom.getGender(),
87			'Visible':symptom.getGender()=='dk' or symptom.getGender()==gender}
88
89			for symptom in casesymptoms:
90			if 'UID' in symptom:
91			if symptom['UID'] in outsymptoms \
92			and ('Severity' in symptom \
93			and symptom['Severity'] is not None \
94			and symptom['Severity'] != '0'):
95			sym = outsymptoms[symptom['UID']]
96			sym['Severity'] = symptom['Severity']
97			sym['Assigned'] = 1
98			else:
99			outsymptoms[symptom['UID']] = {'UID': symptom['UID'],
100			'Title': symptom.get('Title',''),
101			'Description': symptom.get('Description',''),
102			'SeverityAllowed': 'SeverityAllowed' in symptom and symptom['SeverityAllowed'] or 0,
103			'Severity': symptom.get('Severity','0'),
104			'Assigned': 1,
105			'Gender':symptom.get('Gender', 'dk'),
106			'Visible':symptom.get('Gender', 'dk')=='dk' or symptom.get('Gender', 'dk')==gender}
107			items=[]
108			for symptom in outsymptoms.values():
109			items.append(symptom)
110			items.sort(lambda x, y: cmp(x['Title'].lower(), y['Title'].lower()))
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-02-17 08:15 UTC by Report Bug Copy Issue Report The variable `cmp` does not seem to be defined. Loading history...
111			return items
112
113			registerWidget(CaseSymptomsWidget,
114			title='CaseSymptomsWidget',
115			description='Experiencing symptoms and severity',
116			)
117

senaite / senaite.health

CaseSymptomsWidget.getSymptoms() C last analyzed 2020-02-18 09:40 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like

CaseSymptomsWidget.getSymptoms() C
last analyzed 2020-02-18 09:40 UTC