View GitHub Repository senaite.core

Schedule Inspection
Subscribe
Passed
Pull Request — 2.x (#1958)
by Jordi
05:23
created

bika.lims.browser.client.views.contacts.ClientContactsView.__init__()   B

↳ Parent: Project

Complexity

Conditions 1

Size

Total Lines 57
Code Lines 50

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
eloc 50
dl 0
loc 57
rs 8.6363
c 0
b 0
f 0
cc 1
nop 3

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1 
# -*- coding: utf-8 -*-
2 
#
3 
# This file is part of SENAITE.CORE.
4 
#
5 
# SENAITE.CORE is free software: you can redistribute it and/or modify it under
6 
# the terms of the GNU General Public License as published by the Free Software
7 
# Foundation, version 2.
8 
#
9 
# This program is distributed in the hope that it will be useful, but WITHOUT
10 
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
11 
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
12 
# details.
13 
#
14 
# You should have received a copy of the GNU General Public License along with
15 
# this program; if not, write to the Free Software Foundation, Inc., 51
16 
# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
17 
#
18 
# Copyright 2018-2021 by it's authors.
19 
# Some rights reserved, see README and LICENSE.
20 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
from bika.lims.vocabularies import CatalogVocabulary

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
class ClientContactVocabularyFactory(CatalogVocabulary):

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
    def __call__(self):

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
        return super(ClientContactVocabularyFactory, self).__call__(

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
            portal_type='Contact',

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
            path={'query': "/".join(self.context.getPhysicalPath()),

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
                  'level': 0}

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
        )

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    31