build.bika.lims.subscribers.pricelist.ObjectModifiedEventHandler() - Code Metrics - Inspection of "Some Items show the Display/State/Add menu (#1304)" - senaite/senaite.core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( feb3de...56c573 )

by Jordi

created 2019-03-28 00:25 UTC

ObjectModifiedEventHandler() F

↳ Parent: build.bika.lims.subscribers.pricelist

Complexity

Conditions

Size

Total Lines	78
Code Lines	63

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	63
dl	0
loc	78
rs	2.4
c	0
b	0
f	0
cc	16
nop	2

How to fix Long Method Complexity

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

If many parameters/temporary variables are present:
- Replace temporary variables with Query
- Introduce parameter object; often combined with preserve whole object
- If the above two are insufficient: Replace method with method object
If you have long conditionals: Decompose Conditional
Otherwise: Extract method

Complexity

Complex classes like build.bika.lims.subscribers.pricelist.ObjectModifiedEventHandler() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

# -*- coding: utf-8 -*-
#
# This file is part of SENAITE.CORE
#
# Copyright 2018 by it's authors.
# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.

from persistent.mapping import PersistentMapping


class PricelistLineItem(PersistentMapping):
    pass


def apply_discount(price=None, discount=None):
    return float(price) - (float(price) * float(discount)) / 100


def get_vat_amount(price, vat_perc):
    return float(price) * float(vat_perc) / 100


def ObjectModifiedEventHandler(instance, event):
    """ Various types need automation on edit.
    """
    if not hasattr(instance, 'portal_type'):
        return

    if instance.portal_type == 'Pricelist':
        """ Create price list line items
        """
        # Remove existing line items
        instance.pricelist_lineitems = []
        for p in instance.portal_catalog(portal_type=instance.getType(),
                                         is_active=True):
            obj = p.getObject()
            itemDescription = None
            itemAccredited = False
            if instance.getType() == "LabProduct":
                print_detail = ""
                if obj.getVolume():
                    print_detail = print_detail + str(obj.getVolume())
                if obj.getUnit():
                    print_detail = print_detail + str(obj.getUnit())
                if obj.getVolume() or obj.getUnit():
                    print_detail = " (" + print_detail + ")"
                    itemTitle = obj.Title() + print_detail
                else:
                    itemTitle = obj.Title()
                cat = None
                if obj.getPrice():
                    price = float(obj.getPrice())
                    totalprice = float(obj.getTotalPrice())
                    vat = totalprice - price
                else:
                    price = 0
                    totalprice = 0
                    vat = 0
            elif instance.getType() == "AnalysisService":

                if str(obj.getUnit()):
                    print_detail = " (" + str(obj.getUnit()) + ")"
                    itemTitle = obj.Title() + print_detail
                else:
                    itemTitle = obj.Title()
                itemAccredited = obj.getAccredited()

                cat = obj.getCategoryTitle()
                if instance.getBulkDiscount():
                    price = float(obj.getBulkPrice())
                    vat = get_vat_amount(price, obj.getVAT())
                    totalprice = price + vat
                else:
                    if instance.getBulkPrice():
                        discount = instance.getBulkPrice()
                        price = float(obj.getPrice())
                        price = apply_discount(price, discount)
                        vat = get_vat_amount(price, obj.getVAT())
                        totalprice = price + vat
                    elif obj.getPrice():
                        price = float(obj.getPrice())
                        vat = get_vat_amount(price, obj.getVAT())
                        totalprice = price + vat
                    else:
                        totalprice = 0
                        price = 0
                        vat = 0

            if instance.getDescriptions():
                itemDescription = obj.Description()

            li = PricelistLineItem()
            li["title"] = itemTitle

            li["ItemDescription"] = itemDescription
            li["CategoryTitle"] = cat

            li["Accredited"] = itemAccredited
            li["Subtotal"] = "%0.2f" % price

            li["VATAmount"] = "%0.2f" % vat

            li["Total"] = "%0.2f" % totalprice

            instance.pricelist_lineitems.append(li)


1			# -- coding: utf-8 --
2			#
3			# This file is part of SENAITE.CORE
4			#
5			# Copyright 2018 by it's authors.
6			# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.
7
8			from persistent.mapping import PersistentMapping
9
10
11			class PricelistLineItem(PersistentMapping):
12			pass
13
14
15			def apply_discount(price=None, discount=None):
16			return float(price) - (float(price) * float(discount)) / 100
17
18
19			def get_vat_amount(price, vat_perc):
20			return float(price) * float(vat_perc) / 100
21
22
23			def ObjectModifiedEventHandler(instance, event):
24			""" Various types need automation on edit.
25			"""
26			if not hasattr(instance, 'portal_type'):
27			return
28
29			if instance.portal_type == 'Pricelist':
30			""" Create price list line items
31			"""
32			# Remove existing line items
33			instance.pricelist_lineitems = []
34			for p in instance.portal_catalog(portal_type=instance.getType(),
35			is_active=True):
36			obj = p.getObject()
37			itemDescription = None
38			itemAccredited = False
39			if instance.getType() == "LabProduct":
40			print_detail = ""
41			if obj.getVolume():
42			print_detail = print_detail + str(obj.getVolume())
43			if obj.getUnit():
44			print_detail = print_detail + str(obj.getUnit())
45			if obj.getVolume() or obj.getUnit():
46			print_detail = " (" + print_detail + ")"
47			itemTitle = obj.Title() + print_detail
48			else:
49			itemTitle = obj.Title()
50			cat = None
51			if obj.getPrice():
52			price = float(obj.getPrice())
53			totalprice = float(obj.getTotalPrice())
54			vat = totalprice - price
55			else:
56			price = 0
57			totalprice = 0
58			vat = 0
59			elif instance.getType() == "AnalysisService":
60
61			if str(obj.getUnit()):
62			print_detail = " (" + str(obj.getUnit()) + ")"
63			itemTitle = obj.Title() + print_detail
64			else:
65			itemTitle = obj.Title()
66			itemAccredited = obj.getAccredited()
67
68			cat = obj.getCategoryTitle()
69			if instance.getBulkDiscount():
70			price = float(obj.getBulkPrice())
71			vat = get_vat_amount(price, obj.getVAT())
72			totalprice = price + vat
73			else:
74			if instance.getBulkPrice():
75			discount = instance.getBulkPrice()
76			price = float(obj.getPrice())
77			price = apply_discount(price, discount)
78			vat = get_vat_amount(price, obj.getVAT())
79			totalprice = price + vat
80			elif obj.getPrice():
81			price = float(obj.getPrice())
82			vat = get_vat_amount(price, obj.getVAT())
83			totalprice = price + vat
84			else:
85			totalprice = 0
86			price = 0
87			vat = 0
88
89			if instance.getDescriptions():
90			itemDescription = obj.Description()
91
92			li = PricelistLineItem()
93			li["title"] = itemTitle
			0 ignored issues – show introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `itemTitle` does not seem to be defined for all execution paths. Loading history...
94			li["ItemDescription"] = itemDescription
95			li["CategoryTitle"] = cat
			0 ignored issues – show introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `cat` does not seem to be defined for all execution paths. Loading history...
96			li["Accredited"] = itemAccredited
97			li["Subtotal"] = "%0.2f" % price
			0 ignored issues – show introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `price` does not seem to be defined for all execution paths. Loading history...
98			li["VATAmount"] = "%0.2f" % vat
			0 ignored issues – show introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `vat` does not seem to be defined for all execution paths. Loading history...
99			li["Total"] = "%0.2f" % totalprice
			0 ignored issues – show introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `totalprice` does not seem to be defined for all execution paths. Loading history...
100			instance.pricelist_lineitems.append(li)
101

senaite / senaite.core

Push — master ( feb3de...56c573 )

ObjectModifiedEventHandler() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like