bika.lims.content.organisation.Organisation.getPossibleAddresses() - Code Metrics - Inspection of "Remove `uniquefieldvalidator` for Client Names (#..." - senaite/senaite.core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( add294...9021cb )

by Jordi

created 2019-02-06 19:32 UTC

Organisation.getPossibleAddresses() A

↳ Parent: bika.lims.content.organisation

Complexity

Conditions

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nop	1

# -*- coding: utf-8 -*-
#
# This file is part of SENAITE.CORE
#
# Copyright 2018 by it's authors.
# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.

from AccessControl import ClassSecurityInfo
from bika.lims import bikaMessageFactory as _
from bika.lims.browser.fields import AddressField
from bika.lims.browser.widgets import AddressWidget
from bika.lims.config import PROJECTNAME
from bika.lims.content.bikaschema import BikaFolderSchema
from bika.lims.content.bikaschema import BikaSchema
from plone.app.folder.folder import ATFolder
from Products.Archetypes.public import ManagedSchema
from Products.Archetypes.public import StringField
from Products.Archetypes.public import StringWidget
from Products.Archetypes.public import registerType
from Products.CMFCore import permissions as CMFCorePermissions
from Products.CMFPlone.utils import safe_unicode


schema = BikaFolderSchema.copy() + BikaSchema.copy() + ManagedSchema((

    StringField(
        "Name",
        required=1,
        searchable=True,
        widget=StringWidget(
            label=_("Name"),
        ),
    ),

    StringField(
        "TaxNumber",
        widget=StringWidget(
            label=_("VAT number"),
        ),
    ),

    StringField(
        "Phone",
        widget=StringWidget(
            label=_("Phone"),
        ),
    ),

    StringField(
        "Fax",
        widget=StringWidget(
            label=_("Fax"),
        ),
    ),

    StringField(
        "EmailAddress",
        schemata="Address",
        widget=StringWidget(
            label=_("Email Address"),
        ),
        validators=("isEmail", )
    ),

    AddressField(
        "PhysicalAddress",
        schemata="Address",
        widget=AddressWidget(
            label=_("Physical address"),
        ),
        subfield_validators={
            "country": "inline_field_validator",
            "state": "inline_field_validator",
            "district": "inline_field_validator",
        },
    ),

    AddressField(
        "PostalAddress",
        schemata="Address",
        widget=AddressWidget(
            label=_("Postal address"),
        ),
        subfield_validators={
            "country": "inline_field_validator",
            "state": "inline_field_validator",
            "district": "inline_field_validator",
        },
    ),

    AddressField(
        "BillingAddress",
        schemata="Address",
        widget=AddressWidget(
            label=_("Billing address"),
        ),
        subfield_validators={
            "country": "inline_field_validator",
            "state": "inline_field_validator",
            "district": "inline_field_validator",
        },
    ),

    StringField(
        "AccountType",
        schemata="Bank details",
        widget=StringWidget(
            label=_("Account Type"),
        ),
    ),

    StringField(
        "AccountName",
        schemata="Bank details",
        widget=StringWidget(
            label=_("Account Name"),
        ),
    ),

    StringField(
        "AccountNumber",
        schemata="Bank details",
        widget=StringWidget(
            label=_("Account Number"),
        ),
    ),

    StringField(
        "BankName",
        schemata="Bank details",
        widget=StringWidget(
            label=_("Bank name"),
        ),
    ),

    StringField(
        "BankBranch",
        schemata="Bank details",
        widget=StringWidget(
            label=_("Bank branch"),
        ),
    ),
),
)

IdField = schema["id"]
IdField.widget.visible = {"edit": "visible", "view": "invisible"}

TitleField = schema["title"]
TitleField.required = 0
TitleField.widget.visible = {"edit": "hidden", "view": "invisible"}


class Organisation(ATFolder):
    """Base class for Clients, Suppliers and for the Laboratory
    """

    security = ClassSecurityInfo()
    displayContentsTab = False
    schema = schema


    security.declareProtected(CMFCorePermissions.View, "getSchema")

    def getSchema(self):
        return self.schema

    def Title(self):
        """Return the name of the Organisation
        """
        field = self.getField("Name")
        field = field and field.get(self) or ""
        return safe_unicode(field).encode("utf-8")

    def setTitle(self, value):
        """Set the name of the Organisation
        """
        return self.setName(value)

    def getPossibleAddresses(self):
        """Get the possible address fields
        """
        return ["PhysicalAddress", "PostalAddress", "BillingAddress"]

    def getPrintAddress(self):
        """Get an address for printing
        """
        address_lines = []

        addresses = [
            self.getPostalAddress(),
            self.getPhysicalAddress(),
            self.getBillingAddress(),
        ]

        for address in addresses:
            city = address.get("city", "")
            zip = address.get("zip", "")
            state = address.get("state", "")
            country = address.get("country", "")

            if city:
                address_lines = [
                    address["address"].strip(),
                    "{} {}".format(city, zip).strip(),
                    "{} {}".format(state, country).strip(),
                ]
                break

        return address_lines


registerType(Organisation, PROJECTNAME)


1			# -- coding: utf-8 --
2			#
3			# This file is part of SENAITE.CORE
4			#
5			# Copyright 2018 by it's authors.
6			# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.
7
8			from AccessControl import ClassSecurityInfo
9			from bika.lims import bikaMessageFactory as _
10			from bika.lims.browser.fields import AddressField
11			from bika.lims.browser.widgets import AddressWidget
12			from bika.lims.config import PROJECTNAME
13			from bika.lims.content.bikaschema import BikaFolderSchema
14			from bika.lims.content.bikaschema import BikaSchema
15			from plone.app.folder.folder import ATFolder
16			from Products.Archetypes.public import ManagedSchema
17			from Products.Archetypes.public import StringField
18			from Products.Archetypes.public import StringWidget
19			from Products.Archetypes.public import registerType
20			from Products.CMFCore import permissions as CMFCorePermissions
21			from Products.CMFPlone.utils import safe_unicode
22
23
24			schema = BikaFolderSchema.copy() + BikaSchema.copy() + ManagedSchema((
25
26			StringField(
27			"Name",
28			required=1,
29			searchable=True,
30			widget=StringWidget(
31			label=_("Name"),
32			),
33			),
34
35			StringField(
36			"TaxNumber",
37			widget=StringWidget(
38			label=_("VAT number"),
39			),
40			),
41
42			StringField(
43			"Phone",
44			widget=StringWidget(
45			label=_("Phone"),
46			),
47			),
48
49			StringField(
50			"Fax",
51			widget=StringWidget(
52			label=_("Fax"),
53			),
54			),
55
56			StringField(
57			"EmailAddress",
58			schemata="Address",
59			widget=StringWidget(
60			label=_("Email Address"),
61			),
62			validators=("isEmail", )
63			),
64
65			AddressField(
66			"PhysicalAddress",
67			schemata="Address",
68			widget=AddressWidget(
69			label=_("Physical address"),
70			),
71			subfield_validators={
72			"country": "inline_field_validator",
73			"state": "inline_field_validator",
74			"district": "inline_field_validator",
75			},
76			),
77
78			AddressField(
79			"PostalAddress",
80			schemata="Address",
81			widget=AddressWidget(
82			label=_("Postal address"),
83			),
84			subfield_validators={
85			"country": "inline_field_validator",
86			"state": "inline_field_validator",
87			"district": "inline_field_validator",
88			},
89			),
90
91			AddressField(
92			"BillingAddress",
93			schemata="Address",
94			widget=AddressWidget(
95			label=_("Billing address"),
96			),
97			subfield_validators={
98			"country": "inline_field_validator",
99			"state": "inline_field_validator",
100			"district": "inline_field_validator",
101			},
102			),
103
104			StringField(
105			"AccountType",
106			schemata="Bank details",
107			widget=StringWidget(
108			label=_("Account Type"),
109			),
110			),
111
112			StringField(
113			"AccountName",
114			schemata="Bank details",
115			widget=StringWidget(
116			label=_("Account Name"),
117			),
118			),
119
120			StringField(
121			"AccountNumber",
122			schemata="Bank details",
123			widget=StringWidget(
124			label=_("Account Number"),
125			),
126			),
127
128			StringField(
129			"BankName",
130			schemata="Bank details",
131			widget=StringWidget(
132			label=_("Bank name"),
133			),
134			),
135
136			StringField(
137			"BankBranch",
138			schemata="Bank details",
139			widget=StringWidget(
140			label=_("Bank branch"),
141			),
142			),
143			),
144			)
145
146			IdField = schema["id"]
147			IdField.widget.visible = {"edit": "visible", "view": "invisible"}
148
149			TitleField = schema["title"]
150			TitleField.required = 0
151			TitleField.widget.visible = {"edit": "hidden", "view": "invisible"}
152
153
154			class Organisation(ATFolder):
155			"""Base class for Clients, Suppliers and for the Laboratory
156			"""
157
158			security = ClassSecurityInfo()
159			displayContentsTab = False
160			schema = schema
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `schema` does not seem to be defined. Loading history...
161
162			security.declareProtected(CMFCorePermissions.View, "getSchema")
163
164			def getSchema(self):
165			return self.schema
166
167			def Title(self):
168			"""Return the name of the Organisation
169			"""
170			field = self.getField("Name")
171			field = field and field.get(self) or ""
172			return safe_unicode(field).encode("utf-8")
173
174			def setTitle(self, value):
175			"""Set the name of the Organisation
176			"""
177			return self.setName(value)
178
179			def getPossibleAddresses(self):
180			"""Get the possible address fields
181			"""
182			return ["PhysicalAddress", "PostalAddress", "BillingAddress"]
183
184			def getPrintAddress(self):
185			"""Get an address for printing
186			"""
187			address_lines = []
188
189			addresses = [
190			self.getPostalAddress(),
191			self.getPhysicalAddress(),
192			self.getBillingAddress(),
193			]
194
195			for address in addresses:
196			city = address.get("city", "")
197			zip = address.get("zip", "")
198			state = address.get("state", "")
199			country = address.get("country", "")
200
201			if city:
202			address_lines = [
203			address["address"].strip(),
204			"{} {}".format(city, zip).strip(),
205			"{} {}".format(state, country).strip(),
206			]
207			break
208
209			return address_lines
210
211
212			registerType(Organisation, PROJECTNAME)
213

senaite / senaite.core

Push — master ( add294...9021cb )

Organisation.getPossibleAddresses() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like