bika.lims.controlpanel.bika_departments.DepartmentsView.__init__() - Code Metrics - Inspection of "Refactored Analysis Categories Listing (#953)" - senaite/senaite.core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 26b04a...d80550 )

by Jordi

created 2018-08-04 17:14 UTC

DepartmentsView.init() B

↳ Parent: bika.lims.controlpanel.bika_departments

Complexity

Conditions

Size

Total Lines	69
Code Lines	55

Duplication

Lines	69
Ratio	100 %

Importance

Changes

Metric	Value
eloc	55
dl	69
loc	69
rs	8.4727
c	0
b	0
f	0
cc	1
nop	3

How to fix Long Method

# -*- coding: utf-8 -*-
#
# This file is part of SENAITE.CORE
#
# Copyright 2018 by it's authors.
# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.

import collections

from bika.lims import api
from bika.lims import bikaMessageFactory as _
from bika.lims.browser.bika_listing import BikaListingView
from bika.lims.config import PROJECTNAME
from bika.lims.interfaces import IDepartments
from bika.lims.utils import get_email_link
from bika.lims.utils import get_link
from plone.app.content.browser.interfaces import IFolderContentsView
from plone.app.folder.folder import ATFolder
from plone.app.folder.folder import ATFolderSchema
from plone.app.layout.globals.interfaces import IViewView
from Products.Archetypes import atapi
from Products.Archetypes.utils import DisplayList
from Products.ATContentTypes.content import schemata
from zope.interface.declarations import implements


# TODO: Separate content and view into own modules!


class DepartmentsView(BikaListingView):
    implements(IFolderContentsView, IViewView)

    def __init__(self, context, request):

        super(DepartmentsView, self).__init__(context, request)

        self.catalog = "bika_setup_catalog"

        self.contentFilter = {
            "portal_type": "Department",
            "sort_order": "ascending",
            "sort_on": "sortable_title"
        }

        self.context_actions = {
            _("Add"): {
                "url": "createObject?type_name=Department",
                "permission": "Add portal content",
                "icon": "++resource++bika.lims.images/add.png"}
        }

        self.title = self.context.translate(_("Lab Departments"))
        self.icon = "{}/{}".format(
            self.portal_url,
            "/++resource++bika.lims.images/department_big.png"
        )

        self.show_sort_column = False
        self.show_select_row = False
        self.show_select_column = True
        self.pagesize = 25

        self.columns = collections.OrderedDict((
            ("Title", {
                "title": _("Department"),
                "index": "sortable_title"}),
            ("Description", {
                "title": _("Description"),
                "index": "Description",
                "toggle": True}),
            ("Manager", {
                "title": _("Manager"),
                "index": "getManagerName",
                "toggle": True}),
            ("ManagerPhone", {
                "title": _("Manager Phone"),
                "index": "getManagerPhone",
                "toggle": True}),
            ("ManagerEmail", {
                "title": _("Manager Email"),
                "index": "getManagerEmail",
                "toggle": True}),
        ))

        self.review_states = [
            {
                "id": "default",
                "title": _("Active"),
                "contentFilter": {"inactive_state": "active"},
                "transitions": [{"id": "deactivate"}, ],
                "columns": self.columns.keys(),
            }, {
                "id": "inactive",
                "title": _("Dormant"),
                "contentFilter": {"inactive_state": "inactive"},
                "transitions": [{"id": "activate"}, ],
                "columns": self.columns.keys(),
            }, {
                "id": "all",
                "title": _("All"),
                "contentFilter": {},
                "columns": self.columns.keys(),
            },
        ]

    def before_render(self):
        """Before template render hook
        """
        # Don't allow any context actions
        self.request.set("disable_border", 1)

    def folderitem(self, obj, item, index):
        """Service triggered each time an item is iterated in folderitems.
        The use of this service prevents the extra-loops in child objects.
        :obj: the instance of the class to be foldered
        :item: dict containing the properties of the object to be used by
            the template
        :index: current index of the item
        """
        title = obj.Title()
        description = obj.Description()
        url = obj.absolute_url()

        item["replace"]["Title"] = get_link(url, value=title)
        item["Description"] = description

        manager = obj.getManager()
        manager_name = obj.getManagerName()
        manager_phone = obj.getManagerPhone()
        manager_email = obj.getManagerEmail()

        if manager:
            item["Manager"] = manager_name
            item["replace"]["Manager"] = get_link(
                manager.absolute_url(), manager_name)
        else:
            item["Manager"] = ""

        if manager_email:
            item["ManagerEmail"] = manager_email
            item["replace"]["ManagerEmail"] = get_email_link(
                manager_email, value=manager_email)
        else:
            item["ManagerEmail"] = ""

        item["ManagerPhone"] = manager_phone

        return item


schema = ATFolderSchema.copy()


class Departments(ATFolder):
    implements(IDepartments)
    displayContentsTab = False
    schema = schema


    def getContacts(self, active_only=True):
        catalog = api.get_tool("bika_setup_catalog")
        query = {
            "portal_type": "LabContact",
            "sort_on": "sortable_title",
            "sort_order": "ascending"
        }
        results = catalog(query)

        # XXX  Better directly filter in the catalog query as soon as we have
        #      the active/inactive state in the primary workflow
        if active_only:
            results = filter(api.is_active, results)

        pairs = map(
            lambda brain: (brain.UID, brain.Title), results)

        return DisplayList(pairs)


schemata.finalizeATCTSchema(schema, folderish=True, moveDiscussion=False)
atapi.registerType(Departments, PROJECTNAME)


1		# -- coding: utf-8 --
2		#
3		# This file is part of SENAITE.CORE
4		#
5		# Copyright 2018 by it's authors.
6		# Some rights reserved. See LICENSE.rst, CONTRIBUTORS.rst.
7
8		import collections
9
10		from bika.lims import api
11		from bika.lims import bikaMessageFactory as _
12		from bika.lims.browser.bika_listing import BikaListingView
13		from bika.lims.config import PROJECTNAME
14		from bika.lims.interfaces import IDepartments
15		from bika.lims.utils import get_email_link
16		from bika.lims.utils import get_link
17		from plone.app.content.browser.interfaces import IFolderContentsView
18		from plone.app.folder.folder import ATFolder
19		from plone.app.folder.folder import ATFolderSchema
20		from plone.app.layout.globals.interfaces import IViewView
21		from Products.Archetypes import atapi
22		from Products.Archetypes.utils import DisplayList
23		from Products.ATContentTypes.content import schemata
24		from zope.interface.declarations import implements
25
26
27		# TODO: Separate content and view into own modules!
28
29
30		class DepartmentsView(BikaListingView):
31		implements(IFolderContentsView, IViewView)
32
33	View Code Duplication	def __init__(self, context, request):
		0 ignored issues – show Duplication introduced 2017-12-01 14:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
34		super(DepartmentsView, self).__init__(context, request)
35
36		self.catalog = "bika_setup_catalog"
37
38		self.contentFilter = {
39		"portal_type": "Department",
40		"sort_order": "ascending",
41		"sort_on": "sortable_title"
42		}
43
44		self.context_actions = {
45		_("Add"): {
46		"url": "createObject?type_name=Department",
47		"permission": "Add portal content",
48		"icon": "++resource++bika.lims.images/add.png"}
49		}
50
51		self.title = self.context.translate(_("Lab Departments"))
52		self.icon = "{}/{}".format(
53		self.portal_url,
54		"/++resource++bika.lims.images/department_big.png"
55		)
56
57		self.show_sort_column = False
58		self.show_select_row = False
59		self.show_select_column = True
60		self.pagesize = 25
61
62		self.columns = collections.OrderedDict((
63		("Title", {
64		"title": _("Department"),
65		"index": "sortable_title"}),
66		("Description", {
67		"title": _("Description"),
68		"index": "Description",
69		"toggle": True}),
70		("Manager", {
71		"title": _("Manager"),
72		"index": "getManagerName",
73		"toggle": True}),
74		("ManagerPhone", {
75		"title": _("Manager Phone"),
76		"index": "getManagerPhone",
77		"toggle": True}),
78		("ManagerEmail", {
79		"title": _("Manager Email"),
80		"index": "getManagerEmail",
81		"toggle": True}),
82		))
83
84		self.review_states = [
85		{
86		"id": "default",
87		"title": _("Active"),
88		"contentFilter": {"inactive_state": "active"},
89		"transitions": [{"id": "deactivate"}, ],
90		"columns": self.columns.keys(),
91		}, {
92		"id": "inactive",
93		"title": _("Dormant"),
94		"contentFilter": {"inactive_state": "inactive"},
95		"transitions": [{"id": "activate"}, ],
96		"columns": self.columns.keys(),
97		}, {
98		"id": "all",
99		"title": _("All"),
100		"contentFilter": {},
101		"columns": self.columns.keys(),
102		},
103		]
104
105		def before_render(self):
106		"""Before template render hook
107		"""
108		# Don't allow any context actions
109		self.request.set("disable_border", 1)
110
111		def folderitem(self, obj, item, index):
112		"""Service triggered each time an item is iterated in folderitems.
113		The use of this service prevents the extra-loops in child objects.
114		:obj: the instance of the class to be foldered
115		:item: dict containing the properties of the object to be used by
116		the template
117		:index: current index of the item
118		"""
119		title = obj.Title()
120		description = obj.Description()
121		url = obj.absolute_url()
122
123		item["replace"]["Title"] = get_link(url, value=title)
124		item["Description"] = description
125
126		manager = obj.getManager()
127		manager_name = obj.getManagerName()
128		manager_phone = obj.getManagerPhone()
129		manager_email = obj.getManagerEmail()
130
131		if manager:
132		item["Manager"] = manager_name
133		item["replace"]["Manager"] = get_link(
134		manager.absolute_url(), manager_name)
135		else:
136		item["Manager"] = ""
137
138		if manager_email:
139		item["ManagerEmail"] = manager_email
140		item["replace"]["ManagerEmail"] = get_email_link(
141		manager_email, value=manager_email)
142		else:
143		item["ManagerEmail"] = ""
144
145		item["ManagerPhone"] = manager_phone
146
147		return item
148
149
150		schema = ATFolderSchema.copy()
151
152
153		class Departments(ATFolder):
154		implements(IDepartments)
155		displayContentsTab = False
156		schema = schema
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-07-25 08:58 UTC by Report Bug Copy Issue Report The variable `schema` does not seem to be defined. Loading history...
157
158		def getContacts(self, active_only=True):
159		catalog = api.get_tool("bika_setup_catalog")
160		query = {
161		"portal_type": "LabContact",
162		"sort_on": "sortable_title",
163		"sort_order": "ascending"
164		}
165		results = catalog(query)
166
167		# XXX Better directly filter in the catalog query as soon as we have
168		# the active/inactive state in the primary workflow
169		if active_only:
170		results = filter(api.is_active, results)
171
172		pairs = map(
173		lambda brain: (brain.UID, brain.Title), results)
174
175		return DisplayList(pairs)
176
177
178		schemata.finalizeATCTSchema(schema, folderish=True, moveDiscussion=False)
179		atapi.registerType(Departments, PROJECTNAME)
180

senaite / senaite.core

Push — master ( 26b04a...d80550 )

DepartmentsView.__init__() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

DepartmentsView.init() B