| Conditions | 2 |
| Total Lines | 149 |
| Code Lines | 122 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # -*- coding: utf-8 -*- |
||
| 48 | def __init__(self, context, request): |
||
| 49 | super(FolderView, self).__init__(context, request) |
||
| 50 | |||
| 51 | self.catalog = WORKSHEET_CATALOG |
||
| 52 | self.contentFilter = { |
||
| 53 | "review_state": ["open", "to_be_verified", "verified", "rejected"], |
||
| 54 | "sort_on": "created", |
||
| 55 | "sort_order": "reverse" |
||
| 56 | } |
||
| 57 | |||
| 58 | self.title = self.context.translate(_("Worksheets")) |
||
| 59 | self.description = "" |
||
| 60 | |||
| 61 | self.icon = "{}/{}".format( |
||
| 62 | self.portal_url, |
||
| 63 | "++plone++senaite.core.static/assets/icons/worksheet.svg" |
||
| 64 | ) |
||
| 65 | |||
| 66 | self.context_actions = { |
||
| 67 | _("Add"): { |
||
| 68 | "url": "worksheet_add", |
||
| 69 | "icon": "++resource++bika.lims.images/add.png", |
||
| 70 | "class": "worksheet_add", |
||
| 71 | "permission": AddWorksheet, |
||
| 72 | } |
||
| 73 | } |
||
| 74 | |||
| 75 | self.show_select_column = True |
||
| 76 | self.show_select_all_checkbox = True |
||
| 77 | self.selected_state = "" |
||
| 78 | self.analyst_choices = [] |
||
| 79 | self.can_reassign = False |
||
| 80 | self.can_manage = False |
||
| 81 | |||
| 82 | self.rc = getToolByName(self, REFERENCE_CATALOG) |
||
| 83 | |||
| 84 | # this is a property of self, because self.getAnalysts returns it |
||
| 85 | self.analysts = getUsers(self, ["Manager", "LabManager", "Analyst"]) |
||
| 86 | self.analysts = self.analysts.sortedByValue() |
||
| 87 | self.analyst_choices = [] |
||
| 88 | for a in self.analysts: |
||
| 89 | self.analyst_choices.append({ |
||
| 90 | "ResultValue": a, |
||
| 91 | "ResultText": self.analysts.getValue(a), |
||
| 92 | }) |
||
| 93 | |||
| 94 | self.columns = collections.OrderedDict(( |
||
| 95 | ("getProgressPercentage", { |
||
| 96 | "title": _("Progress")}), |
||
| 97 | ("Title", { |
||
| 98 | "title": _("Worksheet"), |
||
| 99 | "index": "getId"}), |
||
| 100 | ("Analyst", { |
||
| 101 | "title": _("Analyst"), |
||
| 102 | "index": "getAnalyst"}), |
||
| 103 | ("getWorksheetTemplateTitle", { |
||
| 104 | "title": _("Template"), |
||
| 105 | "replace_url": "getWorksheetTemplateURL"}), |
||
| 106 | ("getNumberOfRegularSamples", { |
||
| 107 | "title": _("Samples")}), |
||
| 108 | ("getNumberOfQCAnalyses", { |
||
| 109 | "title": _("QC Analyses")}), |
||
| 110 | ("getNumberOfRegularAnalyses", { |
||
| 111 | "title": _("Routine Analyses")}), |
||
| 112 | ("CreationDate", { |
||
| 113 | "title": _("Created"), |
||
| 114 | "index": "created"}), |
||
| 115 | ("state_title", { |
||
| 116 | "title": _("State"), |
||
| 117 | "index": "review_state", |
||
| 118 | "attr": "state_title"}), |
||
| 119 | )) |
||
| 120 | self.review_states = [ |
||
| 121 | { |
||
| 122 | "id": "default", |
||
| 123 | "title": _("Active"), |
||
| 124 | "contentFilter": { |
||
| 125 | "review_state": [ |
||
| 126 | "open", |
||
| 127 | "to_be_verified", |
||
| 128 | ], |
||
| 129 | "sort_on": "CreationDate", |
||
| 130 | "sort_order": "reverse"}, |
||
| 131 | "transitions": [], |
||
| 132 | "custom_transitions": [], |
||
| 133 | "columns": self.columns.keys(), |
||
| 134 | }, { |
||
| 135 | "id": "open", |
||
| 136 | "title": _("Open"), |
||
| 137 | "contentFilter": { |
||
| 138 | "review_state": "open", |
||
| 139 | "sort_on": "CreationDate", |
||
| 140 | "sort_order": "reverse"}, |
||
| 141 | "transitions": [], |
||
| 142 | "custom_transitions": [], |
||
| 143 | "columns": self.columns.keys(), |
||
| 144 | }, { |
||
| 145 | "id": "to_be_verified", |
||
| 146 | "title": _("To be verified"), |
||
| 147 | "contentFilter": { |
||
| 148 | "review_state": "to_be_verified", |
||
| 149 | "sort_on": "CreationDate", |
||
| 150 | "sort_order": "reverse"}, |
||
| 151 | "transitions": [], |
||
| 152 | "custom_transitions": [], |
||
| 153 | "columns": self.columns.keys() |
||
| 154 | }, { |
||
| 155 | "id": "verified", |
||
| 156 | "title": _("Verified"), |
||
| 157 | "contentFilter": { |
||
| 158 | "review_state": "verified", |
||
| 159 | "sort_on": "CreationDate", |
||
| 160 | "sort_order": "reverse" |
||
| 161 | }, |
||
| 162 | "transitions": [], |
||
| 163 | "custom_transitions": [], |
||
| 164 | "columns": self.columns.keys(), |
||
| 165 | }, { |
||
| 166 | "id": "all", |
||
| 167 | "title": _("All"), |
||
| 168 | "contentFilter": { |
||
| 169 | "review_state": [ |
||
| 170 | "open", |
||
| 171 | "to_be_verified", |
||
| 172 | "verified", |
||
| 173 | "rejected", |
||
| 174 | ], |
||
| 175 | "sort_on":"CreationDate", |
||
| 176 | "sort_order": "reverse"}, |
||
| 177 | "transitions":[], |
||
| 178 | "custom_transitions": [], |
||
| 179 | "columns": self.columns.keys(), |
||
| 180 | }, { |
||
| 181 | # getAuthenticatedMember does not work in __init__ so "mine" is |
||
| 182 | # configured further in "folderitems" below. |
||
| 183 | "id": "mine", |
||
| 184 | "title": _("Mine"), |
||
| 185 | "contentFilter": { |
||
| 186 | "review_state": [ |
||
| 187 | "open", |
||
| 188 | "to_be_verified", |
||
| 189 | "verified", |
||
| 190 | "rejected" |
||
| 191 | ], |
||
| 192 | "sort_on":"CreationDate", |
||
| 193 | "sort_order": "reverse"}, |
||
| 194 | "transitions":[], |
||
| 195 | "custom_transitions": [], |
||
| 196 | "columns": self.columns.keys(), |
||
| 197 | } |
||
| 422 |