bika.lims.browser.fields.remarksfield.RemarksField.to_safe_html() - Code Metrics - Inspection of "Fix possible XSS in remarks field" - senaite/senaite.core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 2.x (#1883)

by Jordi

created 2021-11-22 08:09 UTC

RemarksField.to_safe_html() A

↳ Parent: bika.lims.browser.fields.remarksfield

Complexity

Conditions

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nop	2

# -*- coding: utf-8 -*-
#
# This file is part of SENAITE.CORE.
#
# SENAITE.CORE is free software: you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free Software
# Foundation, version 2.
#
# This program is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
# details.
#
# You should have received a copy of the GNU General Public License along with
# this program; if not, write to the Free Software Foundation, Inc., 51
# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Copyright 2018-2021 by it's authors.
# Some rights reserved, see README and LICENSE.

import re

import six

from AccessControl import ClassSecurityInfo
from bika.lims import api
from bika.lims.browser.widgets import RemarksWidget
from bika.lims.events import RemarksAddedEvent
from bika.lims.interfaces import IRemarksField
from bika.lims.utils import tmpID
from DateTime import DateTime
from Products.Archetypes.event import ObjectEditedEvent
from Products.Archetypes.Field import ObjectField
from Products.Archetypes.Registry import registerField
from Products.CMFPlone.i18nl10n import ulocalized_time
from zope import event
from zope.interface import implements


class RemarksHistory(list):
    """A list containing a remarks history, but __str__ returns the legacy
    format from instances prior v1.3.3
    """

    def html(self):
        return api.text_to_html(str(self))

    def __str__(self):
        """Returns the remarks in legacy format
        """
        remarks = map(lambda rec: str(rec), self)
        remarks = filter(None, remarks)
        return "\n".join(remarks)

    def __eq__(self, y):
        if isinstance(y, six.string_types):
            return str(self) == y
        return super(RemarksHistory, self).__eq__(y)


class RemarksHistoryRecord(dict):
    """A dict implementation that represents a record/entry of Remarks History
    """

    def __init__(self, *arg, **kw):
        super(RemarksHistoryRecord, self).__init__(*arg, **kw)
        self["id"] = self.id or tmpID()
        self["user_id"] = self.user_id
        self["user_name"] = self.user_name
        self["created"] = self.created or DateTime().ISO()
        self["content"] = self.content

    @property
    def id(self):
        return self.get("id", "")

    @property
    def user_id(self):
        return self.get("user_id", "")

    @property
    def user_name(self):
        return self.get("user_name", "")

    @property
    def created(self):
        return self.get("created", "")

    @property
    def created_ulocalized(self):
        return ulocalized_time(self.created,
                               long_format=True,
                               context=api.get_portal(),
                               request=api.get_request(),
                               domain="senaite.core")

    @property
    def content(self):
        return self.get("content", "")

    @property
    def html_content(self):
        return api.text_to_html(self.content)

    def __str__(self):
        """Returns a legacy string format of the Remarks record
        """
        if not self.content:
            return ""
        if self.created and self.user_id:
            # Build the legacy format
            return "=== {} ({})\n{}".format(self.created, self.user_id,
                                            self.content)
        return self.content


class RemarksField(ObjectField):
    """A field that stores remarks.  The value submitted to the setter
    will always be appended to the actual value of the field.
    A divider will be included with extra information about the text.
    """

    _properties = ObjectField._properties.copy()
    _properties.update({
        'type': 'remarks',
        'widget': RemarksWidget,
        'default': '',
    })

    implements(IRemarksField)
    security = ClassSecurityInfo()

    @property
    def searchable(self):
        """Returns False, preventing this field to be searchable by AT's
        SearcheableText
        """
        return False

    @security.private
    def set(self, instance, value, **kwargs):
        """Adds the value to the existing text stored in the field,
        along with a small divider showing username and date of this entry.
        """

        if not value:
            return

        if isinstance(value, RemarksHistory):
            # Override the whole history here
            history = value

        elif isinstance(value, (list, tuple)):
            # This is a list, convert to RemarksHistory
            remarks = map(lambda item: RemarksHistoryRecord(item), value)
            history = RemarksHistory(remarks)

        elif isinstance(value, RemarksHistoryRecord):
            # This is a record, append to the history
            history = self.get_history(instance)
            history.insert(0, value)

        elif isinstance(value, six.string_types):
            # Create a new history record
            record = self.to_history_record(value)

            # Append the new record to the history
            history = self.get_history(instance)
            history.insert(0, record)

        else:
            raise ValueError("Type not supported: {}".format(type(value)))

        # filter nasty html in the complete history
        for record in history:
            content = record.get("content")
            record["content"] = self.to_safe_html(content)

        # Store the data
        ObjectField.set(self, instance, history)

        # N.B. ensure updated catalog metadata for the snapshot
        instance.reindexObject()

        # notify object edited event
        event.notify(ObjectEditedEvent(instance))

        # notify new remarks for e.g. later email notification etc.
        event.notify(RemarksAddedEvent(instance, history))

    def to_safe_html(self, html):
        # see: Products.PortalTransforms.tests.test_xss
        pt = api.get_tool("portal_transforms")
        stream = pt.convertTo("text/x-html-safe", html)
        return stream.getData()

    def get(self, instance, **kwargs):
        """Returns a RemarksHistory object
        """
        return self.get_history(instance)

    def getRaw(self, instance, **kwargs):
        """Returns raw field value (possible wrapped in BaseUnit)
        """
        value = ObjectField.get(self, instance, **kwargs)
        # getattr(instance, "Remarks") returns a BaseUnit
        if callable(value):
            value = value()
        return value

    def to_history_record(self, value):
        """Transforms the value to an history record
        """
        user = api.get_current_user()
        contact = api.get_user_contact(user)
        fullname = contact and contact.getFullname() or ""
        if not contact:
            # get the fullname from the user properties
            props = api.get_user_properties(user)
            fullname = props.get("fullname", "")
        return RemarksHistoryRecord(user_id=user.id,
                                    user_name=fullname,
                                    content=value.strip())

    def get_history(self, instance):
        """Returns a RemarksHistory object with the remarks entries
        """
        remarks = instance.getRawRemarks()
        if not remarks:
            return RemarksHistory()

        # Backwards compatibility with legacy from < v1.3.3
        if isinstance(remarks, six.string_types):
            parsed_remarks = self._parse_legacy_remarks(remarks)
            if parsed_remarks is None:
                remark = RemarksHistoryRecord(content=remarks.strip())
                remarks = RemarksHistory([remark, ])
            else:
                remarks = RemarksHistory(
                    map(lambda r: RemarksHistoryRecord(r), parsed_remarks))

        return remarks

    def _parse_legacy_remarks(self, text):
        """Parse legacy remarks from the text
        """

        # split legacy remarks on the complete delimiter, e.g.:
        # === Tue, 28 Jan 2020 06:53:58 +0100 (admin)\nThis is a Test
        lines = re.split(r"(===) ([A-Za-z]{3}, \d{1,2} [A-Za-z]{3} \d{2,4} \d{2}:\d{2}:\d{2} [+-]{1}\d{4}) \((.*?)\)", text)  # noqa

        record = None
        records = []

        # group into remark records of date, user-id and content
        for line in lines:
            # start a new remarks record when the marker was found
            if line == "===":
                record = []
                # immediately append the new entry to the records
                records.append(record)
                # skip the marker entry
                continue

            # append the line to the entry until the next marker is found
            # -> this also skips the empty first line
            if record is not None:
                record.append(line)

        remarks = []

        for record in records:
            # each record must contain the date, user-id and text
            # -> we invalidate the whole parsing if this is not given
            if len(record) != 3:
                return None

            created, userid, content = record

            # try to get the full name of the user id
            fullname = self._get_fullname_from_user_id(userid)

            # strip off leading and trailing escape sequences from the content
            content = content.strip("\n\r\t")

            # append a remarks record
            remarks.append({
               "created": created,
               "user_id": userid,
               "user_name": fullname,
               "content": content,
            })

        return remarks

    def _get_fullname_from_user_id(self, userid, default=""):
        """Try the fullname of the user
        """
        fullname = default
        user = api.get_user(userid)
        if user:
            props = api.get_user_properties(user)
            fullname = props.get("fullname", fullname)
            contact = api.get_user_contact(user)
            fullname = contact and contact.getFullname() or fullname
        return fullname


registerField(RemarksField, title="Remarks", description="")


1			# -- coding: utf-8 --
2			#
3			# This file is part of SENAITE.CORE.
4			#
5			# SENAITE.CORE is free software: you can redistribute it and/or modify it under
6			# the terms of the GNU General Public License as published by the Free Software
7			# Foundation, version 2.
8			#
9			# This program is distributed in the hope that it will be useful, but WITHOUT
10			# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
11			# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
12			# details.
13			#
14			# You should have received a copy of the GNU General Public License along with
15			# this program; if not, write to the Free Software Foundation, Inc., 51
16			# Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
17			#
18			# Copyright 2018-2021 by it's authors.
19			# Some rights reserved, see README and LICENSE.
20
21			import re
22
23			import six
24
25			from AccessControl import ClassSecurityInfo
26			from bika.lims import api
27			from bika.lims.browser.widgets import RemarksWidget
28			from bika.lims.events import RemarksAddedEvent
29			from bika.lims.interfaces import IRemarksField
30			from bika.lims.utils import tmpID
31			from DateTime import DateTime
32			from Products.Archetypes.event import ObjectEditedEvent
33			from Products.Archetypes.Field import ObjectField
34			from Products.Archetypes.Registry import registerField
35			from Products.CMFPlone.i18nl10n import ulocalized_time
36			from zope import event
37			from zope.interface import implements
38
39
40			class RemarksHistory(list):
41			"""A list containing a remarks history, but __str__ returns the legacy
42			format from instances prior v1.3.3
43			"""
44
45			def html(self):
46			return api.text_to_html(str(self))
47
48			def __str__(self):
49			"""Returns the remarks in legacy format
50			"""
51			remarks = map(lambda rec: str(rec), self)
52			remarks = filter(None, remarks)
53			return "\n".join(remarks)
54
55			def __eq__(self, y):
56			if isinstance(y, six.string_types):
57			return str(self) == y
58			return super(RemarksHistory, self).__eq__(y)
59
60
61			class RemarksHistoryRecord(dict):
62			"""A dict implementation that represents a record/entry of Remarks History
63			"""
64
65			def __init__(self, arg, *kw):
66			super(RemarksHistoryRecord, self).__init__(arg, *kw)
67			self["id"] = self.id or tmpID()
68			self["user_id"] = self.user_id
69			self["user_name"] = self.user_name
70			self["created"] = self.created or DateTime().ISO()
71			self["content"] = self.content
72
73			@property
74			def id(self):
75			return self.get("id", "")
76
77			@property
78			def user_id(self):
79			return self.get("user_id", "")
80
81			@property
82			def user_name(self):
83			return self.get("user_name", "")
84
85			@property
86			def created(self):
87			return self.get("created", "")
88
89			@property
90			def created_ulocalized(self):
91			return ulocalized_time(self.created,
92			long_format=True,
93			context=api.get_portal(),
94			request=api.get_request(),
95			domain="senaite.core")
96
97			@property
98			def content(self):
99			return self.get("content", "")
100
101			@property
102			def html_content(self):
103			return api.text_to_html(self.content)
104
105			def __str__(self):
106			"""Returns a legacy string format of the Remarks record
107			"""
108			if not self.content:
109			return ""
110			if self.created and self.user_id:
111			# Build the legacy format
112			return "=== {} ({})\n{}".format(self.created, self.user_id,
113			self.content)
114			return self.content
115
116
117			class RemarksField(ObjectField):
118			"""A field that stores remarks. The value submitted to the setter
119			will always be appended to the actual value of the field.
120			A divider will be included with extra information about the text.
121			"""
122
123			_properties = ObjectField._properties.copy()
124			_properties.update({
125			'type': 'remarks',
126			'widget': RemarksWidget,
127			'default': '',
128			})
129
130			implements(IRemarksField)
131			security = ClassSecurityInfo()
132
133			@property
134			def searchable(self):
135			"""Returns False, preventing this field to be searchable by AT's
136			SearcheableText
137			"""
138			return False
139
140			@security.private
141			def set(self, instance, value, **kwargs):
142			"""Adds the value to the existing text stored in the field,
143			along with a small divider showing username and date of this entry.
144			"""
145
146			if not value:
147			return
148
149			if isinstance(value, RemarksHistory):
150			# Override the whole history here
151			history = value
152
153			elif isinstance(value, (list, tuple)):
154			# This is a list, convert to RemarksHistory
155			remarks = map(lambda item: RemarksHistoryRecord(item), value)
156			history = RemarksHistory(remarks)
157
158			elif isinstance(value, RemarksHistoryRecord):
159			# This is a record, append to the history
160			history = self.get_history(instance)
161			history.insert(0, value)
162
163			elif isinstance(value, six.string_types):
164			# Create a new history record
165			record = self.to_history_record(value)
166
167			# Append the new record to the history
168			history = self.get_history(instance)
169			history.insert(0, record)
170
171			else:
172			raise ValueError("Type not supported: {}".format(type(value)))
173
174			# filter nasty html in the complete history
175			for record in history:
176			content = record.get("content")
177			record["content"] = self.to_safe_html(content)
178
179			# Store the data
180			ObjectField.set(self, instance, history)
181
182			# N.B. ensure updated catalog metadata for the snapshot
183			instance.reindexObject()
184
185			# notify object edited event
186			event.notify(ObjectEditedEvent(instance))
187
188			# notify new remarks for e.g. later email notification etc.
189			event.notify(RemarksAddedEvent(instance, history))
190
191			def to_safe_html(self, html):
192			# see: Products.PortalTransforms.tests.test_xss
193			pt = api.get_tool("portal_transforms")
194			stream = pt.convertTo("text/x-html-safe", html)
195			return stream.getData()
196
197			def get(self, instance, **kwargs):
198			"""Returns a RemarksHistory object
199			"""
200			return self.get_history(instance)
201
202			def getRaw(self, instance, **kwargs):
203			"""Returns raw field value (possible wrapped in BaseUnit)
204			"""
205			value = ObjectField.get(self, instance, **kwargs)
206			# getattr(instance, "Remarks") returns a BaseUnit
207			if callable(value):
208			value = value()
209			return value
210
211			def to_history_record(self, value):
212			"""Transforms the value to an history record
213			"""
214			user = api.get_current_user()
215			contact = api.get_user_contact(user)
216			fullname = contact and contact.getFullname() or ""
217			if not contact:
218			# get the fullname from the user properties
219			props = api.get_user_properties(user)
220			fullname = props.get("fullname", "")
221			return RemarksHistoryRecord(user_id=user.id,
222			user_name=fullname,
223			content=value.strip())
224
225			def get_history(self, instance):
226			"""Returns a RemarksHistory object with the remarks entries
227			"""
228			remarks = instance.getRawRemarks()
229			if not remarks:
230			return RemarksHistory()
231
232			# Backwards compatibility with legacy from < v1.3.3
233			if isinstance(remarks, six.string_types):
234			parsed_remarks = self._parse_legacy_remarks(remarks)
235			if parsed_remarks is None:
236			remark = RemarksHistoryRecord(content=remarks.strip())
237			remarks = RemarksHistory([remark, ])
238			else:
239			remarks = RemarksHistory(
240			map(lambda r: RemarksHistoryRecord(r), parsed_remarks))
241
242			return remarks
243
244			def _parse_legacy_remarks(self, text):
245			"""Parse legacy remarks from the text
246			"""
247
248			# split legacy remarks on the complete delimiter, e.g.:
249			# === Tue, 28 Jan 2020 06:53:58 +0100 (admin)\nThis is a Test
250			lines = re.split(r"(===) ([A-Za-z]{3}, \d{1,2} [A-Za-z]{3} \d{2,4} \d{2}:\d{2}:\d{2} [+-]{1}\d{4}) \((.*?)\)", text) # noqa
251
252			record = None
253			records = []
254
255			# group into remark records of date, user-id and content
256			for line in lines:
257			# start a new remarks record when the marker was found
258			if line == "===":
259			record = []
260			# immediately append the new entry to the records
261			records.append(record)
262			# skip the marker entry
263			continue
264
265			# append the line to the entry until the next marker is found
266			# -> this also skips the empty first line
267			if record is not None:
268			record.append(line)
269
270			remarks = []
271
272			for record in records:
273			# each record must contain the date, user-id and text
274			# -> we invalidate the whole parsing if this is not given
275			if len(record) != 3:
276			return None
277
278			created, userid, content = record
279
280			# try to get the full name of the user id
281			fullname = self._get_fullname_from_user_id(userid)
282
283			# strip off leading and trailing escape sequences from the content
284			content = content.strip("\n\r\t")
285
286			# append a remarks record
287			remarks.append({
288			"created": created,
289			"user_id": userid,
290			"user_name": fullname,
291			"content": content,
292			})
293
294			return remarks
295
296			def _get_fullname_from_user_id(self, userid, default=""):
297			"""Try the fullname of the user
298			"""
299			fullname = default
300			user = api.get_user(userid)
301			if user:
302			props = api.get_user_properties(user)
303			fullname = props.get("fullname", fullname)
304			contact = api.get_user_contact(user)
305			fullname = contact and contact.getFullname() or fullname
306			return fullname
307
308
309			registerField(RemarksField, title="Remarks", description="")
310

senaite / senaite.core

Pull Request — 2.x (#1883)

RemarksField.to_safe_html() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like